mirror of
https://github.com/EchoVault/SugarDB.git
synced 2025-10-05 16:06:57 +08:00
Implemented tests for SUBSCRIBE, PSUBSCRIBE, UNSUBSCRIBE, and PUNSUBSCRIBE command handlers
This commit is contained in:
Kelvin Mwinuka
@@ -1,42 +1,281 @@
|
||||
package pubsub
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"fmt"
|
||||
"github.com/echovault/echovault/src/server"
|
||||
"github.com/echovault/echovault/src/utils"
|
||||
"github.com/tidwall/resp"
|
||||
"net"
|
||||
"slices"
|
||||
"testing"
|
||||
)
|
||||
|
||||
var pubsub *PubSub
|
||||
var mockServer *server.Server
|
||||
|
||||
var bindAddr = "localhost"
|
||||
var port uint16 = 7490
|
||||
|
||||
func init() {
|
||||
pubsub = NewPubSub()
|
||||
mockServer = server.NewServer(server.Opts{
|
||||
PubSub: pubsub,
|
||||
Config: utils.Config{
|
||||
BindAddr: bindAddr,
|
||||
Port: port,
|
||||
DataDir: "",
|
||||
EvictionPolicy: utils.NoEviction,
|
||||
},
|
||||
})
|
||||
go func() {
|
||||
mockServer.Start(context.Background())
|
||||
}()
|
||||
}
|
||||
|
||||
func Test_HandleSubscribe(t *testing.T) {
|
||||
ctx := context.WithValue(context.Background(), "test_name", "SUBSCRIBE/PSUBSCRIBE")
|
||||
|
||||
numOfConnection := 100
|
||||
connections := make([]*net.Conn, numOfConnection)
|
||||
|
||||
for i := 0; i < numOfConnection; i++ {
|
||||
conn, err := net.Dial("tcp", fmt.Sprintf("%s:%d", bindAddr, port))
|
||||
if err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
connections[i] = &conn
|
||||
}
|
||||
|
||||
// Test subscribe to channels
|
||||
channels := []string{"sub_channel1", "sub_channel2", "sub_channel3"}
|
||||
for _, conn := range connections {
|
||||
if _, err := handleSubscribe(ctx, append([]string{"SUBSCRIBE"}, channels...), mockServer, conn); err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
}
|
||||
for _, channel := range channels {
|
||||
// Check if the channel exists in the pubsub module
|
||||
if !slices.ContainsFunc(pubsub.channels, func(c *Channel) bool {
|
||||
return c.name == channel
|
||||
}) {
|
||||
t.Errorf("expected pubsub to contain channel \"%s\" but it was not found", channel)
|
||||
}
|
||||
for _, c := range pubsub.channels {
|
||||
if c.name == channel {
|
||||
// Check if channel has nil pattern
|
||||
if c.pattern != nil {
|
||||
t.Errorf("expected channel \"%s\" to have nil pattern, found pattern \"%s\"", channel, c.name)
|
||||
}
|
||||
// Check if the channel has all the connections from above
|
||||
for _, conn := range connections {
|
||||
if !slices.Contains(c.subscribers, conn) {
|
||||
t.Errorf("could not find all expected connection in the \"%s\"", channel)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Test subscribe to patterns
|
||||
patterns := []string{"psub_channel*"}
|
||||
for _, conn := range connections {
|
||||
if _, err := handleSubscribe(ctx, append([]string{"PSUBSCRIBE"}, patterns...), mockServer, conn); err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
}
|
||||
for _, pattern := range patterns {
|
||||
// Check if pattern channel exists in pubsub module
|
||||
if !slices.ContainsFunc(pubsub.channels, func(c *Channel) bool {
|
||||
return c.name == pattern
|
||||
}) {
|
||||
t.Errorf("expected pubsub to contain pattern channel \"%s\" but it was not found", pattern)
|
||||
}
|
||||
for _, c := range pubsub.channels {
|
||||
if c.name == pattern {
|
||||
// Check if channel has non-nil pattern
|
||||
if c.pattern == nil {
|
||||
t.Errorf("expected channel \"%s\" to have pattern \"%s\", found nil pattern", pattern, c.name)
|
||||
}
|
||||
// Check if the channel has all the connections from above
|
||||
for _, conn := range connections {
|
||||
if !slices.Contains(c.subscribers, conn) {
|
||||
t.Errorf("could not find all expected connection in the \"%s\"", pattern)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func Test_HandleUnsubscribe(t *testing.T) {
|
||||
generateConnections := func(noOfConnections int) []*net.Conn {
|
||||
connections := make([]*net.Conn, noOfConnections)
|
||||
for i := 0; i < noOfConnections; i++ {
|
||||
conn, err := net.Dial("tcp", fmt.Sprintf("%s:%d", bindAddr, port))
|
||||
if err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
connections[i] = &conn
|
||||
}
|
||||
return connections
|
||||
}
|
||||
|
||||
verifyResponse := func(res []byte, expectedResponse [][]string) {
|
||||
rd := resp.NewReader(bytes.NewReader(res))
|
||||
rv, _, err := rd.ReadValue()
|
||||
if err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
v := rv.Array()
|
||||
if len(v) != len(expectedResponse) {
|
||||
t.Errorf("expected subscribe response of length %d, but got %d", len(expectedResponse), len(v))
|
||||
}
|
||||
for _, item := range v {
|
||||
arr := item.Array()
|
||||
if len(arr) != 3 {
|
||||
t.Errorf("expected subscribe response item to be length %d, but got %d", 3, len(arr))
|
||||
}
|
||||
if !slices.ContainsFunc(expectedResponse, func(strings []string) bool {
|
||||
return strings[0] == arr[0].String() && strings[1] == arr[1].String() && strings[2] == arr[2].String()
|
||||
}) {
|
||||
t.Errorf("expected to find item \"%s\" in response, did not find it.", arr[1].String())
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
tests := []struct {
|
||||
subChannels []string // All channels to subscribe to
|
||||
subPatterns []string // All patterns to subscribe to
|
||||
unSubChannels []string // Channels to unsubscribe from
|
||||
unSubPatterns []string // Patterns to unsubscribe from
|
||||
remainChannels []string // Channels to remain subscribed to
|
||||
remainPatterns []string // Patterns to remain subscribed to
|
||||
targetConn *net.Conn // Connection used to test unsubscribe functionality
|
||||
otherConnections []*net.Conn // Connections to fill the subscribers list for channels and patterns
|
||||
expectedResponses map[string][][]string // The expected response from the handler
|
||||
}{
|
||||
{ // 1. Unsubscribe from channels and patterns
|
||||
subChannels: []string{"xx_channel_one", "xx_channel_two", "xx_channel_three", "xx_channel_four"},
|
||||
subPatterns: []string{"xx_pattern_[ab]", "xx_pattern_[cd]", "xx_pattern_[ef]", "xx_pattern_[gh]"},
|
||||
unSubChannels: []string{"xx_channel_one", "xx_channel_two"},
|
||||
unSubPatterns: []string{"xx_pattern_[ab]"},
|
||||
remainChannels: []string{"xx_channel_three", "xx_channel_four"},
|
||||
remainPatterns: []string{"xx_pattern_[cd]", "xx_pattern_[ef]", "xx_pattern_[gh]"},
|
||||
targetConn: generateConnections(1)[0],
|
||||
otherConnections: generateConnections(20),
|
||||
expectedResponses: map[string][][]string{
|
||||
"channel": {
|
||||
{"unsubscribe", "xx_channel_one", "1"},
|
||||
{"unsubscribe", "xx_channel_two", "2"},
|
||||
},
|
||||
"pattern": {
|
||||
{"punsubscribe", "xx_pattern_[ab]", "1"},
|
||||
},
|
||||
},
|
||||
},
|
||||
{ // 2. Unsubscribe from all channels no channel or pattern is passed to command
|
||||
subChannels: []string{"xx_channel_one", "xx_channel_two", "xx_channel_three", "xx_channel_four"},
|
||||
subPatterns: []string{"xx_pattern_[ab]", "xx_pattern_[cd]", "xx_pattern_[ef]", "xx_pattern_[gh]"},
|
||||
unSubChannels: []string{},
|
||||
unSubPatterns: []string{},
|
||||
remainChannels: []string{},
|
||||
remainPatterns: []string{},
|
||||
targetConn: generateConnections(1)[0],
|
||||
otherConnections: generateConnections(20),
|
||||
expectedResponses: map[string][][]string{
|
||||
"channel": {
|
||||
{"unsubscribe", "xx_channel_one", "1"},
|
||||
{"unsubscribe", "xx_channel_two", "2"},
|
||||
{"unsubscribe", "xx_channel_three", "3"},
|
||||
{"unsubscribe", "xx_channel_four", "4"},
|
||||
},
|
||||
"pattern": {
|
||||
{"punsubscribe", "xx_pattern_[ab]", "1"},
|
||||
{"punsubscribe", "xx_pattern_[cd]", "2"},
|
||||
{"punsubscribe", "xx_pattern_[ef]", "3"},
|
||||
{"punsubscribe", "xx_pattern_[gh]", "4"},
|
||||
},
|
||||
},
|
||||
},
|
||||
{ // 3. Don't unsubscribe from any channels or patterns if the provided ones are non-existent
|
||||
subChannels: []string{"xx_channel_one", "xx_channel_two", "xx_channel_three", "xx_channel_four"},
|
||||
subPatterns: []string{"xx_pattern_[ab]", "xx_pattern_[cd]", "xx_pattern_[ef]", "xx_pattern_[gh]"},
|
||||
unSubChannels: []string{"xx_channel_non_existent_channel"},
|
||||
unSubPatterns: []string{"xx_channel_non_existent_pattern_[ae]"},
|
||||
remainChannels: []string{"xx_channel_one", "xx_channel_two", "xx_channel_three", "xx_channel_four"},
|
||||
remainPatterns: []string{"xx_pattern_[ab]", "xx_pattern_[cd]", "xx_pattern_[ef]", "xx_pattern_[gh]"},
|
||||
targetConn: generateConnections(1)[0],
|
||||
otherConnections: generateConnections(20),
|
||||
expectedResponses: map[string][][]string{
|
||||
"channel": {},
|
||||
"pattern": {},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for i, test := range tests {
|
||||
ctx := context.WithValue(context.Background(), "test_name", fmt.Sprintf("UNSUBSCRIBE/PUNSUBSCRIBE, %d", i))
|
||||
|
||||
// Subscribe all the connections to the channels and patterns
|
||||
for _, conn := range append(test.otherConnections, test.targetConn) {
|
||||
_, err := handleSubscribe(ctx, append([]string{"SUBSCRIBE"}, test.subChannels...), mockServer, conn)
|
||||
if err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
_, err = handleSubscribe(ctx, append([]string{"PSUBSCRIBE"}, test.subPatterns...), mockServer, conn)
|
||||
if err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
}
|
||||
|
||||
// Unsubscribe the target connection from the unsub channels and patterns
|
||||
res, err := handleUnsubscribe(ctx, append([]string{"UNSUBSCRIBE"}, test.unSubChannels...), mockServer, test.targetConn)
|
||||
if err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
verifyResponse(res, test.expectedResponses["channel"])
|
||||
|
||||
res, err = handleUnsubscribe(ctx, append([]string{"PUNSUBSCRIBE"}, test.unSubPatterns...), mockServer, test.targetConn)
|
||||
if err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
verifyResponse(res, test.expectedResponses["pattern"])
|
||||
|
||||
for _, channel := range append(test.unSubChannels, test.unSubPatterns...) {
|
||||
for _, pubsubChannel := range pubsub.channels {
|
||||
if pubsubChannel.name == channel {
|
||||
// Assert that target connection is no longer in the unsub channels and patterns
|
||||
if slices.Contains(pubsubChannel.subscribers, test.targetConn) {
|
||||
t.Errorf("found unexpected target connection after unsubscrining in channel \"%s\"", channel)
|
||||
}
|
||||
for _, conn := range test.otherConnections {
|
||||
if !slices.Contains(pubsubChannel.subscribers, conn) {
|
||||
t.Errorf("did not find expected other connection in channel \"%s\"", channel)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Assert that the target connection is still in the remain channels and patterns
|
||||
for _, channel := range append(test.remainChannels, test.remainPatterns...) {
|
||||
for _, pubsubChannel := range pubsub.channels {
|
||||
if pubsubChannel.name == channel {
|
||||
if !slices.Contains(pubsubChannel.subscribers, test.targetConn) {
|
||||
t.Errorf("cound not find expected target connection in channel \"%s\"", channel)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func Test_HandlePublish(t *testing.T) {
|
||||
func Test_HandlePublish(t *testing.T) {}
|
||||
|
||||
}
|
||||
func Test_HandlePubSubChannels(t *testing.T) {}
|
||||
|
||||
func Test_HandlePubSubChannels(t *testing.T) {
|
||||
func Test_HandleNumPat(t *testing.T) {}
|
||||
|
||||
}
|
||||
|
||||
func Test_HandleNumPat(t *testing.T) {
|
||||
|
||||
}
|
||||
|
||||
func Test_HandleNumSub(t *testing.T) {
|
||||
|
||||
}
|
||||
func Test_HandleNumSub(t *testing.T) {}
|
||||
|
||||
Reference in New Issue
Block a user