Added command length tests for INCRBY command. Renamed INCRBY key func. Return WRONG_ARG_RESPONSE from key funcs when commands are not the correct length.

This commit is contained in:
Kelvin Mwinuka
2024-06-25 12:28:23 +08:00
parent 95f7175f8e
commit 5433b88776
4 changed files with 102 additions and 20 deletions

View File

@@ -477,6 +477,58 @@ func handleDecr(params internal.HandlerFuncParams) ([]byte, error) {
return []byte(fmt.Sprintf(":%d\r\n", newValue)), nil
}
func handleIncrBy(params internal.HandlerFuncParams) ([]byte, error) {
// Extract key from command
keys, err := incrByKeyFunc(params.Command)
if err != nil {
return nil, err
}
// Parse decrement value
decrValue, err := strconv.ParseInt(params.Command[2], 10, 64)
if err != nil {
return nil, errors.New("decrement value is not an integer or out of range")
}
key := keys.WriteKeys[0]
values := params.GetValues(params.Context, []string{key}) // Get the current values for the specified keys
currentValue, ok := values[key] // Check if the key exists
var newValue int64
var currentValueInt int64
// Check if the key exists and its current value
if !ok || currentValue == nil {
// If key does not exist, initialize it with the decrement value
newValue = decrValue * -1
} else {
// Use type switch to handle different types of currentValue
switch v := currentValue.(type) {
case string:
currentValueInt, err = strconv.ParseInt(v, 10, 64) // Parse the string to int64
if err != nil {
return nil, errors.New("value is not an integer or out of range")
}
case int:
currentValueInt = int64(v) // Convert int to int64
case int64:
currentValueInt = v // Use int64 value directly
default:
fmt.Printf("unexpected type for currentValue: %T\n", currentValue)
return nil, errors.New("unexpected type for currentValue") // Handle unexpected types
}
newValue = currentValueInt - decrValue // decrement the value by the specified amount
}
// Set the new incremented value
if err := params.SetValues(params.Context, map[string]interface{}{key: fmt.Sprintf("%d", newValue)}); err != nil {
return nil, err
}
// Prepare response with the actual new value
return []byte(fmt.Sprintf(":%d\r\n", newValue)), nil
}
func handleDecrBy(params internal.HandlerFuncParams) ([]byte, error) {
// Extract key from command
keys, err := decrByKeyFunc(params.Command)
@@ -722,6 +774,17 @@ This operation is limited to 64 bit signed integers.`,
KeyExtractionFunc: decrKeyFunc,
HandlerFunc: handleDecr,
},
{
Command: "incrby",
Module: constants.GenericModule,
Categories: []string{constants.KeyspaceCategory, constants.WriteCategory, constants.FastCategory},
Description: `(INCRBY key increment)
Increments the number stored at key by increment. If the key does not exist, it is set to 0 before performing the operation.
An error is returned if the key contains a value of the wrong type or contains a string that can not be represented as integer.`,
Sync: true,
KeyExtractionFunc: incrByKeyFunc,
HandlerFunc: handleIncrBy,
},
{
Command: "decrby",
Module: constants.GenericModule,