package/storage
1
0
Fork 0
mirror of https://github.com/gofiber/storage.git synced 2025-10-05 16:48:25 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

chore(minio): use require in tests

Browse Source
This commit is contained in:
Manuel de la Peña
2025-04-15 16:19:32 +02:00
parent c38280d308
commit a5733f7261
1 changed files with 34 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
minio/minio_test.go
View File

@@ -23,7 +23,7 @@ const (
minioHealthPath = "/minio/health/live" minioHealthPath = "/minio/health/live"
) )
func newTestStore(t testing.TB) (*Storage, error) { func newTestStore(t testing.TB) *Storage {
t.Helper() t.Helper()
img := minioImage img := minioImage
@@ -43,14 +43,10 @@ func newTestStore(t testing.TB) (*Storage, error) {
), ),
) )
testcontainers.CleanupContainer(t, c) testcontainers.CleanupContainer(t, c)
if err != nil { require.NoError(t, err)
return nil, err
}
conn, err := c.ConnectionString(ctx) conn, err := c.ConnectionString(ctx)
if err != nil { require.NoError(t, err)
return nil, err
}
return New( return New(
Config{ Config{
@@ -62,7 +58,7 @@ func newTestStore(t testing.TB) (*Storage, error) {
}, },
Reset: true, Reset: true,
}, },
), nil )
} }
func Test_Get(t *testing.T) { func Test_Get(t *testing.T) {
@@ -71,11 +67,10 @@ func Test_Get(t *testing.T) {
val = []byte("doe") val = []byte("doe")
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
err = testStore.Set(key, val, 0) err := testStore.Set(key, val, 0)
require.NoError(t, err) require.NoError(t, err)
result, err := testStore.Get(key) result, err := testStore.Get(key)
@@ -92,11 +87,10 @@ func Test_Get_Empty_Key(t *testing.T) {
key = "" key = ""
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
_, err = testStore.Get(key) _, err := testStore.Get(key)
require.Error(t, err) require.Error(t, err)
require.EqualError(t, err, "the key value is required") require.EqualError(t, err, "the key value is required")
} }
@@ -106,11 +100,10 @@ func Test_Get_Not_Exists_Key(t *testing.T) {
key = "not-exists" key = "not-exists"
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
_, err = testStore.Get(key) _, err := testStore.Get(key)
require.Error(t, err) require.Error(t, err)
require.EqualError(t, err, "The specified key does not exist.") require.EqualError(t, err, "The specified key does not exist.")
} }
@@ -120,8 +113,7 @@ func Test_Get_Not_Exists_Bucket(t *testing.T) {
key = "john" key = "john"
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
// random bucket name // random bucket name
@@ -139,11 +131,10 @@ func Test_Set(t *testing.T) {
val = []byte("doe") val = []byte("doe")
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
err = testStore.Set(key, val, 0) err := testStore.Set(key, val, 0)
require.NoError(t, err) require.NoError(t, err)
} }
@@ -153,12 +144,10 @@ func Test_Set_Empty_Key(t *testing.T) {
val = []byte("doe") val = []byte("doe")
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
err = testStore.Set(key, val, 0) err := testStore.Set(key, val, 0)
require.Error(t, err) require.Error(t, err)
require.EqualError(t, err, "the key value is required") require.EqualError(t, err, "the key value is required")
@@ -170,14 +159,13 @@ func Test_Set_Not_Exists_Bucket(t *testing.T) {
val = []byte("doe") val = []byte("doe")
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
// random bucket name // random bucket name
testStore.cfg.Bucket = strconv.FormatInt(time.Now().UnixMicro(), 10) testStore.cfg.Bucket = strconv.FormatInt(time.Now().UnixMicro(), 10)
err = testStore.Set(key, val, 0) err := testStore.Set(key, val, 0)
require.Error(t, err) require.Error(t, err)
require.EqualError(t, err, "The specified bucket does not exist") require.EqualError(t, err, "The specified bucket does not exist")
} }
@@ -188,11 +176,10 @@ func Test_Delete(t *testing.T) {
val = []byte("doe") val = []byte("doe")
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
err = testStore.Set(key, val, 0) err := testStore.Set(key, val, 0)
require.NoError(t, err) require.NoError(t, err)
err = testStore.Delete(key) err = testStore.Delete(key)
@@ -205,11 +192,10 @@ func Test_Delete_Empty_Key(t *testing.T) {
val = []byte("doe") val = []byte("doe")
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
err = testStore.Set(key, val, 0) err := testStore.Set(key, val, 0)
require.Error(t, err) require.Error(t, err)
require.EqualError(t, err, "the key value is required") require.EqualError(t, err, "the key value is required")
} }
@@ -219,15 +205,13 @@ func Test_Delete_Not_Exists_Bucket(t *testing.T) {
key = "john" key = "john"
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
// random bucket name // random bucket name
testStore.cfg.Bucket = strconv.FormatInt(time.Now().UnixMicro(), 10) testStore.cfg.Bucket = strconv.FormatInt(time.Now().UnixMicro(), 10)
err = testStore.Delete(key) err := testStore.Delete(key)
require.Error(t, err) require.Error(t, err)
require.EqualError(t, err, "The specified bucket does not exist") require.EqualError(t, err, "The specified bucket does not exist")
} }
@@ -237,11 +221,10 @@ func Test_Reset(t *testing.T) {
val = []byte("doe") val = []byte("doe")
) )
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
defer testStore.Close() defer testStore.Close()
err = testStore.Set("john1", val, 0) err := testStore.Set("john1", val, 0)
require.NoError(t, err) require.NoError(t, err)
err = testStore.Set("john2", val, 0) err = testStore.Set("john2", val, 0)
@@ -256,20 +239,18 @@ func Test_Reset(t *testing.T) {
} }
func Test_Close(t *testing.T) { func Test_Close(t *testing.T) {
testStore, err := newTestStore(t) testStore := newTestStore(t)
require.NoError(t, err)
require.NoError(t, testStore.Close()) require.NoError(t, testStore.Close())
} }
func Benchmark_Minio_Set(b *testing.B) { func Benchmark_Minio_Set(b *testing.B) {
testStore := newTestStore(b)
defer testStore.Close()
b.ReportAllocs() b.ReportAllocs()
b.ResetTimer() b.ResetTimer()
testStore, err := newTestStore(b) var err error
require.NoError(b, err)
defer testStore.Close()
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
err = testStore.Set("john", []byte("doe"), 0) err = testStore.Set("john", []byte("doe"), 0)
} }
@@ -278,11 +259,10 @@ func Benchmark_Minio_Set(b *testing.B) {
} }
func Benchmark_Minio_Get(b *testing.B) { func Benchmark_Minio_Get(b *testing.B) {
testStore, err := newTestStore(b) testStore := newTestStore(b)
require.NoError(b, err)
defer testStore.Close() defer testStore.Close()
err = testStore.Set("john", []byte("doe"), 0) err := testStore.Set("john", []byte("doe"), 0)
require.NoError(b, err) require.NoError(b, err)
b.ReportAllocs() b.ReportAllocs()
@@ -296,13 +276,13 @@ func Benchmark_Minio_Get(b *testing.B) {
} }
func Benchmark_Minio_SetAndDelete(b *testing.B) { func Benchmark_Minio_SetAndDelete(b *testing.B) {
testStore, err := newTestStore(b) testStore := newTestStore(b)
require.NoError(b, err)
defer testStore.Close() defer testStore.Close()
b.ReportAllocs() b.ReportAllocs()
b.ResetTimer() b.ResetTimer()
var err error
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
_ = testStore.Set("john", []byte("doe"), 0) _ = testStore.Set("john", []byte("doe"), 0)
err = testStore.Delete("john") err = testStore.Delete("john")