Small things fixed

This commit is contained in:
Sadık Sünbül
2025-02-04 16:40:54 +03:00
parent a3bf4c9e20
commit 174e393340
5 changed files with 14 additions and 18 deletions

View File

@@ -11,7 +11,7 @@ title: LevelDB
A fast key-value DB using [syndtr/goleveldb](https://github.com/syndtr/goleveldb) A fast key-value DB using [syndtr/goleveldb](https://github.com/syndtr/goleveldb)
**Note: Requires Go 1.23.1 and above** **Note: Requires Go 1.21 or later**
### Table of Contents ### Table of Contents

View File

@@ -4,21 +4,21 @@ import (
"runtime" "runtime"
"testing" "testing"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/require"
) )
func TestConfigConfigMaxOpenFiles(t *testing.T) { func TestConfigConfigMaxOpenFiles(t *testing.T) {
cfg := Config{ cfg := Config{
MaxOpenFiles: 1000, MaxOpenFiles: 1000,
} }
assert.Equal(t, 1000, cfg.MaxOpenFiles) require.Equal(t, 1000, cfg.MaxOpenFiles)
} }
func TestConfigDefaultDarwin(t *testing.T) { // MacOS func TestConfigDefaultDarwin(t *testing.T) { // MacOS
cfg := configDefault() cfg := configDefault()
if runtime.GOOS == "darwin" { if runtime.GOOS == "darwin" {
assert.Equal(t, 200, cfg.MaxOpenFiles) require.Equal(t, 200, cfg.MaxOpenFiles)
} else { } else {
assert.Equal(t, 500, cfg.MaxOpenFiles) require.Equal(t, 500, cfg.MaxOpenFiles)
} }
} }

View File

@@ -1,6 +1,6 @@
module github.com/gofiber/storage/leveldb module github.com/gofiber/storage/leveldb
go 1.23.1 go 1.23
require ( require (
github.com/davecgh/go-spew v1.1.1 // indirect github.com/davecgh/go-spew v1.1.1 // indirect

View File

@@ -42,7 +42,6 @@ func New(config ...Config) *Storage {
// Get value by key // Get value by key
func (s *Storage) Get(key []byte) ([]byte, error) { func (s *Storage) Get(key []byte) ([]byte, error) {
if len(key) <= 0 { if len(key) <= 0 {
return nil, nil return nil, nil
} }

View File

@@ -1,7 +1,6 @@
package leveldb package leveldb
import ( import (
"fmt"
"os" "os"
"testing" "testing"
"time" "time"
@@ -226,16 +225,15 @@ func Benchmark_Set(b *testing.B) {
_ = removeAllFiles("./fiber.leveldb") _ = removeAllFiles("./fiber.leveldb")
}() }()
key := []byte("test_key")
value := []byte("test_value")
b.ResetTimer() b.ResetTimer()
b.RunParallel(func(pb *testing.PB) { b.RunParallel(func(pb *testing.PB) {
var i int
for pb.Next() { for pb.Next() {
key := []byte(fmt.Sprintf("key_%d", i))
value := []byte(fmt.Sprintf("value_%d", i))
if err := db.Set(key, value, 0); err != nil { if err := db.Set(key, value, 0); err != nil {
b.Fatal(err) b.Fatal(err)
} }
i++
} }
}) })
} }
@@ -270,18 +268,17 @@ func Benchmark_Delete(b *testing.B) {
_ = removeAllFiles("./fiber.leveldb") _ = removeAllFiles("./fiber.leveldb")
}() }()
key := "test_key"
if err := db.Set([]byte(key), []byte("test_value"), 0); err != nil {
b.Fatal(err)
}
b.ResetTimer() b.ResetTimer()
b.RunParallel(func(pb *testing.PB) { b.RunParallel(func(pb *testing.PB) {
var i int
for pb.Next() { for pb.Next() {
key := fmt.Sprintf("key_%d", i)
if err := db.Set([]byte(key), []byte("value"), 0); err != nil {
b.Fatal(err)
}
if err := db.Delete(key); err != nil { if err := db.Delete(key); err != nil {
b.Fatal(err) b.Fatal(err)
} }
i++
} }
}) })
} }