package/mpp
1
0
Fork 0
mirror of https://github.com/nyanmisaka/mpp.git synced 2025-11-03 01:33:35 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

[mpp]: Fix dead lock by redundant port lock

Browse Source 
The input / output port should NOT share the same lock. The old port lock
is not necessary for task interface.

Change-Id: I31e50ba539bca7389596093605c7641277ebc5a8
Signed-off-by: Herman Chen <herman.chen@rock-chips.com>
Signed-off-by: hh <hh@rock-chips.com>
This commit is contained in:
Herman Chen
2017-04-10 15:41:51 +08:00
parent d7b2f2f521
commit a92b1ea22a
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mpp/mpp.cpp
View File

@@ -442,7 +442,6 @@ MPP_RET Mpp::poll(MppPortType type, MppPollType timeout)
return MPP_NOK;
MPP_RET ret = MPP_NOK;
AutoMutex autoLock(mPortLock);
MppTaskQueue port = NULL;
switch (type) {
@@ -468,7 +467,6 @@ MPP_RET Mpp::dequeue(MppPortType type, MppTask *task)
return MPP_NOK;
MPP_RET ret = MPP_NOK;
AutoMutex autoLock(mPortLock);
MppTaskQueue port = NULL;
switch (type) {
@@ -494,7 +492,6 @@ MPP_RET Mpp::enqueue(MppPortType type, MppTask task)
return MPP_NOK;
MPP_RET ret = MPP_NOK;
AutoMutex autoLock(mPortLock);
MppTaskQueue port = NULL;
switch (type) {

1
mpp/mpp.h
View File

@@ -103,7 +103,6 @@ public:
/*
* Mpp task queue for advance task mode
*/
Mutex mPortLock;
MppPort mInputPort;
MppPort mOutputPort;