From 5d3623ac29e7bdab3050bd5991b9aa7da7eb1164 Mon Sep 17 00:00:00 2001
From: Grey Li <grey.li@rock-chips.com>
Date: Fri, 23 Dec 2022 16:43:35 +0800
Subject: [PATCH] [mpp_buffer]: fix group callback crash

thread1:
  1)control(MPP_DEC_SET_EXT_BUF_GROUP)
  2)mpp_buffer_group_set_callback
    p->callback = callback;
thread2:
  1)mpp_buffer_commit
  2)mpp_buffer_create
    group->callback(group->arg, group);
    But arg is NULL now.

backtrace:
  #00 (Mpp::notify(void*))
  #01 (mpp_buffer_create+712)
  #02 (mpp_buffer_import_with_tag+212)
  #03 (commit_memory_handle+116)

Signed-off-by: Grey Li <grey.li@rock-chips.com>
Change-Id: Id50e2f1b46d127c8bf0fe8080751949fcccc6e25
---
 mpp/base/mpp_buffer_impl.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mpp/base/mpp_buffer_impl.cpp b/mpp/base/mpp_buffer_impl.cpp
index ed3b695e..89e59e99 100644
--- a/mpp/base/mpp_buffer_impl.cpp
+++ b/mpp/base/mpp_buffer_impl.cpp
@@ -681,8 +681,8 @@ MPP_RET mpp_buffer_group_set_callback(MppBufferGroupImpl *p,
 
     MPP_BUF_FUNCTION_ENTER();
 
-    p->callback = callback;
     p->arg      = arg;
+    p->callback = callback;
 
     MPP_BUF_FUNCTION_LEAVE();
     return MPP_OK;