From 4af5fae61562b3a2ff07f61e73a800940c5bd231 Mon Sep 17 00:00:00 2001 From: Herman Chen Date: Mon, 27 Apr 2020 17:38:33 +0800 Subject: [PATCH] [hal_bufs]: Add more parameter check Change-Id: I0a1296e92b33fbae1f7c605cd85f933b2359f3c9 Signed-off-by: Herman Chen --- mpp/hal/common/hal_bufs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mpp/hal/common/hal_bufs.c b/mpp/hal/common/hal_bufs.c index 0e2119a8..9d9c3ac4 100644 --- a/mpp/hal/common/hal_bufs.c +++ b/mpp/hal/common/hal_bufs.c @@ -158,13 +158,13 @@ MPP_RET hal_bufs_setup(HalBufs bufs, RK_S32 max_cnt, RK_S32 size_cnt, size_t siz RK_S32 elem_size = 0; RK_S32 impl_size = 0; - if (NULL == bufs) { - mpp_err_f("invalid NULL input\n"); + if (NULL == bufs || NULL == sizes) { + mpp_err_f("invalid NULL input bufs %p sizes %p\n", bufs, sizes); return MPP_ERR_NULL_PTR; } - if (max_cnt < 0 || max_cnt > MAX_HAL_BUFS_CNT || - size_cnt < 0 || size_cnt > MAX_HAL_BUFS_SIZE_CNT) { + if (max_cnt <= 0 || max_cnt > MAX_HAL_BUFS_CNT || + size_cnt <= 0 || size_cnt > MAX_HAL_BUFS_SIZE_CNT) { mpp_err_f("invalid max cnt %d size cnt %d\n", max_cnt, size_cnt); return MPP_ERR_VALUE; }