From c247b31e204bcf33ac2d9e1492f3346908889702 Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Wed, 10 Sep 2025 10:15:20 +0200 Subject: [PATCH] =?UTF-8?q?lint:=E2=80=AFFix=20error=20appearing=20after?= =?UTF-8?q?=20the=20go=201.24=20go.mod=20change?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GOOS=windows /Applications/Xcode.app/Contents/Developer/usr/bin/make lint "/Users/teuf/dev/gvisor-tap-vsock/tools/bin"/golangci-lint run cmd/win-sshproxy/main.go:99:17: printf: non-constant format string in call to github.com/sirupsen/logrus.Errorf (govet) logrus.Errorf("Error saving thread id: " + err.Error()) ^ cmd/win-sshproxy/main.go:111:17: printf: non-constant format string in call to github.com/sirupsen/logrus.Errorf (govet) logrus.Errorf("Error occurred in execution group: " + err.Error()) Signed-off-by: Christophe Fergeau --- cmd/win-sshproxy/main.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/win-sshproxy/main.go b/cmd/win-sshproxy/main.go index 2b299c55..95e4a81d 100644 --- a/cmd/win-sshproxy/main.go +++ b/cmd/win-sshproxy/main.go @@ -96,7 +96,7 @@ func main() { // Save thread for legacy callers which use it to post a quit if _, err := saveThreadId(); err != nil { - logrus.Errorf("Error saving thread id: " + err.Error()) + logrus.Errorf("Error saving thread id: %v", err) } logrus.Debug("Setting up proxies") @@ -108,7 +108,7 @@ func main() { // Wait for completion (cancellation) or error if err := group.Wait(); err != nil { - logrus.Errorf("Error occurred in execution group: " + err.Error()) + logrus.Errorf("Error occurred in execution group: %v", err) return } }