support RTSP-over-HTTP (#433) (#768) (#887)

client_test.go

@@ -1,12 +1,18 @@
 package gortsplib
 
 import (
+	"bufio"
+	"bytes"
+	"crypto/tls"
 	"net"
+	"net/http"
+	"net/url"
 	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
 
+	"github.com/bluenviron/gortsplib/v4/internal/base64streamreader"
 	"github.com/bluenviron/gortsplib/v4/pkg/auth"
 	"github.com/bluenviron/gortsplib/v4/pkg/base"
 	"github.com/bluenviron/gortsplib/v4/pkg/conn"
@@ -103,7 +109,7 @@ func TestClientCloseDuringRequest(t *testing.T) {
 		nconn, err2 := l.Accept()
 		require.NoError(t, err2)
 		defer nconn.Close()
-		conn := conn.NewConn(nconn)
+		conn := conn.NewConn(bufio.NewReader(nconn), nconn)
 
 		req, err2 := conn.ReadRequest()
 		require.NoError(t, err2)
@@ -150,7 +156,7 @@ func TestClientSession(t *testing.T) {
 
 		nconn, err2 := l.Accept()
 		require.NoError(t, err2)
-		conn := conn.NewConn(nconn)
+		conn := conn.NewConn(bufio.NewReader(nconn), nconn)
 		defer nconn.Close()
 
 		req, err2 := conn.ReadRequest()
@@ -215,7 +221,7 @@ func TestClientAuth(t *testing.T) {
 
 		nconn, err2 := l.Accept()
 		require.NoError(t, err2)
-		conn := conn.NewConn(nconn)
+		conn := conn.NewConn(bufio.NewReader(nconn), nconn)
 		defer nconn.Close()
 
 		req, err2 := conn.ReadRequest()
@@ -301,7 +307,7 @@ func TestClientCSeq(t *testing.T) {
 				nconn, err2 := l.Accept()
 				require.NoError(t, err2)
 				defer nconn.Close()
-				conn := conn.NewConn(nconn)
+				conn := conn.NewConn(bufio.NewReader(nconn), nconn)
 
 				req, err2 := conn.ReadRequest()
 				require.NoError(t, err2)
@@ -377,7 +383,7 @@ func TestClientDescribeCharset(t *testing.T) {
 		nconn, err2 := l.Accept()
 		require.NoError(t, err2)
 		defer nconn.Close()
-		conn := conn.NewConn(nconn)
+		conn := conn.NewConn(bufio.NewReader(nconn), nconn)
 
 		req, err2 := conn.ReadRequest()
 		require.NoError(t, err2)
@@ -441,7 +447,7 @@ func TestClientReplyToServerRequest(t *testing.T) {
 
 				nconn, err2 := l.Accept()
 				require.NoError(t, err2)
-				conn := conn.NewConn(nconn)
+				conn := conn.NewConn(bufio.NewReader(nconn), nconn)
 				defer nconn.Close()
 
 				req, err2 := conn.ReadRequest()
@@ -535,7 +541,7 @@ func TestClientRelativeContentBase(t *testing.T) {
 		nconn, err2 := l.Accept()
 		require.NoError(t, err2)
 		defer nconn.Close()
-		conn := conn.NewConn(nconn)
+		conn := conn.NewConn(bufio.NewReader(nconn), nconn)
 
 		req, err2 := conn.ReadRequest()
 		require.NoError(t, err2)
@@ -586,3 +592,184 @@ func TestClientRelativeContentBase(t *testing.T) {
 
 	require.Equal(t, "rtsp://localhost:8554/relative-content-base", desc.BaseURL.String())
 }
+
+func TestClientHTTPTunnel(t *testing.T) {
+	for _, ca := range []string{"http", "https"} {
+		t.Run(ca, func(t *testing.T) {
+			var l net.Listener
+			var err error
+
+			if ca == "http" {
+				l, err = net.Listen("tcp", "localhost:8554")
+				require.NoError(t, err)
+				defer l.Close()
+			} else {
+				var cert tls.Certificate
+				cert, err = tls.X509KeyPair(serverCert, serverKey)
+				require.NoError(t, err)
+
+				l, err = tls.Listen("tcp", "localhost:8554", &tls.Config{Certificates: []tls.Certificate{cert}})
+				require.NoError(t, err)
+				defer l.Close()
+			}
+
+			var scheme string
+			if ca == "http" {
+				scheme = "rtsp"
+			} else {
+				scheme = "rtsps"
+			}
+
+			serverDone := make(chan struct{})
+			defer func() { <-serverDone }()
+
+			go func() {
+				defer close(serverDone)
+
+				nconn1, err2 := l.Accept()
+				require.NoError(t, err2)
+				defer nconn1.Close()
+
+				buf1 := bufio.NewReader(nconn1)
+				req1, err2 := http.ReadRequest(buf1)
+				require.NoError(t, err2)
+
+				require.Equal(t, &http.Request{
+					Method:     http.MethodGet,
+					Proto:      "HTTP/1.1",
+					ProtoMajor: 1,
+					ProtoMinor: 1,
+					URL: &url.URL{
+						Path: "/",
+					},
+					Host:       "localhost:8554",
+					RequestURI: "/",
+					Header: http.Header{
+						"Accept":          []string{"application/x-rtsp-tunnelled"},
+						"Content-Length":  []string{"30000"},
+						"X-Sessioncookie": req1.Header["X-Sessioncookie"],
+					},
+					ContentLength: 30000,
+					Body:          req1.Body,
+				}, req1)
+
+				require.NotEmpty(t, req1.Header.Get("X-Sessioncookie"))
+
+				h := http.Header{}
+				h.Set("Cache-Control", "no-cache")
+				h.Set("Connection", "close")
+				h.Set("Content-Type", "application/x-rtsp-tunnelled")
+				h.Set("Pragma", "no-cache")
+				res := http.Response{
+					StatusCode:    http.StatusOK,
+					ProtoMajor:    1,
+					ProtoMinor:    req1.ProtoMinor,
+					Header:        h,
+					ContentLength: -1,
+				}
+				var resBuf bytes.Buffer
+				res.Write(&resBuf) //nolint:errcheck
+				_, err = nconn1.Write(resBuf.Bytes())
+				require.NoError(t, err)
+
+				nconn2, err2 := l.Accept()
+				require.NoError(t, err2)
+				defer nconn2.Close()
+
+				buf2 := bufio.NewReader(nconn2)
+				req2, err2 := http.ReadRequest(buf2)
+				require.NoError(t, err2)
+
+				require.Equal(t, &http.Request{
+					Method:     http.MethodPost,
+					Proto:      "HTTP/1.1",
+					ProtoMajor: 1,
+					ProtoMinor: 1,
+					URL: &url.URL{
+						Path: "/",
+					},
+					Host:       "localhost:8554",
+					RequestURI: "/",
+					Header: http.Header{
+						"Content-Type":    []string{"application/x-rtsp-tunnelled"},
+						"Content-Length":  []string{"30000"},
+						"X-Sessioncookie": req2.Header["X-Sessioncookie"],
+					},
+					ContentLength: 30000,
+					Body:          req2.Body,
+				}, req2)
+
+				require.Equal(t, req1.Header.Get("X-Sessioncookie"), req2.Header.Get("X-Sessioncookie"))
+
+				h = http.Header{}
+				h.Set("Cache-Control", "no-cache")
+				h.Set("Connection", "close")
+				h.Set("Content-Type", "application/x-rtsp-tunnelled")
+				h.Set("Pragma", "no-cache")
+				res = http.Response{
+					StatusCode:    http.StatusOK,
+					ProtoMajor:    1,
+					ProtoMinor:    req1.ProtoMinor,
+					Header:        h,
+					ContentLength: -1,
+				}
+				resBuf = bytes.Buffer{}
+				res.Write(&resBuf) //nolint:errcheck
+				_, err = nconn2.Write(resBuf.Bytes())
+				require.NoError(t, err)
+
+				conn := conn.NewConn(bufio.NewReader(base64streamreader.New(buf2)), nconn1)
+
+				req, err2 := conn.ReadRequest()
+				require.NoError(t, err2)
+				require.Equal(t, base.Options, req.Method)
+
+				err2 = conn.WriteResponse(&base.Response{
+					StatusCode: base.StatusOK,
+					Header: base.Header{
+						"Public": base.HeaderValue{strings.Join([]string{
+							string(base.Describe),
+						}, ", ")},
+					},
+				})
+				require.NoError(t, err2)
+
+				req, err2 = conn.ReadRequest()
+				require.NoError(t, err2)
+				require.Equal(t, base.Describe, req.Method)
+				require.Equal(t, mustParseURL(scheme+"://localhost:8554/teststream"), req.URL)
+
+				medias := []*description.Media{testH264Media}
+
+				err2 = conn.WriteResponse(&base.Response{
+					StatusCode: base.StatusOK,
+					Header: base.Header{
+						"Content-Type": base.HeaderValue{"application/sdp; charset=utf-8"},
+						"Content-Base": base.HeaderValue{"/relative-content-base"},
+					},
+					Body: mediasToSDP(medias),
+				})
+				require.NoError(t, err2)
+			}()
+
+			u, err := base.ParseURL(scheme + "://localhost:8554/teststream")
+			require.NoError(t, err)
+
+			c := Client{
+				Scheme: u.Scheme,
+				Host:   u.Host,
+				Tunnel: TunnelHTTP,
+				TLSConfig: &tls.Config{
+					InsecureSkipVerify: true,
+				},
+			}
+
+			err = c.Start2()
+			require.NoError(t, err)
+			defer c.Close()
+
+			_, _, err = c.Describe(u)
+			require.NoError(t, err)
+		})
+	}
+}