package/gortsplib
1
0
Fork 0
mirror of https://github.com/aler9/gortsplib synced 2025-10-05 15:16:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

improve coverage

Browse Source
This commit is contained in:
aler9
2021-08-05 18:17:59 +02:00
parent 2914af3fda
commit d8bf9b2307
11 changed files with 168 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/headers/authenticate_test.go
View File

@@ -183,15 +183,6 @@ func TestAuthenticateRead(t *testing.T) {
}
}
func TestAuthenticateWrite(t *testing.T) {
for _, ca := range casesAuthenticate {
t.Run(ca.name, func(t *testing.T) {
vout := ca.h.Write()
require.Equal(t, ca.vout, vout)
})
}
}
func TestAutenticatehReadErrors(t *testing.T) {
for _, ca := range []struct {
name string
@@ -231,3 +222,12 @@ func TestAutenticatehReadErrors(t *testing.T) {
})
}
}
func TestAuthenticateWrite(t *testing.T) {
for _, ca := range casesAuthenticate {
t.Run(ca.name, func(t *testing.T) {
vout := ca.h.Write()
require.Equal(t, ca.vout, vout)
})
}
}

18
pkg/headers/authorization_test.go
View File

@@ -60,15 +60,6 @@ func TestAuthorizationRead(t *testing.T) {
}
}
func TestAuthorizationWrite(t *testing.T) {
for _, ca := range casesAuthorization {
t.Run(ca.name, func(t *testing.T) {
vout := ca.h.Write()
require.Equal(t, ca.vout, vout)
})
}
}
func TestAuthorizationReadErrors(t *testing.T) {
for _, ca := range []struct {
name string
@@ -113,3 +104,12 @@ func TestAuthorizationReadErrors(t *testing.T) {
})
}
}
func TestAuthorizationWrite(t *testing.T) {
for _, ca := range casesAuthorization {
t.Run(ca.name, func(t *testing.T) {
vout := ca.h.Write()
require.Equal(t, ca.vout, vout)
})
}
}

18
pkg/headers/range_test.go
View File

@@ -132,15 +132,6 @@ func TestRangeRead(t *testing.T) {
}
}
func TestRangeWrite(t *testing.T) {
for _, ca := range casesRange {
t.Run(ca.name, func(t *testing.T) {
req := ca.h.Write()
require.Equal(t, ca.vout, req)
})
}
}
func TestRangeReadErrors(t *testing.T) {
for _, ca := range []struct {
name string
@@ -270,3 +261,12 @@ func TestRangeReadErrors(t *testing.T) {
})
}
}
func TestRangeWrite(t *testing.T) {
for _, ca := range casesRange {
t.Run(ca.name, func(t *testing.T) {
req := ca.h.Write()
require.Equal(t, ca.vout, req)
})
}
}

18
pkg/headers/rtpinfo_test.go
View File

@@ -178,15 +178,6 @@ func TestRTPInfoRead(t *testing.T) {
}
}
func TestRTPInfoWrite(t *testing.T) {
for _, ca := range casesRTPInfo {
t.Run(ca.name, func(t *testing.T) {
req := ca.h.Write()
require.Equal(t, ca.vout, req)
})
}
}
func TestRTPInfoReadErrors(t *testing.T) {
for _, ca := range []struct {
name string
@@ -231,3 +222,12 @@ func TestRTPInfoReadErrors(t *testing.T) {
})
}
}
func TestRTPInfoWrite(t *testing.T) {
for _, ca := range casesRTPInfo {
t.Run(ca.name, func(t *testing.T) {
req := ca.h.Write()
require.Equal(t, ca.vout, req)
})
}
}

18
pkg/headers/session_test.go
View File

@@ -59,15 +59,6 @@ func TestSessionRead(t *testing.T) {
}
}
func TestSessionWrite(t *testing.T) {
for _, ca := range casesSession {
t.Run(ca.name, func(t *testing.T) {
req := ca.h.Write()
require.Equal(t, ca.vout, req)
})
}
}
func TestSessionReadErrors(t *testing.T) {
for _, ca := range []struct {
name string
@@ -102,3 +93,12 @@ func TestSessionReadErrors(t *testing.T) {
})
}
}
func TestSessionWrite(t *testing.T) {
for _, ca := range casesSession {
t.Run(ca.name, func(t *testing.T) {
req := ca.h.Write()
require.Equal(t, ca.vout, req)
})
}
}

18
pkg/headers/transport_test.go
View File

@@ -168,15 +168,6 @@ func TestTransportRead(t *testing.T) {
}
}
func TestTransportWrite(t *testing.T) {
for _, ca := range casesTransport {
t.Run(ca.name, func(t *testing.T) {
req := ca.h.Write()
require.Equal(t, ca.vout, req)
})
}
}
func TestTransportReadErrors(t *testing.T) {
for _, ca := range []struct {
name string
@@ -271,3 +262,12 @@ func TestTransportReadErrors(t *testing.T) {
})
}
}
func TestTransportWrite(t *testing.T) {
for _, ca := range casesTransport {
t.Run(ca.name, func(t *testing.T) {
req := ca.h.Write()
require.Equal(t, ca.vout, req)
})
}
}

18
pkg/rtpaac/encoder.go
View File

@@ -131,7 +131,7 @@ func (e *Encoder) writeFragmented(au []byte, pts time.Duration) ([][]byte, error
copy(data[4:], au[:le])
au = au[le:]
rpkt := rtp.Packet{
frame, err := (&rtp.Packet{
Header: rtp.Header{
Version: rtpVersion,
PayloadType: e.payloadType,
@@ -141,14 +141,13 @@ func (e *Encoder) writeFragmented(au []byte, pts time.Duration) ([][]byte, error
Marker: (i == (packetCount - 1)),
},
Payload: data,
}
e.sequenceNumber++
frame, err := rpkt.Marshal()
}).Marshal()
if err != nil {
return nil, err
}
e.sequenceNumber++
ret[i] = frame
}
@@ -190,7 +189,7 @@ func (e *Encoder) writeAggregated(aus [][]byte, firstPTS time.Duration) ([][]byt
pos += auLen
}
rpkt := rtp.Packet{
frame, err := (&rtp.Packet{
Header: rtp.Header{
Version: rtpVersion,
PayloadType: e.payloadType,
@@ -200,13 +199,12 @@ func (e *Encoder) writeAggregated(aus [][]byte, firstPTS time.Duration) ([][]byt
Marker: true,
},
Payload: payload,
}
e.sequenceNumber++
frame, err := rpkt.Marshal()
}).Marshal()
if err != nil {
return nil, err
}
e.sequenceNumber++
return [][]byte{frame}, nil
}

32
pkg/rtpaac/rtpaac_test.go
View File

@@ -213,20 +213,6 @@ var cases = []struct {
},
}
func TestEncode(t *testing.T) {
for _, ca := range cases {
t.Run(ca.name, func(t *testing.T) {
sequenceNumber := uint16(0x44ed)
ssrc := uint32(0x9dbb7812)
initialTs := uint32(0x88776655)
e := NewEncoder(96, 48000, &sequenceNumber, &ssrc, &initialTs)
enc, err := e.Encode(ca.aus, ca.pts)
require.NoError(t, err)
require.Equal(t, ca.enc, enc)
})
}
}
func TestDecode(t *testing.T) {
for _, ca := range cases {
t.Run(ca.name, func(t *testing.T) {
@@ -424,3 +410,21 @@ func TestDecodeErrors(t *testing.T) {
})
}
}
func TestEncode(t *testing.T) {
for _, ca := range cases {
t.Run(ca.name, func(t *testing.T) {
sequenceNumber := uint16(0x44ed)
ssrc := uint32(0x9dbb7812)
initialTs := uint32(0x88776655)
e := NewEncoder(96, 48000, &sequenceNumber, &ssrc, &initialTs)
enc, err := e.Encode(ca.aus, ca.pts)
require.NoError(t, err)
require.Equal(t, ca.enc, enc)
})
}
}
func TestEncodeRandomInitialState(t *testing.T) {
NewEncoder(96, 48000, nil, nil, nil)
}

27
pkg/rtph264/encoder.go
View File

@@ -106,7 +106,7 @@ func (e *Encoder) writeBatch(nalus [][]byte, pts time.Duration, marker bool) ([]
}
func (e *Encoder) writeSingle(nalu []byte, pts time.Duration, marker bool) ([][]byte, error) {
rpkt := rtp.Packet{
frame, err := (&rtp.Packet{
Header: rtp.Header{
Version: rtpVersion,
PayloadType: e.payloadType,
@@ -116,14 +116,13 @@ func (e *Encoder) writeSingle(nalu []byte, pts time.Duration, marker bool) ([][]
Marker: marker,
},
Payload: nalu,
}
e.sequenceNumber++
frame, err := rpkt.Marshal()
}).Marshal()
if err != nil {
return nil, err
}
e.sequenceNumber++
return [][]byte{frame}, nil
}
@@ -164,7 +163,7 @@ func (e *Encoder) writeFragmented(nalu []byte, pts time.Duration, marker bool) (
copy(data[2:], nalu[:le])
nalu = nalu[le:]
rpkt := rtp.Packet{
frame, err := (&rtp.Packet{
Header: rtp.Header{
Version: rtpVersion,
PayloadType: e.payloadType,
@@ -174,14 +173,13 @@ func (e *Encoder) writeFragmented(nalu []byte, pts time.Duration, marker bool) (
Marker: (i == (packetCount-1) && marker),
},
Payload: data,
}
e.sequenceNumber++
frame, err := rpkt.Marshal()
}).Marshal()
if err != nil {
return nil, err
}
e.sequenceNumber++
ret[i] = frame
}
@@ -222,7 +220,7 @@ func (e *Encoder) writeAggregated(nalus [][]byte, pts time.Duration, marker bool
pos += naluLen
}
rpkt := rtp.Packet{
frame, err := (&rtp.Packet{
Header: rtp.Header{
Version: rtpVersion,
PayloadType: e.payloadType,
@@ -232,13 +230,12 @@ func (e *Encoder) writeAggregated(nalus [][]byte, pts time.Duration, marker bool
Marker: marker,
},
Payload: payload,
}
e.sequenceNumber++
frame, err := rpkt.Marshal()
}).Marshal()
if err != nil {
return nil, err
}
e.sequenceNumber++
return [][]byte{frame}, nil
}

12
pkg/rtph264/nalutype_test.go Normal file
View File

@@ -0,0 +1,12 @@
package rtph264
import (
"testing"
"github.com/stretchr/testify/require"
)
func TestNALUType(t *testing.T) {
require.NotEqual(t, "unknown", naluType(10).String())
require.Equal(t, "unknown", naluType(50).String())
}

89
pkg/rtph264/rtph264_test.go
View File

@@ -2,6 +2,7 @@ package rtph264
import (
"bytes"
"io"
"testing"
"time"
@@ -219,20 +220,6 @@ var cases = []struct {
},
}
func TestEncode(t *testing.T) {
for _, ca := range cases {
t.Run(ca.name, func(t *testing.T) {
sequenceNumber := uint16(0x44ed)
ssrc := uint32(0x9dbb7812)
initialTs := uint32(0x88776655)
e := NewEncoder(96, &sequenceNumber, &ssrc, &initialTs)
enc, err := e.Encode(ca.nalus, ca.pts)
require.NoError(t, err)
require.Equal(t, ca.enc, enc)
})
}
}
func TestDecode(t *testing.T) {
for _, ca := range cases {
t.Run(ca.name, func(t *testing.T) {
@@ -458,10 +445,36 @@ func TestDecodeErrors(t *testing.T) {
}
}
type funcReader func(p []byte) (int, error)
func TestEncode(t *testing.T) {
for _, ca := range cases {
t.Run(ca.name, func(t *testing.T) {
sequenceNumber := uint16(0x44ed)
ssrc := uint32(0x9dbb7812)
initialTs := uint32(0x88776655)
e := NewEncoder(96, &sequenceNumber, &ssrc, &initialTs)
enc, err := e.Encode(ca.nalus, ca.pts)
require.NoError(t, err)
require.Equal(t, ca.enc, enc)
})
}
}
func (f funcReader) Read(p []byte) (int, error) {
return f(p)
func TestEncodeRandomInitialState(t *testing.T) {
NewEncoder(96, nil, nil, nil)
}
type dummyReader struct {
byts [][]byte
i int
}
func (f *dummyReader) Read(p []byte) (int, error) {
if f.i >= len(f.byts) {
return 0, io.EOF
}
n := copy(p, f.byts[f.i])
f.i++
return n, nil
}
func TestReadSPSPPS(t *testing.T) {
@@ -491,17 +504,43 @@ func TestReadSPSPPS(t *testing.T) {
},
} {
t.Run(ca.name, func(t *testing.T) {
i := 0
f := funcReader(func(p []byte) (int, error) {
n := copy(p, ca.byts[i])
i++
return n, nil
})
sps, pps, err := NewDecoder().ReadSPSPPS(f)
sps, pps, err := NewDecoder().ReadSPSPPS(&dummyReader{byts: ca.byts})
require.NoError(t, err)
require.Equal(t, ca.sps, sps)
require.Equal(t, ca.pps, pps)
})
}
}
func TestReadSPSPPSErrors(t *testing.T) {
for _, ca := range []struct {
name string
byts [][]byte
err string
}{
{
"empty",
[][]byte{},
"EOF",
},
{
"more packets needed, then empty",
[][]byte{
mergeBytes(
[]byte{
0x80, 0x60, 0x44, 0xed, 0x88, 0x77, 0x79, 0xab,
0x9d, 0xbb, 0x78, 0x12, 0x1c, 0x85,
},
bytes.Repeat([]byte{0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07}, 182),
[]byte{0x00, 0x01},
),
},
"EOF",
},
} {
t.Run(ca.name, func(t *testing.T) {
_, _, err := NewDecoder().ReadSPSPPS(&dummyReader{byts: ca.byts})
require.Equal(t, ca.err, err.Error())
})
}
}