rewrite fuzz tests of decoders in order to get deterministic results (#261)

pkg/formats/rtph264/decoder_test.go

@@ -184,10 +184,22 @@ func TestDecodeUntilMarker(t *testing.T) {
 }
 
 func FuzzDecoder(f *testing.F) {
-	d := &Decoder{}
+	f.Fuzz(func(t *testing.T, a []byte, b []byte) {
-	d.Init()
+		d := &Decoder{}
+		d.Init()
+
+		d.Decode(&rtp.Packet{
+			Header: rtp.Header{
+				Version:        2,
+				Marker:         false,
+				PayloadType:    96,
+				SequenceNumber: 17645,
+				Timestamp:      2289527317,
+				SSRC:           0x9dbb7812,
+			},
+			Payload: a,
+		})
 
-	f.Fuzz(func(t *testing.T, b []byte) {
 		d.Decode(&rtp.Packet{
 			Header: rtp.Header{
 				Version:        2,

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/11dca3ad0def7057

@@ -1,2 +1,3 @@
 go test fuzz v1
 []byte("800")
+[]byte("0")

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/17ec193e17dd91d1b2a621884383564489d9f873db1b015a693c79fb7c1c1a46

@@ -1,2 +0,0 @@
-go test fuzz v1
-[]byte("\x1c\xd4")

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/60892a24d67609fc

@@ -1,2 +1,3 @@
 go test fuzz v1
 []byte("8")
+[]byte("")

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/84ed65595ad05a58

@@ -1,3 +1,3 @@
 go test fuzz v1
 []byte("0")
-bool(false)
+[]byte("")

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/9b4d0ab6bd98d3a9

@@ -1,2 +1,3 @@
 go test fuzz v1
+[]byte("0")
 []byte("80")

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/c30437d5edf1393c2957896ca6c4e4d0467a50451fd1feb1cae249fdcbf25a5a

@@ -1,2 +0,0 @@
-go test fuzz v1
-[]byte("\x1c")

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/ecf7d0b7f06fcc4a

@@ -1,3 +1,3 @@
 go test fuzz v1
 []byte("0")
-bool(false)
+[]byte("<")

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/edbcdbb8d9f1bdac

@@ -0,0 +1,3 @@
+go test fuzz v1
+[]byte("0")
+[]byte("\\0")

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/ef62dc47a38f1a39

@@ -1,2 +1,3 @@
 go test fuzz v1
+[]byte("0")
 []byte("9")

pkg/formats/rtph264/testdata/fuzz/FuzzDecoder/fe107a097efccd5098d6b0147ef4b39f0e467f0257dbf8f8b2f256c235640a6e

@@ -1,2 +0,0 @@
-go test fuzz v1
-[]byte("\x1c0")

pkg/formats/rtph265/decoder_test.go

@@ -36,10 +36,22 @@ func TestDecode(t *testing.T) {
 }
 
 func FuzzDecoder(f *testing.F) {
-	d := &Decoder{}
+	f.Fuzz(func(t *testing.T, a []byte, b []byte) {
-	d.Init()
+		d := &Decoder{}
+		d.Init()
+
+		d.Decode(&rtp.Packet{
+			Header: rtp.Header{
+				Version:        2,
+				Marker:         false,
+				PayloadType:    96,
+				SequenceNumber: 17645,
+				Timestamp:      2289527317,
+				SSRC:           0x9dbb7812,
+			},
+			Payload: a,
+		})
 
-	f.Fuzz(func(t *testing.T, b []byte) {
 		d.Decode(&rtp.Packet{
 			Header: rtp.Header{
 				Version:        2,

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/25f2b139d5d03b01

@@ -1,3 +1,3 @@
 go test fuzz v1
 []byte("00")
-bool(false)
+[]byte("b00")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/2d69a60004f3edfd

@@ -1,2 +1,3 @@
 go test fuzz v1
+[]byte("0")
 []byte("b0")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/5cedd25e23c9f9aa

@@ -1,2 +1,3 @@
 go test fuzz v1
+[]byte("0")
 []byte("a00")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/717a02ebf21c41db

@@ -0,0 +1,3 @@
+go test fuzz v1
+[]byte("0")
+[]byte("\xe50")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/84ed65595ad05a58

@@ -1,2 +1,3 @@
 go test fuzz v1
+[]byte("0")
 []byte("")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/95aa14d7ab02ec8b5c470dcc780587540caba1589c6a7ce702ff84edca9b3133

@@ -1,2 +0,0 @@
-go test fuzz v1
-[]byte("d0")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/95e634df087d6476

@@ -1,2 +1,3 @@
 go test fuzz v1
 []byte("a0")
+[]byte("")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/a7fab38f1f1629f8

@@ -0,0 +1,3 @@
+go test fuzz v1
+[]byte("b0\xd2")
+[]byte("0")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/cb84a08ac93f5772ee3ba0f0bcfde81c9cd71a403c69f893cebc8378c60af625

@@ -1,2 +0,0 @@
-go test fuzz v1
-[]byte("bbbbbbbbbbbbb0")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/e45ead12fae619dd0807aaf83341d58eca4d50fab6eefbe78953581a1a4df198

@@ -1,2 +0,0 @@
-go test fuzz v1
-[]byte("b0\xcd")

pkg/formats/rtph265/testdata/fuzz/FuzzDecoder/e807a721f4e89fcb

@@ -1,2 +1,3 @@
 go test fuzz v1
 []byte("a000")
+[]byte("0")

pkg/formats/rtplpcm/decoder_test.go

@@ -31,14 +31,14 @@ func TestDecode(t *testing.T) {
 }
 
 func FuzzDecoder(f *testing.F) {
-	d := &Decoder{
-		BitDepth:     24,
-		SampleRate:   48000,
-		ChannelCount: 2,
-	}
-	d.Init()
-
 	f.Fuzz(func(t *testing.T, b []byte) {
+		d := &Decoder{
+			BitDepth:     24,
+			SampleRate:   48000,
+			ChannelCount: 2,
+		}
+		d.Init()
+
 		d.Decode(&rtp.Packet{
 			Header: rtp.Header{
 				Version:        2,

pkg/formats/rtpmjpeg/decoder_test.go

@@ -28,14 +28,26 @@ func TestDecode(t *testing.T) {
 }
 
 func FuzzDecoder(f *testing.F) {
-	d := &Decoder{}
+	f.Fuzz(func(t *testing.T, a []byte, am bool, b []byte, bm bool) {
-	d.Init()
+		d := &Decoder{}
+		d.Init()
 
-	f.Fuzz(func(t *testing.T, b []byte, m bool) {
 		d.Decode(&rtp.Packet{
 			Header: rtp.Header{
 				Version:        2,
-				Marker:         m,
+				Marker:         am,
+				PayloadType:    96,
+				SequenceNumber: 17645,
+				Timestamp:      2289527317,
+				SSRC:           0x9dbb7812,
+			},
+			Payload: a,
+		})
+
+		d.Decode(&rtp.Packet{
+			Header: rtp.Header{
+				Version:        2,
+				Marker:         bm,
 				PayloadType:    96,
 				SequenceNumber: 17645,
 				Timestamp:      2289527317,

pkg/formats/rtpmjpeg/testdata/fuzz/FuzzDecoder/5c3e3cea6fcbf660

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("0\x00\x00\x00\x01\xff000\x00\x00@000000000000000000000000000000000000000000000000000000000000000000")
+bool(true)
+[]byte("0000\x01\xff000000000000000000000000000000000000000000000000000000000000000000000000")
+bool(true)

pkg/formats/rtpmjpeg/testdata/fuzz/FuzzDecoder/76a6865e7bb36d841a943abed143b3403b2d0ffaecdf3298988189c118ee10c1

@@ -1,3 +0,0 @@
-go test fuzz v1
-[]byte("0\x00\x00\x00\x01\xff000\x00\x00@0000000000000000000000000000000000000000000000000000000000000000")
-bool(true)

pkg/formats/rtpmjpeg/testdata/fuzz/FuzzDecoder/8b8df3a54310aad8

@@ -1,3 +1,5 @@
 go test fuzz v1
+[]byte("0")
+bool(false)
 []byte("0\x00\x00\x00\x01\xff00")
 bool(false)

pkg/formats/rtpmjpeg/testdata/fuzz/FuzzDecoder/acf99ee7fd60497d

@@ -1,5 +1,5 @@
 go test fuzz v1
 []byte("")
-bool(false)
-[]byte("")
 bool(true)
+[]byte("")
+bool(false)

pkg/formats/rtpmjpeg/testdata/fuzz/FuzzDecoder/bbed53e53be4cad7bab7f568e12dda0590d7c11c0f890b3816ab6eff536ac9fc

@@ -1,3 +0,0 @@
-go test fuzz v1
-[]byte("0000\x01\xff00000000000000000000000000000000000000000000000000000000000000000000000")
-bool(true)

pkg/formats/rtpmjpeg/testdata/fuzz/FuzzDecoder/be012bfe6e99e126df96e194dc125f8c57860dd62c4244dd7b4e7512cb22a205

@@ -1,3 +0,0 @@
-go test fuzz v1
-[]byte("0000\x01\xff00")
-bool(false)

pkg/formats/rtpmjpeg/testdata/fuzz/FuzzDecoder/c582eb998d5b265e

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("0\x00\x00\x00\x01\xff000\x00\x00\x8000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000")
+bool(false)
+[]byte("0000\x01\xff00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000")
+bool(false)

pkg/formats/rtpmjpeg/testdata/fuzz/FuzzDecoder/f1b261959da64dfa

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("0")
+bool(true)
+[]byte("0\x00\x00\x00\x01\xff000\x00\x00\x8000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000")
+bool(true)

pkg/formats/rtpmjpeg/testdata/fuzz/FuzzDecoder/fe09b7699690e38a634478835482b418adf4885a063409efe36d0d6120af5eb9

@@ -1,3 +0,0 @@
-go test fuzz v1
-[]byte("0000\x01\xff00000000000000000000000000000000000000000000000000000000000000000000000")
-bool(false)

pkg/formats/rtpmpeg2audio/decoder_test.go

@@ -27,10 +27,10 @@ func TestDecode(t *testing.T) {
 }
 
 func FuzzDecoder(f *testing.F) {
-	d := &Decoder{}
-	d.Init()
-
 	f.Fuzz(func(t *testing.T, a []byte, b []byte) {
+		d := &Decoder{}
+		d.Init()
+
 		d.Decode(&rtp.Packet{
 			Header: rtp.Header{
 				Version:        2,

pkg/formats/rtpmpeg2audio/testdata/fuzz/FuzzDecoder/07e32c6158459c72

@@ -1,3 +1,3 @@
 go test fuzz v1
-[]byte("\x00\x00\x00\x000")
 []byte("0")
+[]byte("\x00\x00\x00\x000")

pkg/formats/rtpmpeg2audio/testdata/fuzz/FuzzDecoder/364d148c8b01f9af

@@ -0,0 +1,3 @@
+go test fuzz v1
+[]byte("\x00\x00\x00\x00\xff\xfd000")
+[]byte("\x00\x00000")

pkg/formats/rtpmpeg2audio/testdata/fuzz/FuzzDecoder/5ca224fc27648f98

@@ -1,3 +0,0 @@
-go test fuzz v1
-[]byte("\x00\x00\x00\x05\xff\xff\x05000000000000000000000000000000000000000\xcf\x1c\xe9b\x01NUI00000000000000000000000000000000000000000000000000000000")
-[]byte("\x00\x00\x00\x05\xff\xff\x0500")

pkg/formats/rtpmpeg2audio/testdata/fuzz/FuzzDecoder/6acba488537bfc0a

@@ -1,3 +1,3 @@
 go test fuzz v1
 []byte("0")
-[]byte("\x00\x00\x00\x00\xff\xfa\x160000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000\xff\xfa000")
+[]byte("\x00\x00\x00\x00\xff\xfb\x15000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000\xff\xfb000")

pkg/formats/rtpmpeg2audio/testdata/fuzz/FuzzDecoder/84ed65595ad05a58

@@ -1,2 +1,3 @@
 go test fuzz v1
+[]byte("0")
 []byte("")

pkg/formats/rtpmpeg2audio/testdata/fuzz/FuzzDecoder/910722de931d45a0

@@ -1,3 +1,3 @@
 go test fuzz v1
-[]byte("")
+[]byte("0")
 []byte("00000")

pkg/formats/rtpmpeg4audio/decoder_test.go

@@ -70,15 +70,15 @@ func TestDecodeADTS(t *testing.T) {
 }
 
 func FuzzDecoder(f *testing.F) {
-	d := &Decoder{
-		SampleRate:       16000,
-		SizeLength:       13,
-		IndexLength:      3,
-		IndexDeltaLength: 3,
-	}
-	d.Init()
-
 	f.Fuzz(func(t *testing.T, a []byte, am bool, b []byte, bm bool) {
+		d := &Decoder{
+			SampleRate:       16000,
+			SizeLength:       13,
+			IndexLength:      3,
+			IndexDeltaLength: 3,
+		}
+		d.Init()
+
 		d.Decode(&rtp.Packet{
 			Header: rtp.Header{
 				Version:        2,

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/0133a2a9bd638ceb

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("0")
+bool(true)
+[]byte("\x00\x1000")
+bool(true)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/079a435e5445c35b

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("")
+bool(false)
+[]byte("")
+bool(false)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/571808e383aba6a5

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("\x00\x01\x00\x00")
+bool(false)
+[]byte("\x00\x0100")
+bool(false)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/592eac8c14ce0985

@@ -1,5 +0,0 @@
-go test fuzz v1
-[]byte("\x000\x00\x00\xd8\xd8\xd8\xc8\xd8\xd801")
-bool(true)
-[]byte("\x00\x01\x00\x00")
-bool(true)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/6b33266efc1ae023

@@ -1,5 +0,0 @@
-go test fuzz v1
-[]byte("\x00000000000")
-bool(false)
-[]byte("")
-bool(true)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/8f3e197fb87140b2

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("\x00\x01\x00\x00")
+bool(false)
+[]byte("\x00 0000")
+bool(true)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/9418bac23c1c4f72

@@ -2,4 +2,4 @@ go test fuzz v1
 []byte("00")
 bool(false)
 []byte("")
-bool(true)
+bool(false)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/97f31764971cea9c

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("\x00 0000")
+bool(false)
+[]byte("0")
+bool(true)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/a68704dd42c38106

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("0")
+bool(false)
+[]byte("\x00\x0100")
+bool(false)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/c00c7308cebe5e4a

@@ -1,5 +0,0 @@
-go test fuzz v1
-[]byte("\x00\x10\x00\x00")
-bool(false)
-[]byte("\x00\x1000")
-bool(false)

pkg/formats/rtpmpeg4audio/testdata/fuzz/FuzzDecoder/c7480ec341b553d6

@@ -1,5 +1,5 @@
 go test fuzz v1
-[]byte("\x00\x00")
-bool(false)
 []byte("")
+bool(false)
+[]byte("\x00\x00")
 bool(true)

pkg/formats/rtpvp8/decoder_test.go

@@ -27,14 +27,26 @@ func TestDecode(t *testing.T) {
 }
 
 func FuzzDecoder(f *testing.F) {
-	d := &Decoder{}
+	f.Fuzz(func(t *testing.T, a []byte, am bool, b []byte, bm bool) {
-	d.Init()
+		d := &Decoder{}
+		d.Init()
 
-	f.Fuzz(func(t *testing.T, b []byte, m bool) {
 		d.Decode(&rtp.Packet{
 			Header: rtp.Header{
 				Version:        2,
-				Marker:         m,
+				Marker:         am,
+				PayloadType:    96,
+				SequenceNumber: 17645,
+				Timestamp:      2289527317,
+				SSRC:           0x9dbb7812,
+			},
+			Payload: a,
+		})
+
+		d.Decode(&rtp.Packet{
+			Header: rtp.Header{
+				Version:        2,
+				Marker:         bm,
 				PayloadType:    96,
 				SequenceNumber: 17645,
 				Timestamp:      2289527317,

pkg/formats/rtpvp8/testdata/fuzz/FuzzDecoder/01b49f6ea4a5f782

@@ -1,3 +1,5 @@
 go test fuzz v1
+[]byte("")
+bool(false)
 []byte("1000")
 bool(false)

pkg/formats/rtpvp8/testdata/fuzz/FuzzDecoder/079a435e5445c35b

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("")
+bool(false)
+[]byte("")
+bool(false)

pkg/formats/rtpvp8/testdata/fuzz/FuzzDecoder/2b9461645a4b90d2

@@ -0,0 +1,5 @@
+go test fuzz v1
+[]byte("\xf8\x9a\x9f000")
+bool(true)
+[]byte(" 00000")
+bool(false)

pkg/formats/rtpvp8/testdata/fuzz/FuzzDecoder/7a1c68afba07c13a12f3686c52a228b2ca8d9794363a61529fcad02658ea03e3

@@ -1,3 +0,0 @@
-go test fuzz v1
-[]byte(" 000")
-bool(false)

pkg/formats/rtpvp9/decoder_test.go

@@ -27,14 +27,26 @@ func TestDecode(t *testing.T) {
 }
 
 func FuzzDecoder(f *testing.F) {
-	d := &Decoder{}
+	f.Fuzz(func(t *testing.T, a []byte, am bool, b []byte, bm bool) {
-	d.Init()
+		d := &Decoder{}
+		d.Init()
 
-	f.Fuzz(func(t *testing.T, b []byte, m bool) {
 		d.Decode(&rtp.Packet{
 			Header: rtp.Header{
 				Version:        2,
-				Marker:         m,
+				Marker:         am,
+				PayloadType:    96,
+				SequenceNumber: 17645,
+				Timestamp:      2289527317,
+				SSRC:           0x9dbb7812,
+			},
+			Payload: a,
+		})
+
+		d.Decode(&rtp.Packet{
+			Header: rtp.Header{
+				Version:        2,
+				Marker:         bm,
 				PayloadType:    96,
 				SequenceNumber: 17645,
 				Timestamp:      2289527317,

pkg/formats/rtpvp9/testdata/fuzz/FuzzDecoder/41b798362d81811a

@@ -1,5 +1,5 @@
 go test fuzz v1
-[]byte("00")
+[]byte("M")
-bool(false)
-[]byte("\x00\f00")
 bool(true)
+[]byte("A")
+bool(false)

pkg/formats/rtpvp9/testdata/fuzz/FuzzDecoder/5c3924785d154da4

@@ -1,5 +1,5 @@
 go test fuzz v1
 []byte("0")
 bool(false)
-[]byte("\x00\f00")
+[]byte("")
 bool(false)

pkg/formats/rtpvp9/testdata/fuzz/FuzzDecoder/a562b457d1a04bb296308020307f2e271491c804e84959ad2d5fdaa2e32b6a0f

@@ -1,3 +0,0 @@
-go test fuzz v1
-[]byte("")
-bool(true)