update golangci-lint

.golangci.yml

@@ -1,6 +1,7 @@
 
 linters:
   enable:
+  - asciicheck
   - bodyclose
   - dupl
   - exportloopref
@@ -11,8 +12,10 @@ linters:
   - misspell
   - lll
   - prealloc
+  - predeclared
   - revive
   - unconvert
+  - wastedassign
   - whitespace
   disable:
   - errcheck

pkg/rtpaac/rtpaac_test.go

@@ -239,7 +239,7 @@ func TestDecode(t *testing.T) {
 				err := pkt.Unmarshal(byts)
 				require.NoError(t, err)
 
-				copy := pkt.Clone()
+				clone := pkt.Clone()
 
 				addAUs, pts, err := d.Decode(&pkt)
 				if err == ErrMorePacketsNeeded {
@@ -252,7 +252,7 @@ func TestDecode(t *testing.T) {
 				expPTS += time.Duration(len(aus)) * 1000 * time.Second / 48000
 
 				// test packet integrity
-				require.Equal(t, copy, &pkt)
+				require.Equal(t, clone, &pkt)
 			}
 
 			require.Equal(t, ca.aus, aus)

pkg/rtph264/rtph264_test.go

@@ -244,7 +244,7 @@ func TestDecode(t *testing.T) {
 				err := pkt.Unmarshal(byts)
 				require.NoError(t, err)
 
-				copy := pkt.Clone()
+				clone := pkt.Clone()
 
 				addNALUs, pts, err := d.Decode(&pkt)
 				if err == ErrMorePacketsNeeded {
@@ -256,7 +256,7 @@ func TestDecode(t *testing.T) {
 				nalus = append(nalus, addNALUs...)
 
 				// test packet integrity
-				require.Equal(t, copy, &pkt)
+				require.Equal(t, clone, &pkt)
 			}
 
 			require.Equal(t, ca.nalus, nalus)

track_aac_test.go

@@ -26,9 +26,9 @@ func TestTrackAACClone(t *testing.T) {
 	track, err := NewTrackAAC(96, 2, 48000, 2, []byte{0x01, 0x02})
 	require.NoError(t, err)
 
-	copy := track.clone()
+	clone := track.clone()
-	require.NotSame(t, track, copy)
+	require.NotSame(t, track, clone)
-	require.Equal(t, track, copy)
+	require.Equal(t, track, clone)
 }
 
 func TestTrackAACMediaDescription(t *testing.T) {

track_generic_test.go

@@ -53,9 +53,9 @@ func TestTrackGenericClone(t *testing.T) {
 		})
 	require.NoError(t, err)
 
-	copy := track.clone()
+	clone := track.clone()
-	require.NotSame(t, track, copy)
+	require.NotSame(t, track, clone)
-	require.Equal(t, track, copy)
+	require.Equal(t, track, clone)
 }
 
 func TestTrackGenericMediaDescription(t *testing.T) {

track_h264_test.go

@@ -178,9 +178,9 @@ func TestTrackH264Clone(t *testing.T) {
 	track, err := NewTrackH264(96, []byte{0x01, 0x02}, []byte{0x03, 0x04}, []byte{0x05, 0x06})
 	require.NoError(t, err)
 
-	copy := track.clone()
+	clone := track.clone()
-	require.NotSame(t, track, copy)
+	require.NotSame(t, track, clone)
-	require.Equal(t, track, copy)
+	require.Equal(t, track, clone)
 }
 
 func TestTrackH264MediaDescription(t *testing.T) {

track_opus_test.go

@@ -19,9 +19,9 @@ func TestTracOpusClone(t *testing.T) {
 	track, err := NewTrackOpus(96, 96000, 4)
 	require.NoError(t, err)
 
-	copy := track.clone()
+	clone := track.clone()
-	require.NotSame(t, track, copy)
+	require.NotSame(t, track, clone)
-	require.Equal(t, track, copy)
+	require.Equal(t, track, clone)
 }
 
 func TestTrackOpusMediaDescription(t *testing.T) {