detect when the connection with the server is closed when publishing with udp (#6)

connclient.go

@@ -732,75 +732,82 @@ func (c *ConnClient) Play(u *url.URL) (*base.Response, error) {
 	return res, nil
 }
 
-// LoopUDP must be called after SetupUDP() and Play(); it keeps
+// LoopUDP must be called after Play() or Record(); it keeps
 // the TCP connection open with keepalives, and returns when the TCP
 // connection closes.
 func (c *ConnClient) LoopUDP() error {
-	if c.state != connClientStateReading {
+	if c.state != connClientStateReading && c.state != connClientStatePublishing {
-		return fmt.Errorf("can be called only after a successful Play()")
+		return fmt.Errorf("can be called only after a successful Play() or Record()")
 	}
 
 	if *c.streamProtocol != StreamProtocolUDP {
 		return fmt.Errorf("stream protocol is not UDP")
 	}
 
-	readDone := make(chan error)
+	if c.state == connClientStateReading {
-	go func() {
+		readDone := make(chan error)
+		go func() {
+			for {
+				c.conf.Conn.SetReadDeadline(time.Now().Add(clientUDPKeepalivePeriod + c.conf.ReadTimeout))
+				var res base.Response
+				err := res.Read(c.br)
+				if err != nil {
+					readDone <- err
+					return
+				}
+			}
+		}()
+
+		keepaliveTicker := time.NewTicker(clientUDPKeepalivePeriod)
+		defer keepaliveTicker.Stop()
+
+		checkStreamTicker := time.NewTicker(clientUDPCheckStreamPeriod)
+		defer checkStreamTicker.Stop()
+
 		for {
-			c.conf.Conn.SetReadDeadline(time.Now().Add(clientUDPKeepalivePeriod + c.conf.ReadTimeout))
+			select {
-			var res base.Response
+			case err := <-readDone:
-			err := res.Read(c.br)
-			if err != nil {
-				readDone <- err
-				return
-			}
-		}
-	}()
-
-	keepaliveTicker := time.NewTicker(clientUDPKeepalivePeriod)
-	defer keepaliveTicker.Stop()
-
-	checkStreamTicker := time.NewTicker(clientUDPCheckStreamPeriod)
-	defer checkStreamTicker.Stop()
-
-	for {
-		select {
-		case err := <-readDone:
-			c.conf.Conn.Close()
-			return err
-
-		case <-keepaliveTicker.C:
-			_, err := c.Do(&base.Request{
-				Method: base.OPTIONS,
-				Url: &url.URL{
-					Scheme: "rtsp",
-					Host:   c.streamUrl.Host,
-					User:   c.streamUrl.User,
-					// use the stream path, otherwise some cameras do not reply
-					Path: c.streamUrl.Path,
-				},
-				SkipResponse: true,
-			})
-			if err != nil {
 				c.conf.Conn.Close()
-				<-readDone
 				return err
-			}
 
-		case <-checkStreamTicker.C:
+			case <-keepaliveTicker.C:
-			now := time.Now()
+				_, err := c.Do(&base.Request{
-
+					Method: base.OPTIONS,
-			for _, lastUnix := range c.udpLastFrameTimes {
+					Url: &url.URL{
-				last := time.Unix(atomic.LoadInt64(lastUnix), 0)
+						Scheme: "rtsp",
-
+						Host:   c.streamUrl.Host,
-				if now.Sub(last) >= c.conf.ReadTimeout {
+						User:   c.streamUrl.User,
+						// use the stream path, otherwise some cameras do not reply
+						Path: c.streamUrl.Path,
+					},
+					SkipResponse: true,
+				})
+				if err != nil {
 					c.conf.Conn.Close()
 					<-readDone
-					return fmt.Errorf("no packets received recently (maybe there's a firewall/NAT in between)")
+					return err
+				}
+
+			case <-checkStreamTicker.C:
+				now := time.Now()
+
+				for _, lastUnix := range c.udpLastFrameTimes {
+					last := time.Unix(atomic.LoadInt64(lastUnix), 0)
+
+					if now.Sub(last) >= c.conf.ReadTimeout {
+						c.conf.Conn.Close()
+						<-readDone
+						return fmt.Errorf("no packets received recently (maybe there's a firewall/NAT in between)")
+					}
 				}
 			}
 		}
 	}
+
+	// connClientStatePublishing
+	c.conf.Conn.SetReadDeadline(time.Time{}) // disable deadline
+	var res base.Response
+	return res.Read(c.br)
 }
 
 // Announce writes an ANNOUNCE request and reads a Response.

connclientdial_test.go

@@ -161,6 +161,7 @@ func TestConnClientDialPublishUDP(t *testing.T) {
 			var conn *ConnClient
 			defer func() {
 				conn.Close()
+				conn.LoopUDP()
 			}()
 
 			go func() {

examples/client-publish-tcp.go

@@ -59,6 +59,7 @@ func main() {
 		// write frames to the server
 		err = conn.WriteFrameTCP(track.Id, gortsplib.StreamTypeRtp, buf[:n])
 		if err != nil {
+			fmt.Println("connection is closed (%s)", err)
 			break
 		}
 	}

examples/client-publish-udp.go

@@ -62,4 +62,8 @@ func main() {
 			break
 		}
 	}
+
+	// wait until the connection is closed
+	err = conn.LoopUDP()
+	fmt.Println("connection is closed (%s)", err)
 }

examples/client-read-udp.go

@@ -56,6 +56,7 @@ func main() {
 		}(trackId)
 	}
 
+	// wait until the connection is closed
 	err = conn.LoopUDP()
 	fmt.Println("connection is closed (%s)", err)
 }