From a0a168d26cfb4477c143ffee80d2853305013d5d Mon Sep 17 00:00:00 2001
From: aler9 <46489434+aler9@users.noreply.github.com>
Date: Sun, 14 Aug 2022 20:54:57 +0200
Subject: [PATCH] improve tests

---
 track_h264_test.go       | 33 +++++++++++++++++----------------
 track_h265_test.go       |  3 ++-
 track_jpeg_test.go       |  8 +++++++-
 track_mpeg2audio_test.go |  5 +++--
 track_mpeg2video_test.go |  5 +++--
 track_mpeg4audio_test.go | 16 ++++++++++++++++
 track_opus_test.go       | 10 ++++++++++
 track_pcma_test.go       |  5 +++--
 track_pcmu_test.go       |  5 +++--
 track_vp8_test.go        |  8 +++++++-
 track_vp9_test.go        |  8 +++++++-
 11 files changed, 78 insertions(+), 28 deletions(-)

diff --git a/track_h264_test.go b/track_h264_test.go
index 24aa32f6..6e10b4e8 100644
--- a/track_h264_test.go
+++ b/track_h264_test.go
@@ -7,6 +7,23 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func TestTrackH264Attributes(t *testing.T) {
+	track := &TrackH264{
+		PayloadType: 96,
+		SPS:         []byte{0x01, 0x02},
+		PPS:         []byte{0x03, 0x04},
+	}
+	require.Equal(t, 90000, track.ClockRate())
+	require.Equal(t, "", track.GetControl())
+	require.Equal(t, []byte{0x01, 0x02}, track.SafeSPS())
+	require.Equal(t, []byte{0x03, 0x04}, track.SafePPS())
+
+	track.SafeSetSPS([]byte{0x07, 0x08})
+	track.SafeSetPPS([]byte{0x09, 0x0A})
+	require.Equal(t, []byte{0x07, 0x08}, track.SafeSPS())
+	require.Equal(t, []byte{0x09, 0x0A}, track.SafePPS())
+}
+
 func TestTrackH264GetSPSPPSErrors(t *testing.T) {
 	for _, ca := range []struct {
 		name string
@@ -165,22 +182,6 @@ func TestTrackH264GetSPSPPSErrors(t *testing.T) {
 	}
 }
 
-func TestTrackH264Params(t *testing.T) {
-	track := &TrackH264{
-		PayloadType: 96,
-		SPS:         []byte{0x01, 0x02},
-		PPS:         []byte{0x03, 0x04},
-	}
-	require.Equal(t, "", track.GetControl())
-	require.Equal(t, []byte{0x01, 0x02}, track.SafeSPS())
-	require.Equal(t, []byte{0x03, 0x04}, track.SafePPS())
-
-	track.SafeSetSPS([]byte{0x07, 0x08})
-	track.SafeSetPPS([]byte{0x09, 0x0A})
-	require.Equal(t, []byte{0x07, 0x08}, track.SafeSPS())
-	require.Equal(t, []byte{0x09, 0x0A}, track.SafePPS())
-}
-
 func TestTrackH264Clone(t *testing.T) {
 	track := &TrackH264{
 		PayloadType: 96,
diff --git a/track_h265_test.go b/track_h265_test.go
index 479ad607..bfc32daa 100644
--- a/track_h265_test.go
+++ b/track_h265_test.go
@@ -7,13 +7,14 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestTrackH265Params(t *testing.T) {
+func TestTrackH265Attributes(t *testing.T) {
 	track := &TrackH265{
 		PayloadType: 96,
 		VPS:         []byte{0x01, 0x02},
 		SPS:         []byte{0x03, 0x04},
 		PPS:         []byte{0x05, 0x06},
 	}
+	require.Equal(t, 90000, track.ClockRate())
 	require.Equal(t, "", track.GetControl())
 	require.Equal(t, []byte{0x01, 0x02}, track.SafeVPS())
 	require.Equal(t, []byte{0x03, 0x04}, track.SafeSPS())
diff --git a/track_jpeg_test.go b/track_jpeg_test.go
index 4b4bc42f..3e001bd3 100644
--- a/track_jpeg_test.go
+++ b/track_jpeg_test.go
@@ -1,4 +1,4 @@
-package gortsplib
+package gortsplib //nolint:dupl
 
 import (
 	"testing"
@@ -7,6 +7,12 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func TestTrackJPEGAttributes(t *testing.T) {
+	track := &TrackJPEG{}
+	require.Equal(t, 90000, track.ClockRate())
+	require.Equal(t, "", track.GetControl())
+}
+
 func TestTrackJPEGClone(t *testing.T) {
 	track := &TrackJPEG{}
 
diff --git a/track_mpeg2audio_test.go b/track_mpeg2audio_test.go
index 91310d35..bf9c4a91 100644
--- a/track_mpeg2audio_test.go
+++ b/track_mpeg2audio_test.go
@@ -1,4 +1,4 @@
-package gortsplib
+package gortsplib //nolint:dupl
 
 import (
 	"testing"
@@ -7,8 +7,9 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestTrackMPEG2AudioNew(t *testing.T) {
+func TestTrackMPEG2AudioAttributes(t *testing.T) {
 	track := &TrackMPEG2Audio{}
+	require.Equal(t, 90000, track.ClockRate())
 	require.Equal(t, "", track.GetControl())
 }
 
diff --git a/track_mpeg2video_test.go b/track_mpeg2video_test.go
index 7c8c5d19..608bf9c4 100644
--- a/track_mpeg2video_test.go
+++ b/track_mpeg2video_test.go
@@ -1,4 +1,4 @@
-package gortsplib
+package gortsplib //nolint:dupl
 
 import (
 	"testing"
@@ -7,8 +7,9 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestTrackMPEG2VideoNew(t *testing.T) {
+func TestTrackMPEG2VideoAttributes(t *testing.T) {
 	track := &TrackMPEG2Video{}
+	require.Equal(t, 90000, track.ClockRate())
 	require.Equal(t, "", track.GetControl())
 }
 
diff --git a/track_mpeg4audio_test.go b/track_mpeg4audio_test.go
index 619cd460..24461515 100644
--- a/track_mpeg4audio_test.go
+++ b/track_mpeg4audio_test.go
@@ -9,6 +9,22 @@ import (
 	"github.com/aler9/gortsplib/pkg/mpeg4audio"
 )
 
+func TestTrackMPEG4AudioAttributes(t *testing.T) {
+	track := &TrackMPEG4Audio{
+		PayloadType: 96,
+		Config: &mpeg4audio.Config{
+			Type:         2,
+			SampleRate:   48000,
+			ChannelCount: 2,
+		},
+		SizeLength:       13,
+		IndexLength:      3,
+		IndexDeltaLength: 3,
+	}
+	require.Equal(t, 48000, track.ClockRate())
+	require.Equal(t, "", track.GetControl())
+}
+
 func TestTrackMPEG4AudioClone(t *testing.T) {
 	track := &TrackMPEG4Audio{
 		PayloadType: 96,
diff --git a/track_opus_test.go b/track_opus_test.go
index e87e5342..ee30eb56 100644
--- a/track_opus_test.go
+++ b/track_opus_test.go
@@ -7,6 +7,16 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func TestTrackOpusAttributes(t *testing.T) {
+	track := &TrackOpus{
+		PayloadType:  96,
+		SampleRate:   48000,
+		ChannelCount: 2,
+	}
+	require.Equal(t, 48000, track.ClockRate())
+	require.Equal(t, "", track.GetControl())
+}
+
 func TestTracOpusClone(t *testing.T) {
 	track := &TrackOpus{
 		PayloadType:  96,
diff --git a/track_pcma_test.go b/track_pcma_test.go
index f78df502..b5b75c96 100644
--- a/track_pcma_test.go
+++ b/track_pcma_test.go
@@ -1,4 +1,4 @@
-package gortsplib
+package gortsplib //nolint:dupl
 
 import (
 	"testing"
@@ -7,8 +7,9 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestTrackPCMANew(t *testing.T) {
+func TestTrackPCMAAttributes(t *testing.T) {
 	track := &TrackPCMA{}
+	require.Equal(t, 8000, track.ClockRate())
 	require.Equal(t, "", track.GetControl())
 }
 
diff --git a/track_pcmu_test.go b/track_pcmu_test.go
index dae4a871..2bf55d57 100644
--- a/track_pcmu_test.go
+++ b/track_pcmu_test.go
@@ -1,4 +1,4 @@
-package gortsplib
+package gortsplib //nolint:dupl
 
 import (
 	"testing"
@@ -7,8 +7,9 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestTrackPCMUNew(t *testing.T) {
+func TestTrackPCMUAttributes(t *testing.T) {
 	track := &TrackPCMU{}
+	require.Equal(t, 8000, track.ClockRate())
 	require.Equal(t, "", track.GetControl())
 }
 
diff --git a/track_vp8_test.go b/track_vp8_test.go
index eab65528..45b62553 100644
--- a/track_vp8_test.go
+++ b/track_vp8_test.go
@@ -7,7 +7,13 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestTracVP8Clone(t *testing.T) {
+func TestTrackVP8ttributes(t *testing.T) {
+	track := &TrackVP8{}
+	require.Equal(t, 90000, track.ClockRate())
+	require.Equal(t, "", track.GetControl())
+}
+
+func TestTrackVP8Clone(t *testing.T) {
 	maxFR := 123
 	maxFS := 456
 	track := &TrackVP8{
diff --git a/track_vp9_test.go b/track_vp9_test.go
index bf0bf252..94adf530 100644
--- a/track_vp9_test.go
+++ b/track_vp9_test.go
@@ -7,7 +7,13 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestTracVP9Clone(t *testing.T) {
+func TestTrackVP9ttributes(t *testing.T) {
+	track := &TrackVP9{}
+	require.Equal(t, 90000, track.ClockRate())
+	require.Equal(t, "", track.GetControl())
+}
+
+func TestTrackVP9Clone(t *testing.T) {
 	maxFR := 123
 	maxFS := 456
 	profileID := 789