fix race condition in test (#826)

This commit is contained in:
Alessandro Ros
2025-07-06 21:02:00 +02:00
committed by GitHub
parent 38ce53bc72
commit 68245663ec

View File

@@ -1335,13 +1335,9 @@ func TestClientPlayAnyPort(t *testing.T) {
packetRecv := make(chan struct{})
c := Client{
AnyPortEnable: true,
receiverReportPeriod: 100 * time.Millisecond,
AnyPortEnable: true,
}
clientErr := make(chan struct{})
defer func() { <-clientErr }()
var med *description.Media
err = readAll(&c, "rtsp://localhost:8554/teststream",
func(medi *description.Media, _ format.Format, pkt *rtp.Packet) {
@@ -1352,12 +1348,6 @@ func TestClientPlayAnyPort(t *testing.T) {
require.NoError(t, err)
defer c.Close()
go func() {
err := c.Wait()
require.EqualError(t, err, "terminated")
close(clientErr)
}()
<-packetRecv
if ca == "random" {
@@ -1365,13 +1355,6 @@ func TestClientPlayAnyPort(t *testing.T) {
require.NoError(t, err)
<-serverRecv
}
// make sure that RTCP receiver reports do not cause any error
select {
case <-time.After(200 * time.Millisecond):
case <-clientErr:
t.Error("should not happen")
}
})
}
}