package/gortsplib
1
0
Fork 0
mirror of https://github.com/aler9/gortsplib synced 2025-10-16 20:20:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

prevent decoders from emitting corrupted frames (#638)

Browse Source
This commit is contained in:
Alessandro Ros
2024-10-23 21:10:37 +02:00
committed by GitHub
parent f41b196241
commit 508d025097
21 changed files with 647 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/format/rtpmpeg4audio/decoder_generic.go
View File

@@ -38,6 +38,8 @@ func (d *Decoder) decodeGeneric(pkt *rtp.Packet) ([][]byte, error) {
var aus [][]byte
if d.fragmentsSize == 0 {
d.resetFragments()
if pkt.Marker {
// AUs
aus = make([][]byte, len(dataLens))
@@ -60,6 +62,7 @@ func (d *Decoder) decodeGeneric(pkt *rtp.Packet) ([][]byte, error) {
d.fragmentsSize = int(dataLens[0])
d.fragments = append(d.fragments, payload[:dataLens[0]])
d.fragmentNextSeqNum = pkt.SequenceNumber + 1
return nil, ErrMorePacketsNeeded
}
} else {
@@ -74,7 +77,13 @@ func (d *Decoder) decodeGeneric(pkt *rtp.Packet) ([][]byte, error) {
return nil, fmt.Errorf("payload is too short")
}
if pkt.SequenceNumber != d.fragmentNextSeqNum {
d.resetFragments()
return nil, fmt.Errorf("discarding frame since a RTP packet is missing")
}
d.fragmentsSize += int(dataLens[0])
if d.fragmentsSize > mpeg4audio.MaxAccessUnitSize {
d.resetFragments()
return nil, fmt.Errorf("access unit size (%d) is too big, maximum is %d",
@@ -82,6 +91,7 @@ func (d *Decoder) decodeGeneric(pkt *rtp.Packet) ([][]byte, error) {
}
d.fragments = append(d.fragments, payload[:dataLens[0]])
d.fragmentNextSeqNum++
if !pkt.Marker {
return nil, ErrMorePacketsNeeded