package/gortsplib
1
0
Fork 0
mirror of https://github.com/aler9/gortsplib synced 2025-10-05 23:26:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

headers: add negative unit tests

Browse Source
This commit is contained in:
aler9
2021-04-19 22:47:43 +02:00
parent be5df0f7f7
commit 49dfd34ede
2 changed files with 73 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/headers/keyval.go
View File

@@ -6,15 +6,11 @@ import (
) )
func findValue(str string, separator byte) (string, string, error) { func findValue(str string, separator byte) (string, string, error) {
if str == "" { if len(str) > 0 && str[0] == '"' {
return "", "", nil
}
if str[0] == '"' {
i := 1 i := 1
for { for {
if i >= len(str) { if i >= len(str) {
return "", "", fmt.Errorf("apices not closed (%v)", str) return "", "", fmt.Errorf("apexes not closed (%v)", str)
} }
if str[i] == '"' { if str[i] == '"' {
@@ -41,7 +37,7 @@ func keyValParse(str string, separator byte) (map[string]string, error) {
for len(str) > 0 { for len(str) > 0 {
i := strings.IndexByte(str, '=') i := strings.IndexByte(str, '=')
if i < 0 { if i < 0 {
return nil, fmt.Errorf("unable to find key '%v'", str) return nil, fmt.Errorf("unable to find key (%v)", str)
} }
var k string var k string
k, str = str[:i], str[i+1:] k, str = str[:i], str[i+1:]

40
pkg/headers/keyval_test.go
View File

@@ -6,11 +6,12 @@ import (
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
) )
var casesKeyVal = []struct { func TestKeyValParse(t *testing.T) {
for _, ca := range []struct {
name string name string
s string s string
kvs map[string]string kvs map[string]string
}{ }{
{ {
"base", "base",
`key1=v1,key2=v2`, `key1=v1,key2=v2`,
@@ -28,7 +29,7 @@ var casesKeyVal = []struct {
}, },
}, },
{ {
"with apices", "with apexes",
`key1="v1", key2=v2`, `key1="v1", key2=v2`,
map[string]string{ map[string]string{
"key1": "v1", "key1": "v1",
@@ -36,7 +37,7 @@ var casesKeyVal = []struct {
}, },
}, },
{ {
"with apices and comma", "with apexes and comma",
`key1="v,1", key2="v2"`, `key1="v,1", key2="v2"`,
map[string]string{ map[string]string{
"key1": "v,1", "key1": "v,1",
@@ -44,17 +45,14 @@ var casesKeyVal = []struct {
}, },
}, },
{ {
"with apices and equal", "with apexes and equal",
`key1="v=1", key2="v2"`, `key1="v=1", key2="v2"`,
map[string]string{ map[string]string{
"key1": "v=1", "key1": "v=1",
"key2": "v2", "key2": "v2",
}, },
}, },
} } {
func TestKeyValParse(t *testing.T) {
for _, ca := range casesKeyVal {
t.Run(ca.name, func(t *testing.T) { t.Run(ca.name, func(t *testing.T) {
kvs, err := keyValParse(ca.s, ',') kvs, err := keyValParse(ca.s, ',')
require.NoError(t, err) require.NoError(t, err)
@@ -62,3 +60,27 @@ func TestKeyValParse(t *testing.T) {
}) })
} }
} }
func TestKeyValParseError(t *testing.T) {
for _, ca := range []struct {
name string
s string
err string
}{
{
"apexes not closed",
`key1="v,1`,
"apexes not closed (\"v,1)",
},
{
"no key",
`value`,
"unable to find key (value)",
},
} {
t.Run(ca.name, func(t *testing.T) {
_, err := keyValParse(ca.s, ',')
require.Equal(t, ca.err, err.Error())
})
}
}