From 1c9fb776309d493aca8d54dddb1dfeb15db68b78 Mon Sep 17 00:00:00 2001 From: aler9 <46489434+aler9@users.noreply.github.com> Date: Thu, 17 Feb 2022 21:19:38 +0100 Subject: [PATCH] improve coverage --- track_aac_test.go | 6 ++++++ track_generic_test.go | 12 ++++++++++-- track_h264_test.go | 1 + track_opus_test.go | 1 + 4 files changed, 18 insertions(+), 2 deletions(-) diff --git a/track_aac_test.go b/track_aac_test.go index 6df37625..3f499750 100644 --- a/track_aac_test.go +++ b/track_aac_test.go @@ -10,12 +10,18 @@ import ( func TestTrackAACNew(t *testing.T) { track, err := NewTrackAAC(96, 2, 48000, 4, []byte{0x01, 0x02}) require.NoError(t, err) + require.Equal(t, "", track.GetControl()) require.Equal(t, 2, track.Type()) require.Equal(t, 48000, track.ClockRate()) require.Equal(t, 4, track.ChannelCount()) require.Equal(t, []byte{0x01, 0x02}, track.AOTSpecificConfig()) } +func TestTrackAACNewErrors(t *testing.T) { + _, err := NewTrackAAC(96, 2, 48000, 10, nil) + require.EqualError(t, err, "invalid configuration: invalid channel count (10)") +} + func TestTrackAACClone(t *testing.T) { track, err := NewTrackAAC(96, 2, 48000, 2, []byte{0x01, 0x02}) require.NoError(t, err) diff --git a/track_generic_test.go b/track_generic_test.go index 3952bb53..90384f7f 100644 --- a/track_generic_test.go +++ b/track_generic_test.go @@ -12,9 +12,11 @@ func TestTrackGenericNew(t *testing.T) { "video", []string{"100", "101"}, "98 H265/90000", - "", + "98 profile-id=1; sprop-vps=QAEMAf//AWAAAAMAAAMAAAMAAAMAlqwJ; "+ + "sprop-sps=QgEBAWAAAAMAAAMAAAMAAAMAlqADwIAQ5Za5JMmuWcBSSgAAB9AAAHUwgkA=; sprop-pps=RAHgdrAwxmQ=", ) require.NoError(t, err) + require.Equal(t, "", track.GetControl()) require.Equal(t, 90000, track.ClockRate()) } @@ -61,7 +63,8 @@ func TestTrackGenericMediaDescription(t *testing.T) { "video", []string{"100", "101"}, "98 H265/90000", - "", + "98 profile-id=1; sprop-vps=QAEMAf//AWAAAAMAAAMAAAMAAAMAlqwJ; "+ + "sprop-sps=QgEBAWAAAAMAAAMAAAMAAAMAlqADwIAQ5Za5JMmuWcBSSgAAB9AAAHUwgkA=; sprop-pps=RAHgdrAwxmQ=", ) require.NoError(t, err) require.Equal(t, &psdp.MediaDescription{ @@ -75,6 +78,11 @@ func TestTrackGenericMediaDescription(t *testing.T) { Key: "rtpmap", Value: "98 H265/90000", }, + { + Key: "fmtp", + Value: "98 profile-id=1; sprop-vps=QAEMAf//AWAAAAMAAAMAAAMAAAMAlqwJ; " + + "sprop-sps=QgEBAWAAAAMAAAMAAAMAAAMAlqADwIAQ5Za5JMmuWcBSSgAAB9AAAHUwgkA=; sprop-pps=RAHgdrAwxmQ=", + }, { Key: "control", Value: "", diff --git a/track_h264_test.go b/track_h264_test.go index 8254ec06..4b4b9185 100644 --- a/track_h264_test.go +++ b/track_h264_test.go @@ -168,6 +168,7 @@ func TestTrackH264New(t *testing.T) { track, err := NewTrackH264(96, []byte{0x01, 0x02}, []byte{0x03, 0x04}, []byte{0x05, 0x06}) require.NoError(t, err) + require.Equal(t, "", track.GetControl()) require.Equal(t, []byte{0x01, 0x02}, track.SPS()) require.Equal(t, []byte{0x03, 0x04}, track.PPS()) require.Equal(t, []byte{0x05, 0x06}, track.ExtraData()) diff --git a/track_opus_test.go b/track_opus_test.go index 7a274b91..59d9f644 100644 --- a/track_opus_test.go +++ b/track_opus_test.go @@ -10,6 +10,7 @@ import ( func TestTrackOpusNew(t *testing.T) { track, err := NewTrackOpus(96, 48000, 2) require.NoError(t, err) + require.Equal(t, "", track.GetControl()) require.Equal(t, 48000, track.ClockRate()) require.Equal(t, 2, track.ChannelCount()) }