package/gortsplib
1
0
Fork 0
mirror of https://github.com/aler9/gortsplib synced 2025-10-05 07:06:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

ringbuffer: force size to be a power of 2

Browse Source 
otherwise buffer is used partially when writeIndex overflows.
This commit is contained in:
aler9
2022-07-05 19:25:53 +02:00
parent ef900359ce
commit 18005a9cde
6 changed files with 41 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
client.go
View File

@@ -318,6 +318,9 @@ func (c *Client) Start(scheme string, host string) error {
if c.WriteBufferCount == 0 {
c.WriteBufferCount = 256
}
if (c.WriteBufferCount & (c.WriteBufferCount - 1)) != 0 {
return fmt.Errorf("WriteBufferCount must be a power of two")
}
if c.UserAgent == "" {
c.UserAgent = "gortsplib"
}
@@ -699,9 +702,9 @@ func (c *Client) playRecordStart() {
// when reading, writeBuffer is only used to send RTCP receiver reports,
// that are much smaller than RTP packets and are sent at a fixed interval.
// decrease RAM consumption by allocating less buffers.
c.writeBuffer = ringbuffer.New(8)
c.writeBuffer, _ = ringbuffer.New(8)
} else {
c.writeBuffer = ringbuffer.New(uint64(c.WriteBufferCount))
c.writeBuffer, _ = ringbuffer.New(uint64(c.WriteBufferCount))
}
c.writerRunning = true
c.writerDone = make(chan struct{})