From 14393985fe3fffe16e8c64c336e82c54d9440167 Mon Sep 17 00:00:00 2001
From: aler9 <46489434+aler9@users.noreply.github.com>
Date: Sat, 29 May 2021 19:30:12 +0200
Subject: [PATCH] base: improve coverage

---
 pkg/base/defs.go      | 39 +++++++++++++++++++++------------------
 pkg/base/defs_test.go | 18 ++++++++++++++++++
 2 files changed, 39 insertions(+), 18 deletions(-)
 create mode 100644 pkg/base/defs_test.go

diff --git a/pkg/base/defs.go b/pkg/base/defs.go
index ed241d0a..64272c67 100644
--- a/pkg/base/defs.go
+++ b/pkg/base/defs.go
@@ -11,14 +11,15 @@ const (
 	StreamProtocolTCP
 )
 
+var streamProtocolLabels = map[StreamProtocol]string{
+	StreamProtocolUDP: "UDP",
+	StreamProtocolTCP: "TCP",
+}
+
 // String implements fmt.Stringer.
 func (sp StreamProtocol) String() string {
-	switch sp {
-	case StreamProtocolUDP:
-		return "UDP"
-
-	case StreamProtocolTCP:
-		return "TCP"
+	if l, ok := streamProtocolLabels[sp]; ok {
+		return l
 	}
 	return "unknown"
 }
@@ -34,14 +35,15 @@ const (
 	StreamDeliveryMulticast
 )
 
+var streamDeliveryLabels = map[StreamDelivery]string{
+	StreamDeliveryUnicast:   "unicast",
+	StreamDeliveryMulticast: "multicast",
+}
+
 // String implements fmt.Stringer.
 func (sc StreamDelivery) String() string {
-	switch sc {
-	case StreamDeliveryUnicast:
-		return "unicast"
-
-	case StreamDeliveryMulticast:
-		return "multicast"
+	if l, ok := streamDeliveryLabels[sc]; ok {
+		return l
 	}
 	return "unknown"
 }
@@ -57,14 +59,15 @@ const (
 	StreamTypeRTCP
 )
 
+var streamTypeLabels = map[StreamType]string{
+	StreamTypeRTP:  "RTP",
+	StreamTypeRTCP: "RTCP",
+}
+
 // String implements fmt.Stringer
 func (st StreamType) String() string {
-	switch st {
-	case StreamTypeRTP:
-		return "RTP"
-
-	case StreamTypeRTCP:
-		return "RTCP"
+	if l, ok := streamTypeLabels[st]; ok {
+		return l
 	}
 	return "unknown"
 }
diff --git a/pkg/base/defs_test.go b/pkg/base/defs_test.go
new file mode 100644
index 00000000..18748196
--- /dev/null
+++ b/pkg/base/defs_test.go
@@ -0,0 +1,18 @@
+package base
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestDefs(t *testing.T) {
+	require.NotEqual(t, "unknown", StreamProtocolUDP.String())
+	require.Equal(t, "unknown", StreamProtocol(4).String())
+
+	require.NotEqual(t, "unknown", StreamDeliveryUnicast.String())
+	require.Equal(t, "unknown", StreamDelivery(4).String())
+
+	require.NotEqual(t, "unknown", StreamTypeRTP.String())
+	require.Equal(t, "unknown", StreamType(4).String())
+}