client: return an error in case of invalid packet (#305)

when reading with TCP and packet has an unknown format.
This commit is contained in:
Alessandro Ros
2023-06-08 23:33:29 +02:00
committed by GitHub
parent 6cdee49e5f
commit 0f97e8158c
5 changed files with 63 additions and 15 deletions

View File

@@ -1023,15 +1023,12 @@ func TestClientRecordDecodeErrors(t *testing.T) {
}(),
OnDecodeError: func(err error) {
switch {
case ca.proto == "udp" && ca.name == "rtcp invalid":
case ca.name == "rtcp invalid":
require.EqualError(t, err, "rtcp: packet too short")
case ca.proto == "udp" && ca.name == "rtcp too big":
require.EqualError(t, err, "RTCP packet is too big to be read with UDP")
case ca.proto == "tcp" && ca.name == "rtcp invalid":
require.EqualError(t, err, "rtcp: packet too short")
case ca.proto == "tcp" && ca.name == "rtcp too big":
require.EqualError(t, err, "RTCP packet size (2000) is greater than maximum allowed (1472)")
}