package/gortsplib
1
0
Fork 0
mirror of https://github.com/aler9/gortsplib synced 2025-10-16 20:20:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix ExtractConfigH264() when extradata is present

Browse Source 
The `sprop-parameter-sets` parameter in a SDP description of a H.264 stream could contain more that two fields. These fields could be considered extradata. Some tools like ffmpeg incorporate them if they are available. You can read about specs of this parameter at https://www.ietf.org/archive/id/draft-lennox-avt-h264-source-fmtp-00.html#anchor3 .

This is an example of a working description:
`a=fmtp:96 packetization-mode=1; sprop-parameter-sets=Z01AKJJSgPAIj7wEQAAAAwBAAAAMo8WLZYA=,aP48gAA=; profile-level-id=4D4028`

And this is another example that fails without this PR:
`a=fmtp:96 packetization-mode=1; sprop-parameter-sets=Z2QAKawTMUB4BEfeA+oCAgPgAAADACAAAAZSgA==,aPqPLA==,aF6jzAMA; profile-level-id=640029`

So assuming the optional presence of more than two fields in the `sprop-parameter-sets` parameter with PR solves the bug.
This commit is contained in:
Lars The
2022-01-28 12:07:30 +01:00
committed by Alessandro Ros
parent 3438279d73
commit 0014b6a82c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
track_h264.go
View File

@@ -96,8 +96,8 @@ func (t *Track) ExtractConfigH264() (*TrackConfigH264, error) {
} }
if tmp[0] == "sprop-parameter-sets" { if tmp[0] == "sprop-parameter-sets" {
tmp := strings.SplitN(tmp[1], ",", 2) tmp := strings.SplitN(tmp[1], ",", 3)
if len(tmp) != 2 { if len(tmp) < 2 {
return nil, fmt.Errorf("invalid sprop-parameter-sets (%v)", v) return nil, fmt.Errorf("invalid sprop-parameter-sets (%v)", v)
} }