Commit Graph

129 Commits

Author SHA1 Message Date
Vladimir Chalupecky
c8be30b70e testlapack: rework eigenvector checks in DgeevTest and adjust tolerances 2020-02-03 17:46:38 +01:00
Vladimír Chalupecký
a84dbb2e4f testlapack: adjust some tolerances (#1224) 2020-01-27 10:06:36 +01:00
Vladimir Chalupecky
dfc35ef41f lapack/testlapack: don't test unsupported matrix sizes in DlantrTest
The documentation for DLANTR in Reference-LAPACK says that the input
matrix should not be tall if upper triangular and not wide if lower
triangular. In most cases providing such "invalid" sizes is harmless and
DLANTR works correctly. However, when computing the inf-norm of lower
triangular matrices it currently causes an out-of-bound write if the
work array is shorter than the number of columns. Even if the reference
fixes this, we cannot assume when or if at all other LAPACK
implementation providers include it (both OpenBLAS and MKL have this
issue, obviously OpenBLAS being much easier to fix). Therefore, the
restriction on matrix sizes will have to stay in the reference
documentation and we should exlude them from our testing.
2019-12-23 13:34:54 +01:00
Vladimir Chalupecky
99c9c9662f lapack/testlapack: remove tests for Dlasq{3,4,5} with internal testdata 2019-12-19 00:01:06 +01:00
Vladimir Chalupecky
b4389a478b lapack/testlapack: rework Dlasq2 test
... so that it doesn't use precomputed data.
2019-12-18 10:19:34 +01:00
Vladimir Chalupecky
55b691b581 lapack/testlapack: rework Dlasq1Test 2019-12-15 09:12:19 +01:00
Vladimir Chalupecky
1d69e6a999 lapack/testlapack: avoid NaN in DsterfTest when n=1 2019-12-15 09:12:19 +01:00
Vladimir Chalupecky
f622cf2280 lapack/testlapack: remove dlaqr5data.json.gz 2019-12-12 21:28:05 +01:00
Vladimir Chalupecky
369d280772 lapack/testlapack: clean up DsterfTest 2019-12-03 11:18:39 +01:00
Vladimir Chalupecky
54be3505db lapack/internal: remove Fortran code for generating Dsterf test case 2019-12-01 09:53:38 +01:00
Vladimir Chalupecky
fe37b7a3cb lapack/testlapack: remove JSON-based part of Dlaqr5Test 2019-11-30 22:32:03 +01:00
Vladimir Chalupecky
9914f3aa6e lapack/testlapack: remove JSON-based part of Dlahr2Test 2019-11-30 20:29:02 +01:00
Dan Kortschak
937b367f5f testlapack: clean up lint 2019-11-07 19:57:05 +10:30
Vladimir Chalupecky
52906744a3 testlapack: allocate work only for MaxColumnSum in DlantrTest 2019-10-31 08:46:02 +01:00
Dan Kortschak
17ea55aedb blas,lapack: clean up docs and comments
Apply (with manual curation after the fact):
* s/^T/U+1d40/g
* s/^H/U+1d34/g
* s/, {2,3}if / $1/g

Some additional manual editing of odd formatting.
2019-09-06 20:02:29 +09:30
Vladimir Chalupecky
01f78999a4 lapack/gonum: fix inf-norm computation for unit lower triangular matrices 2019-08-17 00:48:19 +02:00
Vladimir Chalupecky
7584990dc8 lapack/testlapack: rework test for Dtrcon 2019-08-17 00:48:19 +02:00
Vladimir Chalupecky
cd1e4b9660 lapack/testlapack: fix spelling 2019-08-15 11:55:37 +02:00
Vladimir Chalupecky
8b91875836 lapack/gonum: add Dlansb with test 2019-08-15 11:55:37 +02:00
Vladimir Chalupecky
b720316f92 lapack/gonum: add Dcombssq with test 2019-08-15 11:55:37 +02:00
Vladimir Chalupecky
d3a6f40645 lapack/testlapack: add test for Dlassq 2019-08-15 11:55:37 +02:00
Vladimir Chalupecky
0242537858 lapack/testlapack: rewrite test for Dgecon from table-based to randomized 2019-08-15 09:46:50 +02:00
Vladimir Chalupecky
33540c531c lapack/testlapack: fix test for Dpbcon 2019-08-15 09:46:50 +02:00
Vladimir Chalupecky
3cac0797bd lapack/testlapack: add test for Dpbcon 2019-08-03 09:39:02 +02:00
Vladimir Chalupecky
e9a50d6433 lapack/gonum: fix matrix slice length checks in banded functions 2019-08-02 10:40:26 +02:00
Vladimir Chalupecky
516002632a testlapack/gonum: address PR comments 2019-08-01 12:05:23 +02:00
Vladimir Chalupecky
0803f6791e lapack/testlapack: add test for Dlatbs 2019-08-01 12:05:23 +02:00
Vladimir Chalupecky
1fb24f4bf7 lapack/testlapack: add dlattb helper 2019-08-01 12:05:23 +02:00
Vladimir Chalupecky
d7f6bfa9af lapack/testlapack: remove unused SymBand helpers 2019-06-17 12:52:28 +02:00
Vladimir Chalupecky
ce6986a678 lapack/testlapack: simplify randSymBand and use it in Dpb* tests 2019-06-17 12:52:28 +02:00
Vladimir Chalupecky
e307a7a43c lapack/testlapack: test Dpbtf2 like Dpbtrf 2019-06-17 12:52:28 +02:00
Vladimir Chalupecky
7895aa8c2a lapack/testlapack: add test for Dpbtrs 2019-06-17 12:52:28 +02:00
Vladimir Chalupecky
2bf3099108 lapack/testlapack: add test for Dpbtrf 2019-06-14 19:31:40 +02:00
Vladimir Chalupecky
7266ee9df4 lapack/gonum: add Dpbtrf 2019-06-14 19:31:40 +02:00
Vladimir Chalupecky
1ebd909faf lapack/testlapack: update implementation and docs of randSymBand helper 2019-06-14 19:31:40 +02:00
Dan Kortschak
3d26580ed4 lapack/testlapack: replace all literal constants in dgesvdTest with tol expressions 2019-04-01 06:30:53 +10:30
Dan Kortschak
a4ad4d254f all: run go fmt ./... 2019-03-31 13:31:35 +10:30
Dan Kortschak
6e8fec6a0c lapack/testlapack: make DgesvdTest take a tolerance parameter 2019-03-30 18:25:20 +10:30
Vladimir Chalupecky
7cc92e21e0 lapack/gonum: unify parameter checks 2019-02-28 12:40:53 +01:00
Vladimir Chalupecky
8ea67971a6 lapack/gonum: unify parameter checks 2019-02-21 14:28:55 +01:00
Vladimir Chalupecky
f3eaeb8407 lapack/gonum: unify parameter checks 2019-02-19 12:43:31 +01:00
Vladimir Chalupecky
70a1e933af lapack/gonum: unify parameter checks 2019-02-15 23:07:11 +01:00
Vladimir Chalupecky
dca16df666 lapack/gonum: fix bugs in Dgesvd and rewrite DgesvdTest
- if condition for one the paths in workspace size calculation was
  misspelled
- return value from Dbdsqr was ignored in some paths, leaving it at
  false (failed) value
- if the input matrix A was rescaled, the output singular values have
  to be unscaled back. The code uses Dlascl which treats the s slice as
  a matrix. The column major reference treats it as minmn-by-1 matrix
  with the stride minmn, and this was not correctly translated in our
  row major implementation.

Also clean up the initial parameter checks.
2019-01-28 10:32:12 +01:00
Vladimir Chalupecky
edc5a6c9aa lapack/testlapack: add svdJobString helper 2019-01-28 10:32:12 +01:00
Vladimir Chalupecky
e855e9fa8f lapack/testlapack: add hasOrthonormalRows helper 2019-01-28 10:32:12 +01:00
Vladimir Chalupecky
dd4cc715c5 lapack/gonum: fix ldwork in Dgeqrf and update its test 2019-01-23 12:32:41 +01:00
Vladimir Chalupecky
08a35caaad lapack/gonum: fix ldwork in Dgelqf and update its test 2019-01-23 12:32:41 +01:00
Vladimir Chalupecky
85a94c5204 lapack/testlapack: use worklen type in DgetriTest
... and make worklen type a Stringer.
2019-01-23 12:32:41 +01:00
Vladimir Chalupecky
0662aa10a9 lapack/gonum: fix workspace usage in Dgetri
... and extend its test which uncovered these bugs.
2019-01-22 14:25:03 +01:00
Vladimir Chalupecky
246a5a92a2 lapack/testlapack: use const tol in DlarfgTest 2019-01-19 00:28:03 +01:00