package/gonum
1
0
Fork 0
mirror of https://github.com/gonum/gonum.git synced 2025-10-04 23:02:42 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

lapack/{gonum,testlapack}: don't use work in Dlangb

Browse Source
This commit is contained in:
Vladimir Chalupecky
2021-05-07 11:57:25 +02:00
committed by Vladimír Chalupecký
parent d66e8d4b48
commit f0d77794af
3 changed files with 20 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lapack/testlapack/dlangb.go
View File

@@ -16,7 +16,7 @@ import (
)
type Dlangber interface {
Dlangb(norm lapack.MatrixNorm, m, n, kl, ku int, ab []float64, ldab int, work []float64) float64
Dlangb(norm lapack.MatrixNorm, m, n, kl, ku int, ab []float64, ldab int) float64
}
func DlangbTest(t *testing.T, impl Dlangber) {
@@ -28,9 +28,7 @@ func DlangbTest(t *testing.T, impl Dlangber) {
for _, kl := range []int{0, 1, 2, 3, 4, 5, 10} {
for _, ku := range []int{0, 1, 2, 3, 4, 5, 10} {
for _, ldab := range []int{kl + ku + 1, kl + ku + 1 + 7} {
for iter := 0; iter < 10; iter++ {
dlangbTest(t, impl, rnd, norm, m, n, kl, ku, ldab)
}
dlangbTest(t, impl, rnd, norm, m, n, kl, ku, ldab)
}
}
}
@@ -57,11 +55,11 @@ func dlangbTest(t *testing.T, impl Dlangber, rnd *rand.Rand, norm lapack.MatrixN
// Deal with zero-sized matrices early.
if m == 0 || n == 0 {
got := impl.Dlangb(norm, m, n, kl, ku, nil, ldab, nil)
got := impl.Dlangb(norm, m, n, kl, ku, nil, ldab)
if got != 0 {
t.Errorf("%v: unexpected result for zero-sized matrix with nil input", name)
}
got = impl.Dlangb(norm, m, n, kl, ku, ab, ldab, nil)
got = impl.Dlangb(norm, m, n, kl, ku, ab, ldab)
if !floats.Same(ab, abCopy) {
t.Errorf("%v: unexpected modification in dl", name)
}
@@ -71,11 +69,7 @@ func dlangbTest(t *testing.T, impl Dlangber, rnd *rand.Rand, norm lapack.MatrixN
return
}
var work []float64
if norm == lapack.MaxColumnSum {
work = make([]float64, n)
}
got := impl.Dlangb(norm, m, n, kl, ku, ab, ldab, work)
got := impl.Dlangb(norm, m, n, kl, ku, ab, ldab)
if !floats.Same(ab, abCopy) {
t.Errorf("%v: unexpected modification in ab", name)
@@ -97,6 +91,11 @@ func dlangbTest(t *testing.T, impl Dlangber, rnd *rand.Rand, norm lapack.MatrixN
return
}
if math.IsNaN(got) {
t.Errorf("%v: unexpected NaN; want %v", name, want)
return
}
if norm == lapack.MaxAbs {
if got != want {
t.Errorf("%v: unexpected result; got %v, want %v", name, got, want)