From ec45d4d55c932af7a82cbb5ca7d6056d999fbf36 Mon Sep 17 00:00:00 2001 From: Vladimir Chalupecky Date: Thu, 13 Feb 2020 09:01:46 +0100 Subject: [PATCH] testlapack: simplify isSchurCanonical --- lapack/testlapack/general.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lapack/testlapack/general.go b/lapack/testlapack/general.go index 97e1beb4..d90063d0 100644 --- a/lapack/testlapack/general.go +++ b/lapack/testlapack/general.go @@ -1158,13 +1158,7 @@ func extract2x2Block(t []float64, ldt int) (a, b, c, d float64) { // isSchurCanonical returns whether the 2×2 matrix [a b; c d] is in Schur // canonical form. func isSchurCanonical(a, b, c, d float64) bool { - if c == 0 { - return true - } - if b == 0 || a != d || math.Signbit(b) == math.Signbit(c) { - return false - } - return true + return c == 0 || (b != 0 && a == d && math.Signbit(b) != math.Signbit(c)) } // isSchurCanonicalGeneral returns whether T is block upper triangular with 1×1