package/gonum
1
0
Fork 0
mirror of https://github.com/gonum/gonum.git synced 2025-10-05 15:16:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

testlapack: remove unused equalApprox helper

Browse Source
This commit is contained in:
Vladimir Chalupecky
2020-02-22 22:23:36 +01:00
committed by Vladimír Chalupecký
parent 459cb8bec3
commit de969dc2da
2 changed files with 8 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lapack/testlapack/dlauu2.go
View File

@@ -12,6 +12,7 @@ import (
"gonum.org/v1/gonum/blas" "gonum.org/v1/gonum/blas"
"gonum.org/v1/gonum/blas/blas64" "gonum.org/v1/gonum/blas/blas64"
"gonum.org/v1/gonum/lapack"
) )
type Dlauu2er interface { type Dlauu2er interface {
@@ -87,24 +88,24 @@ func dlauuTest(t *testing.T, dlauu func(blas.Uplo, int, []float64, int), uplo bl
// Compute U*Uᵀ or Lᵀ*L using Dgemm with U and L // Compute U*Uᵀ or Lᵀ*L using Dgemm with U and L
// represented as dense triangular matrices. // represented as dense triangular matrices.
ldwant := n r := cloneGeneral(blas64.General{Rows: n, Cols: n, Data: a, Stride: lda})
want := make([]float64, n*ldwant)
if uplo == blas.Upper { if uplo == blas.Upper {
// Use aCopy as a dense representation of the upper triangular U. // Use aCopy as a dense representation of the upper triangular U.
u := aCopy u := aCopy
ldu := lda ldu := lda
// Compute U * Uᵀ and store the result into want. // Compute U*Uᵀ - A and store the result into R.
bi.Dgemm(blas.NoTrans, blas.Trans, n, n, n, bi.Dgemm(blas.NoTrans, blas.Trans, n, n, n,
1, u, ldu, u, ldu, 0, want, ldwant) 1, u, ldu, u, ldu, -1, r.Data, r.Stride)
} else { } else {
// Use aCopy as a dense representation of the lower triangular L. // Use aCopy as a dense representation of the lower triangular L.
l := aCopy l := aCopy
ldl := lda ldl := lda
// Compute Lᵀ * L and store the result into want. // Compute Lᵀ*L - A and store the result into R.
bi.Dgemm(blas.Trans, blas.NoTrans, n, n, n, bi.Dgemm(blas.Trans, blas.NoTrans, n, n, n,
1, l, ldl, l, ldl, 0, want, ldwant) 1, l, ldl, l, ldl, -1, r.Data, r.Stride)
} }
if !equalApprox(n, n, a, lda, want, tol) { resid := dlange(lapack.MaxColumnSum, r.Rows, r.Cols, r.Data, r.Stride)
if resid > tol*float64(n) {
t.Errorf("%v: unexpected result", prefix) t.Errorf("%v: unexpected result", prefix)
} }
} }

14
lapack/testlapack/general.go
View File

@@ -877,20 +877,6 @@ func cloneGeneral(a blas64.General) blas64.General {
return c return c
} }
// equalApprox returns whether the matrices A and B of order n are approximately
// equal within given tolerance.
func equalApprox(m, n int, a []float64, lda int, b []float64, tol float64) bool {
for i := 0; i < m; i++ {
for j := 0; j < n; j++ {
diff := a[i*lda+j] - b[i*n+j]
if math.IsNaN(diff) || math.Abs(diff) > tol {
return false
}
}
}
return true
}
// equalGeneral returns whether the general matrices a and b are equal. // equalGeneral returns whether the general matrices a and b are equal.
func equalGeneral(a, b blas64.General) bool { func equalGeneral(a, b blas64.General) bool {
if a.Rows != b.Rows || a.Cols != b.Cols { if a.Rows != b.Rows || a.Cols != b.Cols {