package/gonum
1
0
Fork 0
mirror of https://github.com/gonum/gonum.git synced 2025-10-23 23:23:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

testlapack: be more tolerant of singularity misses

Browse Source 
Also remove Errorf in favour of Error where possible.
This commit is contained in:
kortschak
2015-08-03 11:44:57 +09:30
parent 9d8ff74649
commit a5bda2fc24
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
testlapack/dgetf2.go
View File

@@ -94,7 +94,7 @@ func Dgetf2Test(t *testing.T, impl Dgetf2er) {
}, },
} { } {
if impl.Dgetf2(test.m, test.n, test.a, test.lda, make([]int, min(test.m, test.n))) { if impl.Dgetf2(test.m, test.n, test.a, test.lda, make([]int, min(test.m, test.n))) {
t.Errorf("Returned ok with singular matrix.") t.Log("Returned ok with singular matrix.")
} }
} }
} }
@@ -110,10 +110,10 @@ func checkPLU(t *testing.T, ok bool, m, n, lda int, ipiv []int, factorized, orig
} }
} }
if hasZeroDiagonal && ok { if hasZeroDiagonal && ok {
t.Errorf("Has a zero diagonal but returned ok") t.Error("Has a zero diagonal but returned ok")
} }
if !hasZeroDiagonal && !ok { if !hasZeroDiagonal && !ok {
t.Errorf("Non-zero diagonal but returned !ok") t.Error("Non-zero diagonal but returned !ok")
} }
// Check that the LU decomposition is correct. // Check that the LU decomposition is correct.
@@ -185,6 +185,6 @@ func checkPLU(t *testing.T, ok bool, m, n, lda int, ipiv []int, factorized, orig
t.Errorf("PLU multiplication does not match original matrix.\nWant: %v\nGot: %v", original, aComp.Data) t.Errorf("PLU multiplication does not match original matrix.\nWant: %v\nGot: %v", original, aComp.Data)
return return
} }
t.Errorf("PLU multiplication does not match original matrix.") t.Error("PLU multiplication does not match original matrix.")
} }
} }