From 97c20388865250a1a54d18ac180d1469951c7428 Mon Sep 17 00:00:00 2001
From: Dan Kortschak <dan@kortschak.io>
Date: Tue, 26 Feb 2019 11:49:37 +1030
Subject: [PATCH] num: replace bytes.Buffer with strings.Builder for format
 construction

---
 num/dual/dual.go           | 6 ++----
 num/dualquat/dual.go       | 6 ++----
 num/hyperdual/hyperdual.go | 6 ++----
 num/quat/quat.go           | 5 +----
 4 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/num/dual/dual.go b/num/dual/dual.go
index 62f3644a..a4a2348a 100644
--- a/num/dual/dual.go
+++ b/num/dual/dual.go
@@ -5,9 +5,9 @@
 package dual
 
 import (
-	"bytes"
 	"fmt"
 	"math"
+	"strings"
 )
 
 // Number is a float64 precision dual number.
@@ -52,9 +52,7 @@ func (d Number) Format(fs fmt.State, c rune) {
 
 // This is horrible, but it's what we have.
 func fmtString(fs fmt.State, c rune, prec, width int, wantPlus bool) string {
-	// TODO(kortschak) Replace this with strings.Builder
-	// when go1.9 support is dropped from Gonum.
-	var b bytes.Buffer
+	var b strings.Builder
 	b.WriteByte('%')
 	for _, f := range "0+- " {
 		if fs.Flag(int(f)) || (f == '+' && wantPlus) {
diff --git a/num/dualquat/dual.go b/num/dualquat/dual.go
index 33c8dcbb..1e895f4c 100644
--- a/num/dualquat/dual.go
+++ b/num/dualquat/dual.go
@@ -5,8 +5,8 @@
 package dualquat
 
 import (
-	"bytes"
 	"fmt"
+	"strings"
 
 	"gonum.org/v1/gonum/num/dual"
 	"gonum.org/v1/gonum/num/quat"
@@ -59,9 +59,7 @@ func (d Number) Format(fs fmt.State, c rune) {
 
 // This is horrible, but it's what we have.
 func fmtString(fs fmt.State, c rune, prec, width int, wantPlus bool) string {
-	// TODO(kortschak) Replace this with strings.Builder
-	// when go1.9 support is dropped from Gonum.
-	var b bytes.Buffer
+	var b strings.Builder
 	b.WriteByte('%')
 	for _, f := range "0+- " {
 		if fs.Flag(int(f)) || (f == '+' && wantPlus) {
diff --git a/num/hyperdual/hyperdual.go b/num/hyperdual/hyperdual.go
index fd79e959..2fb7a67f 100644
--- a/num/hyperdual/hyperdual.go
+++ b/num/hyperdual/hyperdual.go
@@ -5,9 +5,9 @@
 package hyperdual
 
 import (
-	"bytes"
 	"fmt"
 	"math"
+	"strings"
 )
 
 // Number is a float64 precision hyperdual number.
@@ -55,9 +55,7 @@ func (d Number) Format(fs fmt.State, c rune) {
 
 // This is horrible, but it's what we have.
 func fmtString(fs fmt.State, c rune, prec, width int, wantPlus bool) string {
-	// TODO(kortschak) Replace this with strings.Builder
-	// when go1.9 support is dropped from Gonum.
-	var b bytes.Buffer
+	var b strings.Builder
 	b.WriteByte('%')
 	for _, f := range "0+- " {
 		if fs.Flag(int(f)) || (f == '+' && wantPlus) {
diff --git a/num/quat/quat.go b/num/quat/quat.go
index c54ee990..f78176d9 100644
--- a/num/quat/quat.go
+++ b/num/quat/quat.go
@@ -5,7 +5,6 @@
 package quat
 
 import (
-	"bytes"
 	"fmt"
 	"strconv"
 	"strings"
@@ -53,9 +52,7 @@ func (q Number) Format(fs fmt.State, c rune) {
 
 // This is horrible, but it's what we have.
 func fmtString(fs fmt.State, c rune, prec, width int, wantPlus bool) string {
-	// TODO(kortschak) Replace this with strings.Builder
-	// when go1.9 support is dropped from Gonum.
-	var b bytes.Buffer
+	var b strings.Builder
 	b.WriteByte('%')
 	for _, f := range "0+- " {
 		if fs.Flag(int(f)) || (f == '+' && wantPlus) {