package/gonum
1
0
Fork 0
mirror of https://github.com/gonum/gonum.git synced 2025-10-08 00:20:11 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

graph/iterator: extend iteration tests and fix counting error

Browse Source
This commit is contained in:
Dan Kortschak
2020-06-07 08:03:22 +09:30
parent 16da37cc66
commit 2db33926ac
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
graph/iterator/nodes.go
View File

@@ -24,10 +24,7 @@ func (n *OrderedNodes) Len() int {
if n.idx >= len(n.nodes) { if n.idx >= len(n.nodes) {
return 0 return 0
} }
if n.idx <= 0 { return len(n.nodes[n.idx+1:])
return len(n.nodes)
}
return len(n.nodes[n.idx:])
} }
// Next returns whether the next call of Node will return a valid node. // Next returns whether the next call of Node will return a valid node.

6
graph/iterator/nodes_test.go
View File

@@ -34,6 +34,9 @@ func TestOrderedNodesIterate(t *testing.T) {
var got []graph.Node var got []graph.Node
for it.Next() { for it.Next() {
got = append(got, it.Node()) got = append(got, it.Node())
if len(got)+it.Len() != len(test.nodes) {
t.Errorf("unexpected iterator length during iteration for round %d: got:%d want:%d", i, it.Len(), len(test.nodes)-len(got))
}
} }
want := test.nodes want := test.nodes
if !reflect.DeepEqual(got, want) { if !reflect.DeepEqual(got, want) {
@@ -91,6 +94,9 @@ func TestImplicitNodesIterate(t *testing.T) {
var got []graph.Node var got []graph.Node
for it.Next() { for it.Next() {
got = append(got, it.Node()) got = append(got, it.Node())
if len(got)+it.Len() != test.end-test.beg {
t.Errorf("unexpected iterator length during iteration for round %d: got:%d want:%d", i, it.Len(), (test.end-test.beg)-len(got))
}
} }
if !reflect.DeepEqual(got, test.want) { if !reflect.DeepEqual(got, test.want) {
t.Errorf("unexpected iterator output for round %d: got:%#v want:%#v", i, got, test.want) t.Errorf("unexpected iterator output for round %d: got:%#v want:%#v", i, got, test.want)