Refactored frame/packet side data + added regions of interest to frame side data

packet_side_data_test.go

@@ -6,11 +6,39 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func testPacketSideData(sd *PacketSideData, t *testing.T) {
+	m1 := NewDisplayMatrixFromRotation(90)
+	require.NoError(t, sd.DisplayMatrix().Add(m1))
+	m2, err := sd.DisplayMatrix().Get()
+	require.NoError(t, err)
+	require.Equal(t, m1.Rotation(), m2.Rotation())
+}
+
 func TestPacketSideData(t *testing.T) {
 	cp := AllocCodecParameters()
 	defer cp.Free()
-	b := []byte("test")
 	sd := cp.SideData()
-	require.NoError(t, sd.Add(PacketSideDataTypeDisplaymatrix, b))
-	require.Equal(t, b, sd.Get(PacketSideDataTypeDisplaymatrix))
+
+	m1, err := sd.DisplayMatrix().Get()
+	require.NoError(t, err)
+	require.Nil(t, m1)
+	m1 = NewDisplayMatrixFromRotation(90)
+	require.NoError(t, sd.DisplayMatrix().Add(m1))
+	m2, err := sd.DisplayMatrix().Get()
+	require.NoError(t, err)
+	require.Equal(t, m1.Rotation(), m2.Rotation())
+
+	ss1, err := sd.SkipSamples().Get()
+	require.NoError(t, err)
+	require.Nil(t, ss1)
+	ss1 = &SkipSamples{
+		ReasonEnd:   1,
+		ReasonStart: 2,
+		SkipEnd:     3,
+		SkipStart:   4,
+	}
+	require.NoError(t, sd.SkipSamples().Add(ss1))
+	ss2, err := sd.SkipSamples().Get()
+	require.NoError(t, err)
+	require.Equal(t, ss1, ss2)
 }