Merge pull request #180 from peters/master

.NET binding gardening

src/bindings/csharp/openalpr-net/bitmapmat-net.cpp

@@ -5,23 +5,37 @@ using namespace openalprnet;
 
 BitmapMat::BitmapMat(array<Byte>^ byteArray)
 {
-	this->m_bitmap = ByteArrayToMat(byteArray);
+	m_bitmap = new cv::Mat();
+	std::vector<char> buffer = AlprHelper::ToVector(byteArray);
+	cv::imdecode(buffer, CV_LOAD_IMAGE_COLOR, this->m_bitmap);
 }
 
 BitmapMat::BitmapMat(Bitmap^ bitmap)
 {
-	this->m_bitmap = BitmapToMat(bitmap);
+	m_bitmap = new cv::Mat();
+
+	MemoryStream^ ms = gcnew MemoryStream();
+	bitmap->Save(ms, ImageFormat::Png);
+
+	std::vector<char> buffer = AlprHelper::ToVector(ms->ToArray());
+	cv::imdecode(buffer, CV_LOAD_IMAGE_COLOR, this->m_bitmap);
+
+	delete ms;
 }
 
 BitmapMat::BitmapMat(MemoryStream^ memoryStream)
 {
-	this->m_bitmap = MemoryStreamBitmapToMat(memoryStream);
+	m_bitmap = new cv::Mat();
+	std::vector<char> buffer = AlprHelper::ToVector(memoryStream->ToArray());
+	cv::imdecode(buffer, CV_LOAD_IMAGE_COLOR, this->m_bitmap);
 }
 
 BitmapMat::BitmapMat(String^ filename)
 {
-	Bitmap^ bitmap = gcnew Bitmap(filename);
+	m_bitmap = new cv::Mat();
-	this->m_bitmap = BitmapToMat(bitmap);
+	array<Byte>^ byteArray = File::ReadAllBytes(filename);
-	delete bitmap;
+	std::vector<char> buffer = AlprHelper::ToVector(byteArray);
+	cv::imdecode(buffer, CV_LOAD_IMAGE_COLOR, this->m_bitmap);
+	delete byteArray;
 }
 

src/bindings/csharp/openalpr-net/bitmapmat-net.h

@@ -1,6 +1,9 @@
 #pragma once
 
-#include "opencv2/imgproc/imgproc.hpp"
+#include <opencv2/imgproc/imgproc.hpp>
+#include <opencv2/highgui/highgui.hpp>
+
+#include "helper-net.h"
 
 using namespace System;
 using namespace System::Drawing;
@@ -33,74 +36,16 @@ namespace openalprnet {
 
 		!BitmapMat()
 		{
-			delete[] m_bitmap->data;
+			m_bitmap->release();
+			delete m_bitmap;
 		}
 
 		property cv::Mat Value {
 			cv::Mat get()
 			{
-				cv::Mat value = this->m_bitmap->clone();
+				return *m_bitmap;
-				return value;
 			}
 		}
 
-	private:
-
-		static cv::Mat* BitmapToMat(Bitmap^ bitmap)
-		{
-			int channels = 0;
-
-			switch (bitmap->PixelFormat)
-			{
-			case PixelFormat::Format8bppIndexed:
-			case PixelFormat::Format1bppIndexed:
-				channels = 1;
-				break;
-			case PixelFormat::Format24bppRgb:
-				channels = 3;
-				break;
-			case PixelFormat::Format32bppRgb:
-			case PixelFormat::Format32bppArgb:
-			case PixelFormat::Format32bppPArgb:
-				channels = 4;
-				break;
-			default:
-				throw gcnew NotSupportedException(bitmap->PixelFormat.ToString());
-			}
-
-			BitmapData^ bitmapData = bitmap->LockBits(
-				System::Drawing::Rectangle(0, 0, bitmap->Width, bitmap->Height),
-				ImageLockMode::ReadOnly,
-				bitmap->PixelFormat
-				);
-
-			const int totalBytes = bitmap->Height * bitmapData->Stride;
-
-			char *dst = new char[totalBytes];
-			::memcpy(dst, bitmapData->Scan0.ToPointer(), totalBytes);
-
-			cv::Mat* dstMat = new cv::Mat(cv::Size(bitmap->Width, bitmap->Height), CV_8UC(channels), dst);
-
-			bitmap->UnlockBits(bitmapData);
-
-			return dstMat;
-		}
-
-		static cv::Mat* MemoryStreamBitmapToMat(MemoryStream^ memoryStream)
-		{
-			Bitmap^ bitmap = gcnew Bitmap(memoryStream);
-			cv::Mat* mat = BitmapToMat(bitmap);
-			delete bitmap;
-			return mat;
-		}
-
-		static cv::Mat* ByteArrayToMat(array<Byte>^ byteArray)
-		{
-			MemoryStream^ ms = gcnew MemoryStream(byteArray);
-			cv::Mat* mat = MemoryStreamBitmapToMat(ms);
-			delete ms;
-			return mat;
-		}
-
 	};
 }

src/bindings/csharp/openalpr-net/motiondetector-net.cpp

@@ -14,23 +14,20 @@ void AlprMotionDetectionNet::ResetMotionDetection(Bitmap^ bitmap)
 
 void AlprMotionDetectionNet::ResetMotionDetection(String^ filename)
 {
-	BitmapMat^ wrapper = gcnew BitmapMat(filename);
+	cv::Mat mat = cv::imread(marshal_as<std::string>(filename));
-	ResetMotionDetection(wrapper->Value);
+	ResetMotionDetection(mat);
-	delete wrapper;
 }
 
 void AlprMotionDetectionNet::ResetMotionDetection(MemoryStream^ memoryStream)
 {
-	BitmapMat^ wrapper = gcnew BitmapMat(memoryStream);
+	return ResetMotionDetection(memoryStream->ToArray());
-	ResetMotionDetection(wrapper->Value);
-	delete wrapper;
 }
 
 void AlprMotionDetectionNet::ResetMotionDetection(array<Byte>^ byteArray)
 {
-	BitmapMat^ wrapper = gcnew BitmapMat(byteArray);
+	std::vector<char> buffer = AlprHelper::ToVector(byteArray);
-	ResetMotionDetection(wrapper->Value);
+	cv::Mat mat = cv::imdecode(buffer, CV_LOAD_IMAGE_COLOR);
-	delete wrapper;
+	ResetMotionDetection(mat);
 }
 
 System::Drawing::Rectangle AlprMotionDetectionNet::MotionDetect(Bitmap^ bitmap)
@@ -43,26 +40,21 @@ System::Drawing::Rectangle AlprMotionDetectionNet::MotionDetect(Bitmap^ bitmap)
 
 System::Drawing::Rectangle AlprMotionDetectionNet::MotionDetect(String^ filename)
 {
-	BitmapMat^ wrapper = gcnew BitmapMat(filename);
+	cv::Mat mat = cv::imread(marshal_as<std::string>(filename));
-	System::Drawing::Rectangle motion = MotionDetect(wrapper->Value);
+	System::Drawing::Rectangle motion = MotionDetect(mat);
-	delete wrapper;
 	return motion;
 }
 
 System::Drawing::Rectangle AlprMotionDetectionNet::MotionDetect(MemoryStream^ memoryStream)
 {
-	BitmapMat^ wrapper = gcnew BitmapMat(memoryStream);
+	return MotionDetect(memoryStream->ToArray());
-	System::Drawing::Rectangle motion = MotionDetect(wrapper->Value);
-	delete wrapper;
-	return motion;
 }
 
 System::Drawing::Rectangle AlprMotionDetectionNet::MotionDetect(array<Byte>^ byteArray)
 {
-	BitmapMat^ wrapper = gcnew BitmapMat(byteArray);
+	std::vector<char> buffer = AlprHelper::ToVector(byteArray);
-	System::Drawing::Rectangle motion = MotionDetect(wrapper->Value);
+	cv::Mat mat = cv::imdecode(buffer, CV_LOAD_IMAGE_COLOR);
-	delete wrapper;
+	return MotionDetect(mat);
-	return motion;
 }
 
 void AlprMotionDetectionNet::ResetMotionDetection(cv::Mat mat)

src/bindings/csharp/openalpr-net/openalpr-net.cpp

@@ -361,8 +361,7 @@ namespace openalprnet {
 		/// Recognize from an image on disk
 		/// </summary>
 		AlprResultsNet^ Recognize(System::String^ filepath) {
-			AlprResults results = m_Impl->recognize(marshal_as<std::string>(filepath));
+			return Recognize(filepath, gcnew List<System::Drawing::Rectangle>());
-			return gcnew AlprResultsNet(results);
 		}
 
 		/// <summary>
@@ -419,7 +418,7 @@ namespace openalprnet {
 		/// Recognize from byte data representing an encoded image (e.g., BMP, PNG, JPG, GIF etc).
 		/// </summary>
 		/// <param name="imageBuffer">Bytes representing image data</param>
-		AlprResultsNet^ Recognize(cli::array<Byte>^ imageBuffer) {
+		AlprResultsNet^ Recognize(array<Byte>^ imageBuffer) {
 			return Recognize(imageBuffer, gcnew List<System::Drawing::Rectangle>());
 		}
 
@@ -427,7 +426,7 @@ namespace openalprnet {
 		/// Recognize from byte data representing an encoded image (e.g., BMP, PNG, JPG, GIF etc).
 		/// </summary>
 		/// <param name="imageBuffer">Bytes representing image data</param>
-		AlprResultsNet^ Recognize(cli::array<Byte>^ imageBuffer, List<System::Drawing::Rectangle>^ regionsOfInterest) {
+		AlprResultsNet^ Recognize(array<Byte>^ imageBuffer, List<System::Drawing::Rectangle>^ regionsOfInterest) {
 			std::vector<char> buffer = AlprHelper::ToVector(imageBuffer);
 			std::vector<AlprRegionOfInterest> rois = AlprHelper::ToVector(regionsOfInterest);
 			AlprResults results = m_Impl->recognize(buffer, rois);
@@ -437,14 +436,14 @@ namespace openalprnet {
 		/// <summary>
 		/// Recognize from raw pixel data
 		/// </summary>
-		AlprResultsNet^ Recognize(cli::array<Byte>^ imageBuffer, int bytesPerPixel, int imgWidth, int imgHeight) {
+		AlprResultsNet^ Recognize(array<Byte>^ imageBuffer, int bytesPerPixel, int imgWidth, int imgHeight) {
 			return Recognize(imageBuffer, bytesPerPixel, imgWidth, imgHeight, gcnew List<System::Drawing::Rectangle>());
 		}
 
 		/// <summary>
 		/// Recognize from raw pixel data
 		/// </summary>
-		AlprResultsNet^ Recognize(cli::array<Byte>^ imageBuffer, int bytesPerPixel, int imgWidth, int imgHeight, List<System::Drawing::Rectangle>^ regionsOfInterest) {
+		AlprResultsNet^ Recognize(array<Byte>^ imageBuffer, int bytesPerPixel, int imgWidth, int imgHeight, List<System::Drawing::Rectangle>^ regionsOfInterest) {
 			unsigned char* p = AlprHelper::ToCharPtr(imageBuffer);
 			std::vector<AlprRegionOfInterest> rois = AlprHelper::ToVector(regionsOfInterest);
 			AlprResults results = m_Impl->recognize(p, bytesPerPixel, imgWidth, imgHeight, rois);
@@ -458,7 +457,7 @@ namespace openalprnet {
 		array<Byte>^ PreWarp(array<Byte>^ imageBuffer)
 		{
 			std::vector<char> buffer = AlprHelper::ToVector(imageBuffer);
-			cv::Mat src = cv::imdecode(buffer, 1);
+			cv::Mat src = cv::imdecode(buffer, CV_LOAD_IMAGE_COLOR);
 
 			alpr::PreWarp *preWarp = new alpr::PreWarp(m_Impl->getConfig());
 			cv::Mat warpedImage = preWarp->warpImage(src);