From 426d863f90425aa2c1856acc621d7a469358d0b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bryon=20Gloden=2C=20CISSP=C2=AE?= Date: Tue, 19 Jul 2016 16:31:15 -0400 Subject: [PATCH 1/2] Update daemon.cpp [../openalpr-master/src/daemon.cpp:213]: (error) Memory leak: thread_upload [../openalpr-master/src/daemon.cpp:216]: (error) Memory leak: thread_recognize Found by https://github.com/bryongloden/cppcheck --- src/daemon.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/daemon.cpp b/src/daemon.cpp index 41c2970..f96a695 100644 --- a/src/daemon.cpp +++ b/src/daemon.cpp @@ -211,10 +211,10 @@ int main( int argc, const char** argv ) udata->upload_url = daemon_config.upload_url; tthread::thread* thread_upload = new tthread::thread(dataUploadThread, (void*) udata ); } - + delete(thread_upload); break; } - + delete(thread_recognize); // Parent process will continue and spawn more children } From 2631c14c081fd8a7532ae0c77c23ca76c970c35e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bryon=20Gloden=2C=20CISSP=C2=AE?= Date: Thu, 21 Jul 2016 14:08:35 -0400 Subject: [PATCH 2/2] Update daemon.cpp Sorry @matthill ! Although I made that change in https://github.com/openalpr/openalpr/pull/382 , I didn't test the library locally. This new fix is building, and it is working when I test the library using: wget http://i.imgur.com/pjukRD0.jpg -O lp.jpg alpr lp.jpg --- src/daemon.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/daemon.cpp b/src/daemon.cpp index f96a695..1703eea 100644 --- a/src/daemon.cpp +++ b/src/daemon.cpp @@ -210,11 +210,11 @@ int main( int argc, const char** argv ) UploadThreadData* udata = new UploadThreadData(); udata->upload_url = daemon_config.upload_url; tthread::thread* thread_upload = new tthread::thread(dataUploadThread, (void*) udata ); + delete(thread_upload); } - delete(thread_upload); + delete(thread_recognize); break; } - delete(thread_recognize); // Parent process will continue and spawn more children }