mirror of
https://github.com/nalgeon/redka.git
synced 2025-10-05 07:56:49 +08:00
refactor: command - better encapsulation and simpler tests
This commit is contained in:
@@ -1,74 +1,73 @@
|
||||
package string_test
|
||||
package string
|
||||
|
||||
import (
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/nalgeon/redka/internal/command"
|
||||
str "github.com/nalgeon/redka/internal/command/string"
|
||||
"github.com/nalgeon/redka/internal/redis"
|
||||
"github.com/nalgeon/redka/internal/testx"
|
||||
)
|
||||
|
||||
func TestSetEXParse(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
args [][]byte
|
||||
want str.SetEX
|
||||
cmd string
|
||||
want SetEX
|
||||
err error
|
||||
}{
|
||||
{
|
||||
name: "setex",
|
||||
args: command.BuildArgs("setex"),
|
||||
want: str.SetEX{},
|
||||
cmd: "setex",
|
||||
want: SetEX{},
|
||||
err: redis.ErrInvalidArgNum,
|
||||
},
|
||||
{
|
||||
name: "setex name",
|
||||
args: command.BuildArgs("setex", "name"),
|
||||
want: str.SetEX{},
|
||||
cmd: "setex name",
|
||||
want: SetEX{},
|
||||
err: redis.ErrInvalidArgNum,
|
||||
},
|
||||
{
|
||||
name: "setex name alice",
|
||||
args: command.BuildArgs("setex", "name", "alice"),
|
||||
want: str.SetEX{},
|
||||
cmd: "setex name alice",
|
||||
want: SetEX{},
|
||||
err: redis.ErrInvalidArgNum,
|
||||
},
|
||||
{
|
||||
name: "setex name alice 60",
|
||||
args: command.BuildArgs("setex", "name", "alice", "60"),
|
||||
want: str.SetEX{},
|
||||
cmd: "setex name alice 60",
|
||||
want: SetEX{},
|
||||
err: redis.ErrInvalidInt,
|
||||
},
|
||||
{
|
||||
name: "setex name 60 alice",
|
||||
args: command.BuildArgs("setex", "name", "60", "alice"),
|
||||
want: str.SetEX{Key: "name", Value: []byte("alice"), TTL: 60 * 1000 * time.Millisecond},
|
||||
cmd: "setex name 60 alice",
|
||||
want: SetEX{key: "name", value: []byte("alice"), ttl: 60 * 1000 * time.Millisecond},
|
||||
err: nil,
|
||||
},
|
||||
}
|
||||
|
||||
parse := func(b redis.BaseCmd) (*SetEX, error) {
|
||||
return ParseSetEX(b, 1000)
|
||||
}
|
||||
|
||||
for _, test := range tests {
|
||||
t.Run(test.name, func(t *testing.T) {
|
||||
cmd, err := command.Parse(test.args)
|
||||
t.Run(test.cmd, func(t *testing.T) {
|
||||
cmd, err := redis.Parse(parse, test.cmd)
|
||||
testx.AssertEqual(t, err, test.err)
|
||||
if err == nil {
|
||||
cm := cmd.(*str.SetEX)
|
||||
testx.AssertEqual(t, cm.Key, test.want.Key)
|
||||
testx.AssertEqual(t, cm.Value, test.want.Value)
|
||||
testx.AssertEqual(t, cm.TTL, test.want.TTL)
|
||||
testx.AssertEqual(t, cmd.key, test.want.key)
|
||||
testx.AssertEqual(t, cmd.value, test.want.value)
|
||||
testx.AssertEqual(t, cmd.ttl, test.want.ttl)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestSetEXExec(t *testing.T) {
|
||||
parse := func(b redis.BaseCmd) (*SetEX, error) {
|
||||
return ParseSetEX(b, 1000)
|
||||
}
|
||||
|
||||
t.Run("create", func(t *testing.T) {
|
||||
db, red := getDB(t)
|
||||
defer db.Close()
|
||||
|
||||
cmd := command.MustParse[*str.SetEX]("setex name 60 alice")
|
||||
cmd := redis.MustParse(parse, "setex name 60 alice")
|
||||
conn := redis.NewFakeConn()
|
||||
res, err := cmd.Run(conn, red)
|
||||
testx.AssertNoErr(t, err)
|
||||
@@ -89,7 +88,7 @@ func TestSetEXExec(t *testing.T) {
|
||||
|
||||
_ = db.Str().Set("name", "alice")
|
||||
|
||||
cmd := command.MustParse[*str.SetEX]("setex name 60 bob")
|
||||
cmd := redis.MustParse(parse, "setex name 60 bob")
|
||||
conn := redis.NewFakeConn()
|
||||
res, err := cmd.Run(conn, red)
|
||||
testx.AssertNoErr(t, err)
|
||||
@@ -110,7 +109,7 @@ func TestSetEXExec(t *testing.T) {
|
||||
|
||||
_ = db.Str().SetExpires("name", "alice", 60*time.Second)
|
||||
|
||||
cmd := command.MustParse[*str.SetEX]("setex name 10 bob")
|
||||
cmd := redis.MustParse(parse, "setex name 10 bob")
|
||||
conn := redis.NewFakeConn()
|
||||
res, err := cmd.Run(conn, red)
|
||||
testx.AssertNoErr(t, err)
|
||||
|
Reference in New Issue
Block a user