diff --git a/.github/workflows/coverall.yml b/.github/workflows/coverall.yml index 558e635..bee2d16 100644 --- a/.github/workflows/coverall.yml +++ b/.github/workflows/coverall.yml @@ -23,9 +23,9 @@ jobs: redis version: '5' number of databases: 16 - - uses: actions/setup-go@v3 + - uses: actions/setup-go@v5 with: - go-version: '1.19' + go-version: '1.23' - run: go test -v -coverprofile=profile.cov ./... - uses: shogo82148/actions-goveralls@v1 diff --git a/redis/server/gnet/server_test.go b/redis/server/gnet/server_test.go index 0a9b246..fb33a2f 100644 --- a/redis/server/gnet/server_test.go +++ b/redis/server/gnet/server_test.go @@ -4,6 +4,7 @@ import ( "bufio" "net" "testing" + "time" "github.com/hdt3213/godis/database" ) @@ -19,7 +20,7 @@ func TestListenAndServe(t *testing.T) { db := database.NewStandaloneServer() server := NewGnetServer(db) go server.Run(addr) - + time.Sleep(2*time.Second) conn, err := net.Dial("tcp", addr) if err != nil { t.Error(err) diff --git a/tcp/echo.go b/tcp/echo.go index aa69532..cfa2988 100644 --- a/tcp/echo.go +++ b/tcp/echo.go @@ -59,7 +59,7 @@ func (h *EchoHandler) Handle(ctx context.Context, conn net.Conn) { msg, err := reader.ReadString('\n') if err != nil { if err == io.EOF { - logger.Info("connection close") + // logger.Info("connection close") h.activeConn.Delete(client) } else { logger.Warn(err) diff --git a/tcp/server.go b/tcp/server.go index b74de25..e5b699b 100644 --- a/tcp/server.go +++ b/tcp/server.go @@ -83,7 +83,7 @@ func ListenAndServe(listener net.Listener, handler tcp.Handler, closeChan <-chan break } // handle - logger.Info("accept link") + // logger.Info("accept link") ClientCounter++ waitDone.Add(1) go func() {