apps/redis-go
0
0
Fork 0
mirror of https://github.com/HDT3213/godis.git synced 2025-11-03 00:54:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

bugfix: Use rounding to calculate TTL

Browse Source 
The previous code calculated TTL directly by int64 / time.Second or int64 / time.Millisecond, which could result in a calculation error of up to 1s/1ms. Now, using math.Round ensures that TTL is rounded to the nearest whole second/millisecond, improving the accuracy of the calculation.
This commit is contained in:
xuning
2024-03-24 19:18:39 +08:00
committed by finley
parent b7b8ece442
commit b6763a86fe
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
database/keys.go
View File

@@ -10,6 +10,7 @@ import (
"github.com/hdt3213/godis/lib/utils"
"github.com/hdt3213/godis/lib/wildcard"
"github.com/hdt3213/godis/redis/protocol"
"math"
"strconv"
"strings"
"time"
@@ -274,8 +275,8 @@ func execTTL(db *DB, args [][]byte) redis.Reply {
return protocol.MakeIntReply(-1)
}
expireTime, _ := raw.(time.Time)
ttl := expireTime.Sub(time.Now())
return protocol.MakeIntReply(int64(ttl / time.Second))
ttl := expireTime.Sub(time.Now()).Seconds()
return protocol.MakeIntReply(int64(math.Round(ttl)))
}
// execPTTL returns a key's time to live in milliseconds
@@ -291,8 +292,8 @@ func execPTTL(db *DB, args [][]byte) redis.Reply {
return protocol.MakeIntReply(-1)
}
expireTime, _ := raw.(time.Time)
ttl := expireTime.Sub(time.Now())
return protocol.MakeIntReply(int64(ttl / time.Millisecond))
ttl := expireTime.Sub(time.Now()).Milliseconds()
return protocol.MakeIntReply(int64(math.Round(float64(ttl))))
}
// execPersist removes expiration from a key