apps/redis-go
0
0
Fork 0
mirror of https://github.com/HDT3213/godis.git synced 2025-10-24 09:13:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: fine-tune the coding of lib/logger/

Browse Source 
Limited ability, hope to make it better~
This commit is contained in:
zhengtianyi
2022-10-24 13:37:27 +08:00
committed by finley
parent 9af52bc419
commit 4107c49abf
2 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lib/logger/files.go
View File

@@ -16,31 +16,24 @@ func checkPermission(src string) bool {
} }
func isNotExistMkDir(src string) error { func isNotExistMkDir(src string) error {
if notExist := checkNotExist(src); notExist == true { notExist := checkNotExist(src)
if err := mkDir(src); err != nil { if notExist {
return err return mkDir(src)
}
} }
return nil return nil
} }
func mkDir(src string) error { func mkDir(src string) error {
err := os.MkdirAll(src, os.ModePerm) return os.MkdirAll(src, os.ModePerm)
if err != nil {
return err
}
return nil
} }
func mustOpen(fileName, dir string) (*os.File, error) { func mustOpen(fileName, dir string) (*os.File, error) {
perm := checkPermission(dir) if checkPermission(dir) {
if perm == true {
return nil, fmt.Errorf("permission denied dir: %s", dir) return nil, fmt.Errorf("permission denied dir: %s", dir)
} }
err := isNotExistMkDir(dir) if err := isNotExistMkDir(dir); err != nil {
if err != nil {
return nil, fmt.Errorf("error during make dir %s, err: %s", dir, err) return nil, fmt.Errorf("error during make dir %s, err: %s", dir, err)
} }

2
lib/logger/logger.go
View File

@@ -55,7 +55,7 @@ func Setup(settings *Settings) {
time.Now().Format(settings.TimeFormat), time.Now().Format(settings.TimeFormat),
settings.Ext) settings.Ext)
logFile, err := mustOpen(fileName, dir) logFile, err = mustOpen(fileName, dir)
if err != nil { if err != nil {
log.Fatalf("logging.Setup err: %s", err) log.Fatalf("logging.Setup err: %s", err)
} }