bugfix: Runtime error will happen in RemoveAllByVal() if iter.remove() removes quicklist's last page (it happens when last page has only one item) and the quicklist is not empty. In this case, iter.atEnd() will be false, which will cause a nil pointer dereference.

Solution: If iter.remove() remove last item, let it meet iter.atEnd().

datastruct/list/quicklist.go

@@ -227,10 +227,17 @@ func (iter *iterator) remove() interface{} {
 	} else {
 		// page is empty, update iter.node and iter.offset
 		if iter.node == iter.ql.data.Back() {
+			// move iter so iter.atEnd() can be true
+			if prevNode := iter.node.Prev(); prevNode != nil {
+				iter.ql.data.Remove(iter.node)
+				iter.node = prevNode
+				iter.offset = len(prevNode.Value.([]interface{}))
+			} else {
 				// removed last element, ql is empty now
 				iter.ql.data.Remove(iter.node)
 				iter.node = nil
 				iter.offset = 0
+			}
 		} else {
 			nextNode := iter.node.Next()
 			iter.ql.data.Remove(iter.node)