apps/redis-go
0
0
Fork 0
mirror of https://github.com/HDT3213/godis.git synced 2025-10-05 16:57:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

bugfix: Runtime error will happen in RemoveAllByVal() if iter.remove() removes quicklist's last page (it happens when last page has only one item) and the quicklist is not empty. In this case, iter.atEnd() will be false, which will cause a nil pointer dereference.

Browse Source 
Solution: If iter.remove() remove last item, let it meet iter.atEnd().
This commit is contained in:
HK40404
2023-08-17 22:53:50 +08:00
committed by finley
parent 3d53ba2d1d
commit 04d118c80c
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
datastruct/list/quicklist.go
View File

@@ -227,10 +227,17 @@ func (iter *iterator) remove() interface{} {
} else { } else {
// page is empty, update iter.node and iter.offset // page is empty, update iter.node and iter.offset
if iter.node == iter.ql.data.Back() { if iter.node == iter.ql.data.Back() {
// removed last element, ql is empty now // move iter so iter.atEnd() can be true
iter.ql.data.Remove(iter.node) if prevNode := iter.node.Prev(); prevNode != nil {
iter.node = nil iter.ql.data.Remove(iter.node)
iter.offset = 0 iter.node = prevNode
iter.offset = len(prevNode.Value.([]interface{}))
} else {
// removed last element, ql is empty now
iter.ql.data.Remove(iter.node)
iter.node = nil
iter.offset = 0
}
} else { } else {
nextNode := iter.node.Next() nextNode := iter.node.Next()
iter.ql.data.Remove(iter.node) iter.ql.data.Remove(iter.node)