apps/go2rtc
1
0
Fork 0
mirror of https://github.com/AlexxIT/go2rtc.git synced 2025-10-04 07:56:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1588 from thomaspurchas/master

Browse Source 
Handle malformed fmtp lines
This commit is contained in:
Alex X
2025-02-17 17:03:01 +03:00
committed by GitHub
parent ad61662cc4 c39c9aa1da
commit c9bdac2e03
1 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/rtsp/helpers.go
View File

@@ -75,6 +75,23 @@ func UnmarshalSDP(rawSDP []byte) ([]*core.Media, error) {
if codec.FmtpLine == "" { if codec.FmtpLine == "" {
codec.FmtpLine = findFmtpLine(codec.PayloadType, sd.MediaDescriptions) codec.FmtpLine = findFmtpLine(codec.PayloadType, sd.MediaDescriptions)
} }
case core.CodecH265:
if codec.FmtpLine != "" {
// All three parameters are needed for a valid fmtp line. If we're missing one
// then discard the entire line. The bitstream should contain the data in NAL units
//
// Some camera brands (notable Hikvision) don't include the vps property, rendering the entire
// line invalid, because the sps property references the non-existent vps proper. This invalid
// data will cause FFmpeg to crash with a `Could not write header (incorrect codec parameters ?): Invalid data found when processing input`
// error when attempting to repackage the HEVC stream into outgoing RTSP stream. Removing the
// fmtp line forces FFmpeg to rely on the bitstream directly, fixing this issue.
valid := strings.Contains(codec.FmtpLine, "sprop-vps=")
valid = valid && strings.Contains(codec.FmtpLine, "sprop-sps=")
valid = valid && strings.Contains(codec.FmtpLine, "sprop-pps=")
if !valid {
codec.FmtpLine = ""
}
}
case core.CodecOpus: case core.CodecOpus:
// fix OPUS for some cameras https://datatracker.ietf.org/doc/html/rfc7587 // fix OPUS for some cameras https://datatracker.ietf.org/doc/html/rfc7587
codec.ClockRate = 48000 codec.ClockRate = 48000