apps/go2rtc
1
0
Fork 0
mirror of https://github.com/AlexxIT/go2rtc.git synced 2025-09-26 20:31:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix insecure PINs for HomeKit server

Browse Source
This commit is contained in:
Alex X
2025-09-19 15:27:58 +03:00
parent 45cbbaf1cf
commit 40269328fb
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/hap/helpers.go
View File

@@ -71,11 +71,17 @@ type JSONCharacter struct {
Event any `json:"ev,omitempty"` Event any `json:"ev,omitempty"`
} }
// 4.2.1.2 Invalid Setup Codes
const insecurePINs = "00000000 11111111 22222222 33333333 44444444 55555555 66666666 77777777 88888888 99999999 12345678 87654321"
func SanitizePin(pin string) (string, error) { func SanitizePin(pin string) (string, error) {
s := strings.ReplaceAll(pin, "-", "") s := strings.ReplaceAll(pin, "-", "")
if len(s) != 8 { if len(s) != 8 {
return "", errors.New("hap: wrong PIN format: " + pin) return "", errors.New("hap: wrong PIN format: " + pin)
} }
if strings.Contains(insecurePINs, s) {
return "", errors.New("hap: insecure PIN: " + pin)
}
// 123-45-678 // 123-45-678
return s[:3] + "-" + s[3:5] + "-" + s[5:], nil return s[:3] + "-" + s[3:5] + "-" + s[5:], nil
} }