From 786d4af40504eaaa71a18f73e2fb237fdf84be20 Mon Sep 17 00:00:00 2001 From: Leandro Santiago Date: Thu, 31 Oct 2024 21:50:45 +0100 Subject: [PATCH] fftools/ffplay: fix crash when vk renderer is null When vulkan rendering is requested by the user and fails, ffplay should exit graciously instead of crash due to a null pointer deref. Signed-off-by: Leandro Santiago Signed-off-by: Zhao Zhili (cherry picked from commit fd0cacc4720c68c58f86e41153444252dbd4e5b6) --- fftools/ffplay.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 048a4a8704..3e1be8038c 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -2605,6 +2605,11 @@ static int create_hwaccel(AVBufferRef **device_ctx) if (type == AV_HWDEVICE_TYPE_NONE) return AVERROR(ENOTSUP); + if (!vk_renderer) { + av_log(NULL, AV_LOG_ERROR, "Vulkan renderer is not available\n"); + return AVERROR(ENOTSUP); + } + ret = vk_renderer_get_hw_dev(vk_renderer, &vk_dev); if (ret < 0) return ret;