From e2f211c00ee1ff65c5e66e90ab738a1dba676d51 Mon Sep 17 00:00:00 2001 From: Leandro Moreira Date: Tue, 13 Feb 2024 16:19:47 -0300 Subject: [PATCH] add hints --- internal/controllers/probers/srt_mpets.go | 3 +++ internal/web/handlers/signaling.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/controllers/probers/srt_mpets.go b/internal/controllers/probers/srt_mpets.go index 64be91d..badab0d 100644 --- a/internal/controllers/probers/srt_mpets.go +++ b/internal/controllers/probers/srt_mpets.go @@ -144,6 +144,9 @@ func (c *SrtMpegTs) fillStreamInfoFromMpegTS(streamInfo map[entities.Codec]entit } if mpegTSDemuxData.PMT != nil { + // TODO: add timing information + // pts https://github.com/asticode/go-astits/blob/b0b19247aa31633650c32638fb55f597fa6e2468/cmd/astits-es-split/main.go#L206 + // https://github.com/asticode/go-astits/blob/master/packet.go#L46 for _, es := range mpegTSDemuxData.PMT.ElementaryStreams { streamInfo[c.m.FromMpegTsStreamTypeToCodec(es.StreamType)] = c.m.FromStreamTypeToEntityStream(es) } diff --git a/internal/web/handlers/signaling.go b/internal/web/handlers/signaling.go index bde7252..3d20eb3 100644 --- a/internal/web/handlers/signaling.go +++ b/internal/web/handlers/signaling.go @@ -70,7 +70,7 @@ func (h *SignalingHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) err } // TODO: introduce a mode to deal with transcoding recipes - // selects prober media that client and server has adverted. + // selects proper media that client and server has adverted. compatibleStreams := donutEngine.CompatibleStreamsFor(serverStreamInfo, clientStreamInfo) if compatibleStreams == nil || len(compatibleStreams) == 0 { return entities.ErrMissingCompatibleStreams