diff --git a/cmd/wice/daemon.go b/cmd/wice/daemon.go index 3f8ce543..c2c8f787 100644 --- a/cmd/wice/daemon.go +++ b/cmd/wice/daemon.go @@ -62,6 +62,7 @@ func daemon(cmd *cobra.Command, args []string) { } if logger.Core().Enabled(zap.DebugLevel) { + logger.Debug("Loaded configuration:") cfg.Dump(&zapio.Writer{Log: logger}) } diff --git a/cmd/wice/docs.go b/cmd/wice/docs.go index ab087f79..b95a0971 100644 --- a/cmd/wice/docs.go +++ b/cmd/wice/docs.go @@ -69,7 +69,7 @@ func docsManpage(cmd *cobra.Command, args []string) error { d, err := time.Parse(time.RFC3339, date) if err != nil { - return fmt.Errorf("failed to parse build date") + d = time.Now() } header := &doc.GenManHeader{ diff --git a/internal/util/util.go b/internal/util/util.go index 440c1385..ebf3b719 100644 --- a/internal/util/util.go +++ b/internal/util/util.go @@ -34,10 +34,6 @@ func CmpNet(a, b *net.IPNet) int { return bytes.Compare(a.IP, b.IP) } -// func lessNets(nets []net.IPNet) Less { -// return func(i, j int) bool { return cmpNet(&nets[i], &nets[j]) < 0 } -// } - // GenerateRandomBytes returns securely generated random bytes. // It will return an error if the system's secure random // number generator fails to function correctly, in which diff --git a/pkg/intf/base.go b/pkg/intf/base.go index 373efd08..deb6878d 100644 --- a/pkg/intf/base.go +++ b/pkg/intf/base.go @@ -64,7 +64,7 @@ func (i *BaseInterface) Close() error { for _, p := range i.peers { if err := p.Close(); err != nil { - return err + return fmt.Errorf("failed to close peer: %w", err) } } diff --git a/pkg/netlink/netlink_test.go b/pkg/netlink/netlink_test.go index 03eab428..cf5a4c00 100644 --- a/pkg/netlink/netlink_test.go +++ b/pkg/netlink/netlink_test.go @@ -32,6 +32,6 @@ func TestWireguardLink(t *testing.T) { } if err := netlink.LinkDel(l); err != nil { - t.Errorf("failed to delete Wireguard device: %w", err) + t.Errorf("failed to delete Wireguard device: %s", err) } } diff --git a/pkg/socket/client.go b/pkg/socket/client.go index e3d40f3e..f05bdb00 100644 --- a/pkg/socket/client.go +++ b/pkg/socket/client.go @@ -55,7 +55,7 @@ func waitForSocket(path string) error { func Connect(path string) (*Client, error) { if err := waitForSocket(path); err != nil { - return nil, fmt.Errorf("failed to wait for socket: %w", err) + return nil, fmt.Errorf("failed to wait for socket: %s: %w", path, err) } tgt := fmt.Sprintf("unix://%s", path) diff --git a/test/e2e/agent.go b/test/e2e/agent.go index ba817bd4..d99cd7c4 100644 --- a/test/e2e/agent.go +++ b/test/e2e/agent.go @@ -23,7 +23,7 @@ import ( "riasc.eu/wice/pkg/socket" ) -// Agent is a host running WICE +// Agent is a host running ɯice type Agent struct { *g.Host @@ -120,7 +120,7 @@ func (a *Agent) Start(directArgs ...interface{}) error { log.Fatal(err) } - cmd, err := buildWICE(a.Network()) + cmd, err := buildBinary(a.Network()) if err != nil { return fmt.Errorf("failed to build wice: %w", err) } diff --git a/test/e2e/build.go b/test/e2e/build.go index 05fddac8..7d727e28 100644 --- a/test/e2e/build.go +++ b/test/e2e/build.go @@ -2,18 +2,23 @@ package e2e import ( "fmt" + "sync" g "github.com/stv0g/gont/pkg" ) var ( // Singleton for compiled wice executable - wiceBinary string + binary string + binaryMutex sync.Mutex ) -func buildWICE(n *g.Network) (string, error) { - if wiceBinary != "" { - return wiceBinary, nil +func buildBinary(n *g.Network) (string, error) { + binaryMutex.Lock() + defer binaryMutex.Unlock() + + if binary != "" { + return binary, nil } wiceBinary := "/tmp/wice" diff --git a/test/e2e/net/filtered.go b/test/e2e/net/filtered.go index 01d5c0af..2e6e9a91 100644 --- a/test/e2e/net/filtered.go +++ b/test/e2e/net/filtered.go @@ -9,7 +9,7 @@ import ( ) func Filtered(p *NetworkParams) (*Network, error) { - // We are dropped packets between the WICE nodes to force ICE using the relay + // We are dropped packets between the ɯice nodes to force ICE using the relay _, hostNetV4, err := net.ParseCIDR("10.0.1.0/24") if err != nil { return nil, err diff --git a/test/e2e/run_test.go b/test/e2e/run_test.go index 2eb6e77d..43369de6 100644 --- a/test/e2e/run_test.go +++ b/test/e2e/run_test.go @@ -46,7 +46,7 @@ func RunTest(t *testing.T, factory net.NetworkFactory, p *net.NetworkParams, arg logger.Info("Starting agent nodes", zap.Int("count", len(n.Agents))) if err := n.Agents.Start(args...); err != nil { - t.Fatalf("Failed to start WICE: %s", err) + t.Fatalf("Failed to start ɯice: %s", err) } defer n.Agents.Stop() diff --git a/test/e2e/signaling_grpc.go b/test/e2e/signaling_grpc.go index 2b9b6099..1e404f09 100644 --- a/test/e2e/signaling_grpc.go +++ b/test/e2e/signaling_grpc.go @@ -51,7 +51,7 @@ func (s *GrpcSignalingNode) Start(_ ...interface{}) error { "--listen", fmt.Sprintf(":%d", s.port), } - cmd, err := buildWICE(s.Network()) + cmd, err := buildBinary(s.Network()) if err != nil { return fmt.Errorf("failed to build wice: %w", err) }