From a6e8b780f81a74400b167adaa550bc68f7612f35 Mon Sep 17 00:00:00 2001
From: YuanRisheng <yuanrisheng@baidu.com>
Date: Wed, 6 Aug 2025 10:36:01 +0800
Subject: [PATCH] fix approve (#3224)

---
 scripts/check_approval.sh | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/scripts/check_approval.sh b/scripts/check_approval.sh
index 3c52c7104..44aa9c390 100644
--- a/scripts/check_approval.sh
+++ b/scripts/check_approval.sh
@@ -24,6 +24,8 @@ echo_list=()
 
 
 function check_approval(){
+    local echo_line="$1"
+    shift
     person_num=`echo $@|awk '{for (i=2;i<=NF;i++)print $i}'`
     APPROVALS=`echo ${approval_line}|python ${FD_ROOT}/scripts/check_pr_approval.py $1 $person_num`
     if [[ "${APPROVALS}" == "FALSE" && "${echo_line}" != "" ]]; then
@@ -40,10 +42,12 @@ function add_failed(){
 
 HAS_CUSTOM_REGISTRER=`git diff -U0 upstream/$BRANCH | grep '^\+' | grep -zoE "PD_BUILD_(STATIC_)?OP" || true`
 if [ ${HAS_CUSTOM_REGISTRER} ] && [ "${PR_ID}" != "" ]; then
-    echo_line="You must have one FastDeploy RD (qingqing01(dangqingqing), Jiang-Jia-Jun(jiangjiajun), heavengate(dengkaipeng)) one QA(DDDivano(zhengtianyu)) one PaddlePaddle RD (XiaoguangHu01(huxiaoguang), jeff41404(gaoxiang), phlrain(liuhongyu)) approval for adding custom op.\n"
-    check_approval 1 qingqing01, Jiang-Jia-Jun, heavengate
-    check_approval 1 XiaoguangHu01 zhiqiu Xreki zhangbo9674 zyfncg phlrain
-    check_approval 1 XiaoguangHu01, jeff41404, phlrain
+    echo_line1="You must have one FastDeploy RD (qingqing01(dangqingqing), Jiang-Jia-Jun(jiangjiajun), heavengate(dengkaipeng)) approval for adding custom op.\n"
+    echo_line2="You must have one QA(DDDivano(zhengtianyu)) approval for adding custom op.\n"
+    echo_line3="You must have one PaddlePaddle RD (XiaoguangHu01(huxiaoguang), jeff41404(gaoxiang), phlrain(liuhongyu)) approval for adding custom op.\n"
+    check_approval "$echo_line1" 1 qingqing01, Jiang-Jia-Jun, heavengate
+    check_approval "$echo_line2" 1 DDDivano
+    check_approval "$echo_line3" 1 XiaoguangHu01, jeff41404, phlrain
 fi