zishuo/ice
1
0
Fork 0
mirror of https://github.com/pion/ice.git synced 2025-12-24 13:38:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove nolint, validate port

Browse Source
This commit is contained in:
Joe Turki
2025-09-22 18:05:29 +03:00
parent ee3a2e4341
commit 3897c30941
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
udp_mux_test.go
View File

@@ -402,6 +402,20 @@ func TestUDPMuxedConn_WriteTo_newIPPortError(t *testing.T) {
require.Error(t, err)
}
func TestUDPMuxedConn_WriteTo_InvalidPort(t *testing.T) {
conn := secondTestMuxedConn(t, 64)
raddr := &net.UDPAddr{IP: net.IPv4(1, 2, 3, 4), Port: -1}
n, err := conn.WriteTo([]byte("x"), raddr)
require.Equal(t, 0, n)
require.ErrorIs(t, err, ErrPort)
raddr = &net.UDPAddr{IP: net.IPv4(1, 2, 3, 4), Port: 0x10000}
n, err = conn.WriteTo([]byte("x"), raddr)
require.Equal(t, 0, n)
require.ErrorIs(t, err, ErrPort)
}
func TestUDPMuxedConn_SetDeadlines(t *testing.T) {
conn := secondTestMuxedConn(t, 64)

7
udp_muxed_conn.go
View File

@@ -103,8 +103,11 @@ func (c *udpMuxedConn) WriteTo(buf []byte, rAddr net.Addr) (n int, err error) {
return 0, errFailedToCastUDPAddr
}
//nolint:gosec // TODO add port validation G115
ipAndPort, err := newIPPort(netUDPAddr.IP, netUDPAddr.Zone, uint16(netUDPAddr.Port))
port := netUDPAddr.Port
if port < 0 || port > 0xFFFF {
return 0, ErrPort
}
ipAndPort, err := newIPPort(netUDPAddr.IP, netUDPAddr.Zone, uint16(port))
if err != nil {
return 0, err
}