Files
frankenphp/watcher/watch_pattern_test.go
Alexander Stecher 8d9b6e755b feat: restart workers when on source changes (#1013)
* Adds filesystem watcher with tests.

* Refactoring.

* Formatting.

* Formatting.

* Switches to absolute path in tests.

* Fixes race condition from merge conflict.

* Fixes race condition.

* Fixes tests.

* Fixes markdown lint errors.

* Switches back to absolute paths.

* Reverts back to relative file paths.

* Fixes golangci-lint issues.

* Uses github.com/dunglas/go-fswatch instead.

* Stops watcher before stopping workers.

* Updates docs.

* Avoids segfault in tests.

* Fixes watcher segmentation violations on shutdown.

* Adjusts watcher latencies and tests.

* Adds fswatch to dockerfiles

* Fixes fswatch in alpine.

* Fixes segfault (this time for real).

* Allows queueing new reload if file changes while workers are reloading.

* Makes tests more consistent.

* Prevents the watcher from getting stuck if there is an error in the worker file itself.

* Reverts changing the image.

* Puts fswatch version into docker-bake.hcl.

* Asserts instead of panicking.

* Adds notice

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update dev.Dockerfile

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update Dockerfile

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update Dockerfile

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update alpine.Dockerfile

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update alpine.Dockerfile

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update dev-alpine.Dockerfile

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update dev-alpine.Dockerfile

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update dev.Dockerfile

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update docs/config.md

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Runs fswatch version.

* Removes .json.

* Replaces ms with s.

* Resets the channel after closing it.

* Update watcher_options.go

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update watcher_test.go

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Asserts no error instead.

* Fixes a race condition where events are fired after frankenphp has stopped.

* Updates docs.

* Update watcher_options_test.go

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Allows queuing events while watchers are reloading.

* go fmt

* Refactors stopping and draining logic.

* Allows extended watcher configuration with dirs, recursion, symlinks, case-sensitivity, latency, monitor types and regex.

* Updates docs.

* Adds TODOS.

* go fmt.

* Fixes linting errors.

* Also allows wildcards in the longform and adjusts docs.

* Adds debug log.

* Fixes the watcher short form.

* Refactors sessions and options into a struct.

* Fixes an overflow in the 'workersReadyWG' on unexpected terminations.

* Properly logs errors coming from session.Start().

* go fmt.

* Adds --nocache.

* Fixes lint issue.

* Refactors and resolves race condition on worker reload.

* Implements debouncing with a timer as suggested by @withinboredom.

* Starts watcher even if no workers are defined.

* Updates docs with file limit warning.

* Adds watch config unit tests.

* Adjusts debounce timings.

* go fmt.

* Adds fswatch to static builder (test).

* Adds a short grace period between stopping and destroying the watcher sessions.

* Adds caddy test.

* Adjusts sleep time.

* Swap to edant/watcher.

* Fixes watch options and tests.

* go fmt.

* Adds TODO.

* Installs edant/watcher in the bookworm image.

* Fixes linting.

* Refactors the watcher into its own module.

* Adjusts naming.

* ADocker image adjustments and refactoring.

* Testing installation methods.

* Installs via gcc instead.

* Fixes pointer formats.

* Fixes lint issues.

* Fixes arm alpine and updates docs.

* Clang format.

* Fixes dirs.

* Adds watcher version arg.

* Uses static lib version.

* Adds watcher to tests and sanitizers.

* Uses sudo for copying the shared lib.

* Removes unnused func.

* Refactoring.

* Update .github/workflows/sanitizers.yaml

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Adds fpic.

* Fixes linting.

* Skips tests in msan.

* Resets op_cache in every worker thread after termination

* Review fixes part 1.

* Test: installing libstc++ instead of gcc.

* Test: using msan ignorelist.

* Test: using msan ignorelist.

* Test: using msan ignorelist.

* Allows '/**/' for global recursion and '**/' for relative recursion.

* Reverts using the ignorelist.

* Calls opcache directly.

* Adds --watch to php-server command

* Properly free CStrings.

* Sorts alphabetically and uses curl instead of git.

* Labeling and formatting.

* Update .github/workflows/sanitizers.yaml

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update .github/workflows/sanitizers.yaml

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update .github/workflows/tests.yaml

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update .github/workflows/tests.yaml

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update caddy/caddy.go

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update docs/config.md

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update frankenphp_with_watcher_test.go

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update watcher/watcher.h

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update frankenphp.c

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update watcher/watcher.go

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update docs/config.md

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update frankenphp_with_watcher_test.go

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update testdata/files/.gitignore

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update watcher/watcher-c.h

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Update watcher/watcher.c

Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>

* Fixes test and Dockerfile.

* Fixes Dockerfiles.

* Resets go versions.

* Replaces unsafe.pointer with uintptr_t

* Prevents worker channels from being destroyed on reload.

* Minimizes the public api by only passing a []string.

* Adds support for directory patterns and multiple '**' globs.

* Adjusts label.

* go fmt.

* go mod tidy.

* Fixes merge conflict.

* Refactoring and formatting.

* Cleans up unused vars and functions.

* Allows dirs with a dot.

* Makes test nicer.

* Add dir tests.

* Moves the watch directive inside the worker directive.

* Adds debug log on special events.

* Removes line about symlinks.

* Hints at multiple possible --watch flags.

* Adds ./**/*.php as default watch configuration.

* Changes error to a warning.

* Changes the default to './**/*.{php,yaml,yml,twig,env}' and supports the {bracket} pattern.

* Fixes linting.

* Fixes merge conflict and adjust values.

* Adjusts values.

---------

Co-authored-by: a.stecher <a.stecher@sportradar.com>
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
2024-10-07 13:17:24 +02:00

163 lines
6.3 KiB
Go

package watcher
import (
"github.com/stretchr/testify/assert"
"path/filepath"
"testing"
)
func TestDisallowOnEventTypeBiggerThan3(t *testing.T) {
const fileName = "/some/path/watch-me.php"
const eventType = 4
watchPattern, err := parseFilePattern("/some/path")
assert.NoError(t, err)
assert.False(t, watchPattern.allowReload(fileName, eventType, 0))
}
func TestDisallowOnPathTypeBiggerThan2(t *testing.T) {
const fileName = "/some/path/watch-me.php"
const pathType = 3
watchPattern, err := parseFilePattern("/some/path")
assert.NoError(t, err)
assert.False(t, watchPattern.allowReload(fileName, 0, pathType))
}
func TestWatchesCorrectDir(t *testing.T) {
hasDir(t, "/path", "/path")
hasDir(t, "/path/", "/path")
hasDir(t, "/path/**/*.php", "/path")
hasDir(t, "/path/*.php", "/path")
hasDir(t, "/path/*/*.php", "/path")
hasDir(t, "/path/?dir/*.php", "/path")
hasDir(t, ".", relativeDir(t, ""))
hasDir(t, "./", relativeDir(t, ""))
hasDir(t, "./**", relativeDir(t, ""))
hasDir(t, "..", relativeDir(t, "/.."))
}
func TestValidRecursiveDirectories(t *testing.T) {
shouldMatch(t, "/path", "/path/file.php")
shouldMatch(t, "/path", "/path/subpath/file.php")
shouldMatch(t, "/path/", "/path/subpath/file.php")
shouldMatch(t, "/path**", "/path/subpath/file.php")
shouldMatch(t, "/path/**", "/path/subpath/file.php")
shouldMatch(t, "/path/**/", "/path/subpath/file.php")
shouldMatch(t, ".", relativeDir(t, "file.php"))
shouldMatch(t, ".", relativeDir(t, "subpath/file.php"))
shouldMatch(t, "./**", relativeDir(t, "subpath/file.php"))
shouldMatch(t, "..", relativeDir(t, "subpath/file.php"))
}
func TestInvalidRecursiveDirectories(t *testing.T) {
shouldNotMatch(t, "/path", "/other/file.php")
shouldNotMatch(t, "/path/**", "/other/file.php")
shouldNotMatch(t, ".", "/other/file.php")
}
func TestValidNonRecursiveFilePatterns(t *testing.T) {
shouldMatch(t, "/*.php", "/file.php")
shouldMatch(t, "/path/*.php", "/path/file.php")
shouldMatch(t, "/path/?ile.php", "/path/file.php")
shouldMatch(t, "/path/file.php", "/path/file.php")
shouldMatch(t, "*.php", relativeDir(t, "file.php"))
shouldMatch(t, "./*.php", relativeDir(t, "file.php"))
}
func TestInValidNonRecursiveFilePatterns(t *testing.T) {
shouldNotMatch(t, "/path/*.txt", "/path/file.php")
shouldNotMatch(t, "/path/*.php", "/path/subpath/file.php")
shouldNotMatch(t, "/*.php", "/path/file.php")
shouldNotMatch(t, "*.txt", relativeDir(t, "file.php"))
shouldNotMatch(t, "*.php", relativeDir(t, "subpath/file.php"))
}
func TestValidRecursiveFilePatterns(t *testing.T) {
shouldMatch(t, "/path/**/*.php", "/path/file.php")
shouldMatch(t, "/path/**/*.php", "/path/subpath/file.php")
shouldMatch(t, "/path/**/?ile.php", "/path/subpath/file.php")
shouldMatch(t, "/path/**/file.php", "/path/subpath/file.php")
shouldMatch(t, "**/*.php", relativeDir(t, "file.php"))
shouldMatch(t, "**/*.php", relativeDir(t, "subpath/file.php"))
shouldMatch(t, "./**/*.php", relativeDir(t, "subpath/file.php"))
}
func TestInvalidRecursiveFilePatterns(t *testing.T) {
shouldNotMatch(t, "/path/**/*.txt", "/path/file.php")
shouldNotMatch(t, "/path/**/*.txt", "/other/file.php")
shouldNotMatch(t, "/path/**/*.txt", "/path/subpath/file.php")
shouldNotMatch(t, "/path/**/?ilm.php", "/path/subpath/file.php")
shouldNotMatch(t, "**/*.php", "/other/file.php")
shouldNotMatch(t, ".**/*.php", "/other/file.php")
shouldNotMatch(t, "./**/*.php", "/other/file.php")
}
func TestValidDirectoryPatterns(t *testing.T) {
shouldMatch(t, "/path/*/*.php", "/path/subpath/file.php")
shouldMatch(t, "/path/*/*/*.php", "/path/subpath/subpath/file.php")
shouldMatch(t, "/path/?/*.php", "/path/1/file.php")
shouldMatch(t, "/path/**/vendor/*.php", "/path/vendor/file.php")
shouldMatch(t, "/path/**/vendor/*.php", "/path/subpath/vendor/file.php")
shouldMatch(t, "/path/**/vendor/**/*.php", "/path/vendor/file.php")
shouldMatch(t, "/path/**/vendor/**/*.php", "/path/subpath/subpath/vendor/subpath/subpath/file.php")
shouldMatch(t, "/path/**/vendor/*/*.php", "/path/subpath/subpath/vendor/subpath/file.php")
shouldMatch(t, "/path*/path*/*", "/path1/path2/file.php")
}
func TestInvalidDirectoryPatterns(t *testing.T) {
shouldNotMatch(t, "/path/subpath/*.php", "/path/other/file.php")
shouldNotMatch(t, "/path/*/*.php", "/path/subpath/subpath/file.php")
shouldNotMatch(t, "/path/?/*.php", "/path/subpath/file.php")
shouldNotMatch(t, "/path/*/*/*.php", "/path/subpath/file.php")
shouldNotMatch(t, "/path/*/*/*.php", "/path/subpath/subpath/subpath/file.php")
shouldNotMatch(t, "/path/**/vendor/*.php", "/path/subpath/vendor/subpath/file.php")
shouldNotMatch(t, "/path/**/vendor/*.php", "/path/subpath/file.php")
shouldNotMatch(t, "/path/**/vendor/**/*.php", "/path/subpath/file.php")
shouldNotMatch(t, "/path/**/vendor/**/*.txt", "/path/subpath/vendor/subpath/file.php")
shouldNotMatch(t, "/path/**/vendor/**/*.php", "/path/subpath/subpath/subpath/file.php")
shouldNotMatch(t, "/path/**/vendor/*/*.php", "/path/subpath/vendor/subpath/subpath/file.php")
shouldNotMatch(t, "/path*/path*", "/path1/path1/file.php")
}
func TestValidExtendedPatterns(t *testing.T) {
shouldMatch(t, "/path/*.{php}", "/path/file.php")
shouldMatch(t, "/path/*.{php,twig}", "/path/file.php")
shouldMatch(t, "/path/*.{php,twig}", "/path/file.twig")
shouldMatch(t, "/path/**/{file.php,file.twig}", "/path/subpath/file.twig")
shouldMatch(t, "/path/{folder1,folder2}/file.php", "/path/folder1/file.php")
}
func TestInValidExtendedPatterns(t *testing.T) {
shouldNotMatch(t, "/path/*.{php}", "/path/file.txt")
shouldNotMatch(t, "/path/*.{php,twig}", "/path/file.txt")
shouldNotMatch(t, "/path/{file.php,file.twig}", "/path/file.txt")
shouldNotMatch(t, "/path/{folder1,folder2}/file.php", "/path/folder3/file.php")
}
func relativeDir(t *testing.T, relativePath string) string {
dir, err := filepath.Abs("./" + relativePath)
assert.NoError(t, err)
return dir
}
func hasDir(t *testing.T, pattern string, dir string) {
watchPattern, err := parseFilePattern(pattern)
assert.NoError(t, err)
assert.Equal(t, dir, watchPattern.dir)
}
func shouldMatch(t *testing.T, pattern string, fileName string) {
watchPattern, err := parseFilePattern(pattern)
assert.NoError(t, err)
assert.True(t, watchPattern.allowReload(fileName, 0, 0))
}
func shouldNotMatch(t *testing.T, pattern string, fileName string) {
watchPattern, err := parseFilePattern(pattern)
assert.NoError(t, err)
assert.False(t, watchPattern.allowReload(fileName, 0, 0))
}