zishuo/frankenphp
1
0
Fork 0
mirror of https://github.com/dunglas/frankenphp.git synced 2025-12-24 13:38:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Adjusts comments.

Browse Source
This commit is contained in:
Alliballibaba
2025-09-14 21:21:20 +02:00
parent 51014177f5
commit db76068dd2
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
latencytracking.go
View File

@@ -18,16 +18,15 @@ const maxPathPartChars = 50
const maxRequestDrainage = 100 const maxRequestDrainage = 100
var ( var (
// TODO: test with different values
// requests taking longer than this are considered slow (var for tests) // requests taking longer than this are considered slow (var for tests)
slowRequestThreshold = 1500 * time.Millisecond slowRequestThreshold = 2000 * time.Millisecond
// % of initial threads that are marked as low latency threads(var for tests) // % of autoscaled threads that are marked as low latency threads(var for tests)
lowLatencyPercentile = 25 lowLatencyPercentile = 20
slowRequestPaths map[string]time.Duration
latencyTrackingEnabled = false latencyTrackingEnabled = false
latencyTrackingActive = atomic.Bool{} latencyTrackingActive = atomic.Bool{}
slowRequestsMu = sync.RWMutex{} slowRequestsMu = sync.RWMutex{}
slowRequestPaths map[string]time.Duration
numRe = regexp.MustCompile(`^\d+$`) numRe = regexp.MustCompile(`^\d+$`)
uuidRe = regexp.MustCompile(`^[a-f0-9-]{36}$`) uuidRe = regexp.MustCompile(`^[a-f0-9-]{36}$`)
) )
@@ -83,6 +82,7 @@ func trackRequestLatency(fc *frankenPHPContext, duration time.Duration, forceTra
if recordedLatency == 0 && latencyTrackingActive.Load() { if recordedLatency == 0 && latencyTrackingActive.Load() {
// a new path that is known to be slow is recorded, // a new path that is known to be slow is recorded,
// drain some requests to free up low-latency threads // drain some requests to free up low-latency threads
// TODO: make sure this overhead is acceptable
out: out:
for i := 0; i < maxRequestDrainage; i++ { for i := 0; i < maxRequestDrainage; i++ {
select { select {
@@ -96,17 +96,18 @@ func trackRequestLatency(fc *frankenPHPContext, duration time.Duration, forceTra
} }
} }
// record the latency as a moving average movingAverage := duration/2 + recordedLatency/2
slowRequestPaths[normalizedPath] = duration/2 + recordedLatency/2 slowRequestPaths[normalizedPath] = movingAverage
// remove the path if it is no longer considered slow // remove the path if it is no longer considered slow
if forceTracking && slowRequestPaths[normalizedPath] < slowRequestThreshold { if forceTracking && movingAverage < slowRequestThreshold {
delete(slowRequestPaths, normalizedPath) delete(slowRequestPaths, normalizedPath)
} }
slowRequestsMu.Unlock() slowRequestsMu.Unlock()
} }
// determine if a request is likely to be high latency based on the request path // determine if a request is likely to be high latency based on previous requests with the same path
func isHighLatencyRequest(fc *frankenPHPContext) bool { func isHighLatencyRequest(fc *frankenPHPContext) bool {
if len(slowRequestPaths) == 0 { if len(slowRequestPaths) == 0 {
return false return false
@@ -123,6 +124,11 @@ func isHighLatencyRequest(fc *frankenPHPContext) bool {
return !fc.isLowLatencyRequest return !fc.isLowLatencyRequest
} }
// normalize a path by replacing variable parts with wildcards
// e.g. /user/123/profile -> /user/:id/profile
//
// /post/550e8400-e29b-41d4-a716-446655440000 -> /post/:uuid
// /category/very-long-category-name -> /category/:slug
func normalizePath(path string) string { func normalizePath(path string) string {
pathLen := len(path) pathLen := len(path)
if pathLen > 1 && path[pathLen-1] == '/' { if pathLen > 1 && path[pathLen-1] == '/' {