update golangci-lint configuration (#944)

.golangci.yml

@@ -12,6 +12,7 @@ linters:
   - gocritic
   - lll
   - misspell
+  - modernize
   - nilerr
   - prealloc
   - predeclared
@@ -71,6 +72,11 @@ linters:
         shadow:
           strict: true
 
+    modernize:
+      disable:
+      - reflecttypefor
+      - stringsbuilder
+
 formatters:
   enable:
   - gofmt

pkg/base/header_test.go

@@ -3,6 +3,7 @@ package base
 import (
 	"bufio"
 	"bytes"
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -133,11 +134,11 @@ func FuzzHeaderUnmarshal(f *testing.F) {
 		f.Add(ca.enc)
 	}
 
-	str := ""
+	var str strings.Builder
 	for range 300 {
-		str += "Key: val\r\n"
+		str.WriteString("Key: val\r\n")
 	}
-	f.Add([]byte(str))
+	f.Add([]byte(str.String()))
 
 	f.Fuzz(func(_ *testing.T, b []byte) {
 		var h Header

pkg/format/rtph264/decoder_test.go

@@ -164,7 +164,7 @@ func TestDecodeAnnexB(t *testing.T) {
 		{0x01, 0x02, 0x03, 0x04},
 	}, nalus)
 
-	for i := 0; i < 2; i++ {
+	for range 2 {
 		nalus, err = d.Decode(&rtp.Packet{
 			Header: rtp.Header{
 				Version:        2,

pkg/format/rtpmjpeg/decoder.go

@@ -125,7 +125,7 @@ func makeQuantizationTables(q uint8) [][]byte {
 
 	tables[0] = make([]byte, 64)
 
-	for i := 0; i < 64; i++ {
+	for i := range 64 {
 		v := (lumaQuantizers[i]*scale + 50) / 100
 		if v > 255 {
 			v = 255
@@ -137,7 +137,7 @@ func makeQuantizationTables(q uint8) [][]byte {
 
 	tables[1] = make([]byte, 64)
 
-	for i := 0; i < 64; i++ {
+	for i := range 64 {
 		v := (chromaQuantizers[i]*scale + 50) / 100
 		if v > 255 {
 			v = 255

pkg/format/rtpmjpeg/encoder.go

@@ -3,7 +3,7 @@ package rtpmjpeg
 import (
 	"crypto/rand"
 	"fmt"
-	"sort"
+	"slices"
 
 	"github.com/pion/rtp"
 
@@ -235,9 +235,7 @@ outer:
 				ids[i] = id
 				i++
 			}
-			sort.Slice(ids, func(i, j int) bool {
-				return ids[i] < ids[j]
-			})
+			slices.Sort(ids)
 
 			// add tables sorted by ID
 			for _, id := range ids {

pkg/format/rtpmjpeg/header_quantization_table.go

@@ -36,7 +36,7 @@ func (h *headerQuantizationTable) unmarshal(byts []byte) (int, error) {
 	h.Tables = make([][]byte, tableCount)
 	n := 0
 
-	for i := 0; i < tableCount; i++ {
+	for i := range tableCount {
 		h.Tables[i] = byts[4+n : 4+64+n]
 		n += 64
 	}

pkg/format/rtpmpeg4audio/decoder_test.go

@@ -53,7 +53,7 @@ func TestDecodeGenericADTS(t *testing.T) {
 	err := d.Init()
 	require.NoError(t, err)
 
-	for i := 0; i < 2; i++ {
+	for range 2 {
 		var aus [][]byte
 		aus, err = d.Decode(&rtp.Packet{
 			Header: rtp.Header{

pkg/multicast/multi_conn_lin.go

@@ -95,7 +95,7 @@ func NewMultiConn(
 			var writeSock int
 			writeSock, err = syscall.Socket(syscall.AF_INET, syscall.SOCK_DGRAM, syscall.IPPROTO_UDP)
 			if err != nil {
-				for j := 0; j < i; j++ {
+				for j := range i {
 					syscall.Close(writeSocks[j]) //nolint:errcheck
 				}
 				syscall.Close(readSock) //nolint:errcheck
@@ -105,7 +105,7 @@ func NewMultiConn(
 			err = syscall.SetsockoptInt(writeSock, syscall.SOL_SOCKET, syscall.SO_REUSEADDR, 1)
 			if err != nil {
 				syscall.Close(writeSock) //nolint:errcheck
-				for j := 0; j < i; j++ {
+				for j := range i {
 					syscall.Close(writeSocks[j]) //nolint:errcheck
 				}
 				syscall.Close(readSock) //nolint:errcheck
@@ -117,7 +117,7 @@ func NewMultiConn(
 			err = syscall.Bind(writeSock, &lsa)
 			if err != nil {
 				syscall.Close(writeSock) //nolint:errcheck
-				for j := 0; j < i; j++ {
+				for j := range i {
 					syscall.Close(writeSocks[j]) //nolint:errcheck
 				}
 				syscall.Close(readSock) //nolint:errcheck
@@ -130,7 +130,7 @@ func NewMultiConn(
 			err = syscall.SetsockoptIPMreqn(writeSock, syscall.IPPROTO_IP, syscall.IP_MULTICAST_IF, &mreqn)
 			if err != nil {
 				syscall.Close(writeSock) //nolint:errcheck
-				for j := 0; j < i; j++ {
+				for j := range i {
 					syscall.Close(writeSocks[j]) //nolint:errcheck
 				}
 				syscall.Close(readSock) //nolint:errcheck
@@ -140,7 +140,7 @@ func NewMultiConn(
 			err = syscall.SetsockoptInt(writeSock, syscall.IPPROTO_IP, syscall.IP_MULTICAST_TTL, multicastTTL)
 			if err != nil {
 				syscall.Close(writeSock) //nolint:errcheck
-				for j := 0; j < i; j++ {
+				for j := range i {
 					syscall.Close(writeSocks[j]) //nolint:errcheck
 				}
 				syscall.Close(readSock) //nolint:errcheck