refactor: remove deprecated options of config flags (#560)

This commit is contained in:
naison
2025-04-24 22:44:20 +08:00
committed by GitHub
parent 6a8a197f48
commit 28657e3832
7 changed files with 8 additions and 8 deletions

View File

@@ -31,7 +31,7 @@ func NewKubeVPNCommand() *cobra.Command {
} }
flags := cmd.PersistentFlags() flags := cmd.PersistentFlags()
configFlags := genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag() configFlags := genericclioptions.NewConfigFlags(true)
configFlags.WrapConfigFn = func(c *rest.Config) *rest.Config { configFlags.WrapConfigFn = func(c *rest.Config) *rest.Config {
if path, ok := os.LookupEnv(config.EnvSSHJump); ok { if path, ok := os.LookupEnv(config.EnvSSHJump); ok {
kubeconfigBytes, err := os.ReadFile(path) kubeconfigBytes, err := os.ReadFile(path)

View File

@@ -236,7 +236,7 @@ func GetClusterIDByConfig(cmd *cobra.Command, config Config) (string, error) {
var sshConf = &pkgssh.SshConfig{} var sshConf = &pkgssh.SshConfig{}
pkgssh.AddSshFlags(flags, sshConf) pkgssh.AddSshFlags(flags, sshConf)
handler.AddExtraRoute(flags, &handler.ExtraRouteInfo{}) handler.AddExtraRoute(flags, &handler.ExtraRouteInfo{})
configFlags := genericclioptions.NewConfigFlags(false).WithDeprecatedPasswordFlag() configFlags := genericclioptions.NewConfigFlags(true)
configFlags.AddFlags(flags) configFlags.AddFlags(flags)
matchVersionFlags := cmdutil.NewMatchVersionFlags(&warp{ConfigFlags: configFlags}) matchVersionFlags := cmdutil.NewMatchVersionFlags(&warp{ConfigFlags: configFlags})
matchVersionFlags.AddFlags(flags) matchVersionFlags.AddFlags(flags)

View File

@@ -107,7 +107,7 @@ func (d *CloneOptions) InitClient(f cmdutil.Factory) (err error) {
} }
return return
} }
configFlags := genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag() configFlags := genericclioptions.NewConfigFlags(true)
configFlags.KubeConfig = pointer.String(d.TargetKubeconfig) configFlags.KubeConfig = pointer.String(d.TargetKubeconfig)
configFlags.Namespace = pointer.String(d.TargetNamespace) configFlags.Namespace = pointer.String(d.TargetNamespace)
matchVersionFlags := cmdutil.NewMatchVersionFlags(configFlags) matchVersionFlags := cmdutil.NewMatchVersionFlags(configFlags)

View File

@@ -162,7 +162,7 @@ func SshJump(ctx context.Context, conf *SshConfig, flags *pflag.FlagSet, print b
} }
}() }()
configFlags := genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag() configFlags := genericclioptions.NewConfigFlags(true)
if conf.RemoteKubeconfig != "" || (flags != nil && flags.Changed("remote-kubeconfig")) { if conf.RemoteKubeconfig != "" || (flags != nil && flags.Changed("remote-kubeconfig")) {
var stdout []byte var stdout []byte

View File

@@ -30,7 +30,7 @@ var (
func before() { func before() {
var err error var err error
configFlags := genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag() configFlags := genericclioptions.NewConfigFlags(true)
f = util.NewFactory(util.NewMatchVersionFlags(configFlags)) f = util.NewFactory(util.NewMatchVersionFlags(configFlags))
if restconfig, err = f.ToRESTConfig(); err != nil { if restconfig, err = f.ToRESTConfig(); err != nil {

View File

@@ -144,7 +144,7 @@ func ConvertToTempKubeconfigFile(kubeconfigBytes []byte) (string, error) {
} }
func InitFactory(kubeconfigBytes string, ns string) cmdutil.Factory { func InitFactory(kubeconfigBytes string, ns string) cmdutil.Factory {
configFlags := genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag() configFlags := genericclioptions.NewConfigFlags(true)
configFlags.WrapConfigFn = func(c *rest.Config) *rest.Config { configFlags.WrapConfigFn = func(c *rest.Config) *rest.Config {
if path, ok := os.LookupEnv(config.EnvSSHJump); ok { if path, ok := os.LookupEnv(config.EnvSSHJump); ok {
bytes, err := os.ReadFile(path) bytes, err := os.ReadFile(path)
@@ -175,7 +175,7 @@ func InitFactory(kubeconfigBytes string, ns string) cmdutil.Factory {
} }
func InitFactoryByPath(kubeconfig string, ns string) cmdutil.Factory { func InitFactoryByPath(kubeconfig string, ns string) cmdutil.Factory {
configFlags := genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag() configFlags := genericclioptions.NewConfigFlags(true)
configFlags.KubeConfig = pointer.String(kubeconfig) configFlags.KubeConfig = pointer.String(kubeconfig)
configFlags.Namespace = pointer.String(ns) configFlags.Namespace = pointer.String(ns)
matchVersionFlags := cmdutil.NewMatchVersionFlags(configFlags) matchVersionFlags := cmdutil.NewMatchVersionFlags(configFlags)

View File

@@ -68,7 +68,7 @@ current-context: localhost`
} }
for _, data := range testData { for _, data := range testData {
configFlags := genericclioptions.NewConfigFlags(false) configFlags := genericclioptions.NewConfigFlags(true)
configFlags.KubeConfig = ptr.To(temp.Name()) configFlags.KubeConfig = ptr.To(temp.Name())
configFlags.Context = ptr.To(data.Context) configFlags.Context = ptr.To(data.Context)
matchVersionFlags := cmdutil.NewMatchVersionFlags(configFlags) matchVersionFlags := cmdutil.NewMatchVersionFlags(configFlags)